Skip to contentSkip to conversation

dt-bindings: crypto: fsl-imx-sahara: Shorten the title

PATCH In review Fabio Estevam 3 participants 5 messages Sep 25, 2023 – Oct 5, 2023

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape Crypto API
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/3 dt-bindings: crypto: fsl-imx-sahara: Shorten the title

From: Fabio Estevam <[email protected]>

In the title, there is no need to mention "included in some i.MX chips" as it is too vague.

Remove it to make it simpler.

While at it, also remove the extra space in the first reg entry.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Squash the removal of leading space. (Krzysztof)

 Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml +2 -2
index d531f3af3ea4..bad82491cd6a 100644
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/crypto/fsl-imx-sahara.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Freescale SAHARA Cryptographic Accelerator included in some i.MX chips
+title: Freescale SAHARA Cryptographic Accelerator
 
 maintainers:
   - Steffen Trumtrar <[email protected]>

@@ -32,6 +32,6 @@ examples:
   - |
     crypto@10025000 {
         compatible = "fsl,imx27-sahara";
-        reg = < 0x10025000 0x800>;
+        reg = <0x10025000 0x800>;
         interrupts = <75>;
     };
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH v2 2/3 dt-bindings: crypto: fsl-imx-sahara: Document the clocks

From: Fabio Estevam <[email protected]>

Describe the clocks (ipg and ahb) needed by Sahara block to operate.

Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>

---
Changes since v1:
- Simplify the commit log. (Krzysztof)

 .../bindings/crypto/fsl-imx-sahara.yaml         | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml +17 -0
index bad82491cd6a..9dbfc15510a8 100644
@@ -21,17 +21,34 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    items:
+      - description: Sahara IPG clock
+      - description: Sahara AHB clock
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: ahb
+
 required:
   - compatible
   - reg
   - interrupts
+  - clocks
+  - clock-names
 
 additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx27-clock.h>
+
     crypto@10025000 {
         compatible = "fsl,imx27-sahara";
         reg = <0x10025000 0x800>;
         interrupts = <75>;
+        clocks = <&clks IMX27_CLK_SAHARA_IPG_GATE>,
+                 <&clks IMX27_CLK_SAHARA_AHB_GATE>;
+        clock-names = "ipg", "ahb";
     };
Signature · 1 line
2.34.1
author reviewer
#2 lore raw

PATCH v2 3/3 dt-bindings: crypto: fsl-imx-sahara: Fix the number of irqs

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

i.MX27 has only one Sahara interrupt. i.MX53 has two.

Describe this difference.

Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>

---
Changes since v1:
- Placed the if block before additionalProperties. (Krzysztof)
- Remove extra minItems = 1. (Krzysztof)

 .../bindings/crypto/fsl-imx-sahara.yaml       | 22 ++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml +21 -1
index 9dbfc15510a8..41df80bcdcd9 100644
@@ -19,7 +19,10 @@ properties:
     maxItems: 1
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: SAHARA Interrupt for Host 0
+      - description: SAHARA Interrupt for Host 1
+    minItems: 1
 
   clocks:
     items:

@@ -38,6 +41,23 @@ required:
   - clocks
   - clock-names
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx53-sahara
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2
+    else:
+      properties:
+        interrupts:
+          maxItems: 1
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.34.1
maintainer
#4 lore raw
In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

In the title, there is no need to mention "included in some i.MX chips" as it is too vague.

Remove it to make it simpler.

While at it, also remove the extra space in the first reg entry.

Quoted 7 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Squash the removal of leading space. (Krzysztof)

 Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

All applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt