dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
Subsystems (5)
Rob Herring
maintainerPATCH 1/2 dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node.
--- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/msm/dp-controller.yaml +1 -0
@@ -114,6 +114,7 @@ properties: port@1: $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false description: Output endpoint of the controller properties: endpoint:
Signature · 1 line
2.40.1
Rob Herring
maintainerPATCH 2/2 dt-bindings: display: msm: Make "additionalProperties: true" explicit
Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.
--- .../bindings/display/msm/qcom,msm8998-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,qcm2290-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sc7180-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sc7280-mdss.yaml | 10 ++++++++++ .../bindings/display/msm/qcom,sc8280xp-mdss.yaml | 4 ++++ .../bindings/display/msm/qcom,sdm845-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sm6115-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm6125-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm6350-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm6375-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm8150-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm8250-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm8350-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sm8450-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sm8550-mdss.yaml | 8 ++++++++ 15 files changed, 102 insertions(+)
Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml +6 -0
@@ -38,12 +38,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,msm8998-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -52,6 +56,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nm-8998
Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml +6 -0
@@ -44,18 +44,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,qcm2290-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-ctrl-6g-qcm2290 "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-14nm-2290
Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml +8 -0
@@ -44,18 +44,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7180-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7180-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -64,6 +70,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nm
Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml +10 -0
@@ -44,18 +44,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7280-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7280-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -64,12 +70,16 @@ patternProperties: "^edp@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7280-edp "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: enum:
Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml +4 -0
@@ -34,12 +34,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc8280xp-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: enum:
Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml +8 -0
@@ -42,18 +42,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sdm845-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sdm845-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -62,6 +68,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nm
Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml +6 -0
@@ -32,12 +32,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6115-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: oneOf:
@@ -50,6 +54,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-14nm-2290
Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml +6 -0
@@ -43,12 +43,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6125-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -57,6 +61,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6125-dsi-phy-14nm
Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml +6 -0
@@ -43,12 +43,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6350-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -57,6 +61,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nm
Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml +6 -0
@@ -43,12 +43,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6375-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -57,6 +61,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6375-dsi-phy-7nm
Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml +6 -0
@@ -47,12 +47,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8150-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -61,6 +65,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-7nm
Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml +6 -0
@@ -46,12 +46,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8250-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -60,6 +64,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-7nm
Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml +8 -0
@@ -48,18 +48,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8350-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8350-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -68,6 +74,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8350-dsi-phy-5nm
Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml +8 -0
@@ -38,12 +38,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8450-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -52,6 +56,8 @@ patternProperties: "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -60,6 +66,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8450-dsi-phy-5nm
Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml +8 -0
@@ -38,12 +38,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8550-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -52,6 +56,8 @@ patternProperties: "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:
@@ -60,6 +66,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8550-dsi-phy-4nm
Signature · 1 line
2.40.1
Re: [PATCH 2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
Quoted 5 lines · Rob Herring
Make it explicit that child nodes have additional properties and the child node schema is not complete. The complete schemas are applied separately based the compatible strings.
Signed-off-by Rob Herring <[email protected]>
I cross-checked only a handful of these...
Thanks,
Conor.
Quoted 519 lines
--- .../bindings/display/msm/qcom,msm8998-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,qcm2290-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sc7180-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sc7280-mdss.yaml | 10 ++++++++++ .../bindings/display/msm/qcom,sc8280xp-mdss.yaml | 4 ++++ .../bindings/display/msm/qcom,sdm845-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sm6115-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm6125-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm6350-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm6375-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm8150-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm8250-mdss.yaml | 6 ++++++ .../bindings/display/msm/qcom,sm8350-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sm8450-mdss.yaml | 8 ++++++++ .../bindings/display/msm/qcom,sm8550-mdss.yaml | 8 ++++++++ 15 files changed, 102 insertions(+)Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml +6
-0@@ -38,12 +38,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,msm8998-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -52,6 +56,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nm-8998Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml +6
-0@@ -44,18 +44,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,qcm2290-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-ctrl-6g-qcm2290 "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-14nm-2290Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml +8
-0@@ -44,18 +44,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7180-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7180-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -64,6 +70,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nmDocumentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml +10
-0@@ -44,18 +44,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7280-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7280-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -64,12 +70,16 @@ patternProperties: "^edp@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc7280-edp "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: enum:Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml +4
-0@@ -34,12 +34,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sc8280xp-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: enum:Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml +8
-0@@ -42,18 +42,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sdm845-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sdm845-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -62,6 +68,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nmDocumentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml +6
-0@@ -32,12 +32,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6115-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: oneOf:@@ -50,6 +54,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-14nm-2290Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml +6
-0@@ -43,12 +43,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6125-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -57,6 +61,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6125-dsi-phy-14nmDocumentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml +6
-0@@ -43,12 +43,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6350-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -57,6 +61,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-10nmDocumentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml +6
-0@@ -43,12 +43,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6375-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -57,6 +61,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm6375-dsi-phy-7nmDocumentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml +6
-0@@ -47,12 +47,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8150-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -61,6 +65,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-7nmDocumentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml +6
-0@@ -46,12 +46,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8250-dpu "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -60,6 +64,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,dsi-phy-7nmDocumentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml +8
-0@@ -48,18 +48,24 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8350-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8350-dp "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -68,6 +74,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8350-dsi-phy-5nmDocumentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml +8
-0@@ -38,12 +38,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8450-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -52,6 +56,8 @@ patternProperties: "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -60,6 +66,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8450-dsi-phy-5nmDocumentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml +8
-0@@ -38,12 +38,16 @@ properties: patternProperties: "^display-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8550-dpu "^displayport-controller@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -52,6 +56,8 @@ patternProperties: "^dsi@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: items:@@ -60,6 +66,8 @@ patternProperties: "^phy@[0-9a-f]+$": type: object + additionalProperties: true + properties: compatible: const: qcom,sm8550-dsi-phy-4nmSignature · 1 line
2.40.1
Quoted 6 lines · Rob Herring
Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node.
Signed-off-by Rob Herring <[email protected]>
Thanks,
Conor.
Quoted 19 lines
--- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/display/msm/dp-controller.yaml +1
-0@@ -114,6 +114,7 @@ properties: port@1: $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false description: Output endpoint of the controller properties: endpoint:Signature · 1 line
2.40.1
Dmitry Baryshkov
AppliedQuoted 6 lines · Rob Herring
Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node.
Applied, thanks!
[1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
https://gitlab.freedesktop.org/lumag/msm/-/commit/08bf97ab16f3
[2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
https://gitlab.freedesktop.org/lumag/msm/-/commit/55bbcadccdec
Best regards,
Signature · 1 line
Dmitry Baryshkov <[email protected]>