Skip to contentSkip to conversation

oe-find-native-sysroot: avoid warning message messing things up

PATCH NAK [email protected] 3 participants 4 messages Sep 26, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 oe-find-native-sysroot: avoid warning message messing things up

From: Chen Qi <[email protected]>

Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result.

---
 scripts/oe-find-native-sysroot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/oe-find-native-sysroot +1 -1
index 6228efcbee..541318b461 100755
@@ -38,7 +38,7 @@ fi
 # Global vars
 set_oe_native_sysroot(){
     echo "Getting sysroot..."
-    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE)
+    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE)
 }
 
 if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then
Signature · 1 line
2.40.0
#1 lore raw

Hi Chen,

I have raised this when it lands
https://lists.openembedded.org/g/openembedded-core/message/187378

Tested.by: Jose Quaresma <[email protected]>

Jose

Chen Qi via lists.openembedded.org <Qi.Chen= [email protected]> escreveu no dia terça, 26/09/2023 à(s) 11:15:

Quoted 41 lines

From: Chen Qi <[email protected]>

Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result.

---
 scripts/oe-find-native-sysroot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/oe-find-native-sysroot +1 -1
index 6228efcbee..541318b461 100755
@@ -38,7 +38,7 @@ fi
 # Global vars
 set_oe_native_sysroot(){
     echo "Getting sysroot..."
-    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value
 STAGING_DIR_NATIVE)
+    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value
 STAGING_DIR_NATIVE)
 }

if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then
--
2.40.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#188242):
https://lists.openembedded.org/g/openembedded-core/message/188242
Mute This Topic: https://lists.openembedded.org/mt/101592501/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma
#2 lore raw

NAK

This is no longer needed since commit 6b7883533 (bitbake-getvar: Make --value imply –quiet) landed in bitbake.

//Peter

From: [email protected] <[email protected]> On Behalf Of Jose Quaresma
Sent: den 26 september 2023 12:21
To: [email protected]
Cc: [email protected]
Subject: Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up

Hi Chen,

I have raised this when it lands
https://lists.openembedded.org/g/openembedded-core/message/187378

Tested.by: Jose Quaresma <[email protected]<mailto:[email protected]>>
Jose
Chen Qi via lists.openembedded.org<http://lists.openembedded.org> <[email protected]<mailto:[email protected]>> escreveu no dia terça, 26/09/2023 à(s) 11:15:
From: Chen Qi <[email protected]<mailto:[email protected]>>

Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result.

---
 scripts/oe-find-native-sysroot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/oe-find-native-sysroot +1 -1
index 6228efcbee..541318b461 100755
@@ -38,7 +38,7 @@ fi
 # Global vars
 set_oe_native_sysroot(){
     echo "Getting sysroot..."
-    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE)
+    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE)
 }
 
 if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then

--
2.40.0

--
Best regards,

José Quaresma

author NAK
#3 lore raw

Just noticed your patches. Yes, this patch is not needed.

Regards,
Qi

From: Peter Kjellerstedt <[email protected]>
Sent: Tuesday, September 26, 2023 9:10 PM
To: Jose Quaresma <[email protected]>; Chen, Qi <[email protected]>
Cc: [email protected]
Subject: RE: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up

NAK

This is no longer needed since commit 6b7883533 (bitbake-getvar: Make --value imply –quiet) landed in bitbake.

//Peter

From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> On Behalf Of Jose Quaresma
Sent: den 26 september 2023 12:21
To: [email protected]<mailto:[email protected]>
Cc: [email protected]<mailto:[email protected]>
Subject: Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up

Hi Chen,

I have raised this when it lands
https://lists.openembedded.org/g/openembedded-core/message/187378<https://urldefense.com/v3/__https:/lists.openembedded.org/g/openembedded-core/message/187378__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgINwfzZE$>

Tested.by<https://urldefense.com/v3/__http:/Tested.by__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgVUqchqA$>: Jose Quaresma <[email protected]<mailto:[email protected]>>
Jose
Chen Qi via lists.openembedded.org<https://urldefense.com/v3/__http:/lists.openembedded.org__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgL6RxaeA$> <[email protected]<mailto:[email protected]>> escreveu no dia terça, 26/09/2023 à(s) 11:15:
From: Chen Qi <[email protected]<mailto:[email protected]>>

Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result.

---
 scripts/oe-find-native-sysroot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/oe-find-native-sysroot +1 -1
index 6228efcbee..541318b461 100755
@@ -38,7 +38,7 @@ fi
 # Global vars
 set_oe_native_sysroot(){
     echo "Getting sysroot..."
-    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE)
+    OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE)
 }
 
 if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then

--
2.40.0

--
Best regards,

José Quaresma