Skip to contentSkip to conversation

dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043

PATCH Superseded Fabio Estevam 2 participants 5 messages Sep 26, 2023 – Sep 27, 2023

Subsystems (3)
Device tree bindings USB Arm i.MX and Layerscape

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/3 dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043

From: Fabio Estevam <[email protected]>

Add a compatible entry for the NXP CBDTU02043 GPIO-based mux hardware used for connecting, disconnecting and switching orientation of the SBU lines in USB Type-C applications.

CBTU02043 datasheet: https://www.nxp.com/docs/en/data-sheet/CBTU02043.pdf

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>

---
Changes since v1:
- None. Only collected Conor's Ack.

 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +1 -0
index f196beb826d8..b61dcf8b4aad 100644
@@ -19,6 +19,7 @@ properties:
   compatible:
     items:
       - enum:
+          - nxp,cbdtu02043
           - onnn,fsusb43l10x
           - pericom,pi3usb102
       - const: gpio-sbu-mux
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH v2 2/3 arm64: dts: imx8qxp-mek: Fix gpio-sbu-mux compatible

From: Fabio Estevam <[email protected]>

Per gpio-sbu-mux.yaml, the compatible entry is incomplete.

The imx8qxp-mek board uses a CBDTU02043, so complete the gpio-sbu-mux compatible accordingly.

This fixes the following schema warning:

imx8qxp-mek.dtb: gpio-sbu-mux: compatible:0: 'gpio-sbu-mux' is not one of ['onnn,fsusb43l10x', 'pericom,pi3usb102']
from schema $id: http://devicetree.org/schemas/usb/gpio-sbu-mux.yaml#

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Added space to separate compatible entries. (Krzysztof)

 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +1 -1
index 7924b0969ad8..a06a6491ef20 100644
@@ -31,7 +31,7 @@ reg_usdhc2_vmmc: usdhc2-vmmc {
 	};
 
 	gpio-sbu-mux {
-		compatible = "gpio-sbu-mux";
+		compatible = "nxp,cbdtu02043", "gpio-sbu-mux";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_typec_mux>;
 		select-gpios = <&lsio_gpio5 9 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.34.1
author reviewer
#2 lore raw

PATCH v2 3/3 arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux mode-switch

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Per gpio-sbu-mux.yaml, the 'mode-switch' property is mandatory.

Pass it to fix the following schema warning:

imx8qxp-mek.dtb: gpio-sbu-mux: 'mode-switch' is a required property
from schema $id: http://devicetree.org/schemas/usb/gpio-sbu-mux.yaml#

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- None.

 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +1 -0
index a06a6491ef20..f95b58c69c6a 100644
@@ -36,6 +36,7 @@ gpio-sbu-mux {
 		pinctrl-0 = <&pinctrl_typec_mux>;
 		select-gpios = <&lsio_gpio5 9 GPIO_ACTIVE_HIGH>;
 		enable-gpios = <&pca9557_a 7 GPIO_ACTIVE_LOW>;
+		mode-switch;
 		orientation-switch;
 
 		port {
Signature · 1 line
2.34.1
#3 lore raw

RE: [PATCH v2 3/3] arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux mode-switch

Quoted 42 lines

-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: Tuesday, September 26, 2023 6:28 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>; Fabio Estevam <[email protected]>
Subject: [PATCH v2 3/3] arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux mode-switch

From: Fabio Estevam <[email protected]>

Per gpio-sbu-mux.yaml, the 'mode-switch' property is mandatory.

Pass it to fix the following schema warning:

imx8qxp-mek.dtb: gpio-sbu-mux: 'mode-switch' is a required property
from schema $id:
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevice
tree.org%2Fschemas%2Fusb%2Fgpio-sbu-mux.yaml%23&data=05%7C01%7Cjun.li%4 0nxp.com%7C81075d4568d24477088408dbbe7b67f5%7C686ea1d3bc2b4c6fa92cd99c5 c301635%7C0%7C0%7C638313209472999434%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7 C&sdata=GfQ15vL%2BIQoX9u8tFW60aO%2FrGDLEOBfQoKqP%2FN7tHXY%3D&reserved=0

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- None.

 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0 -0
index a06a6491ef20..f95b58c69c6a 100644

arch/arm64/boot/dts/freescale/imx8qxp-mek.dts gpio-sbu-mux { · line 39

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +1 -0
@@ -36,6 +36,7 @@ gpio-sbu-mux {
 		pinctrl-0 = <&pinctrl_typec_mux>;
 		select-gpios = <&lsio_gpio5 9 GPIO_ACTIVE_HIGH>;
 		enable-gpios = <&pca9557_a 7 GPIO_ACTIVE_LOW>;
+		mode-switch;

mode-switch:
description: Flag the port as possible handle of altmode switching
type: boolean

I don't think there is altmode enabled on iMX8QXP MEK board, there is only an orientation switch.

Li Jun

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +0 -1
 		orientation-switch;
 
 		port {
--

2.34.1

author reviewer
#4 lore raw

Re: [PATCH v2 3/3] arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux mode-switch

Hi Li Jun,

Quoted 6 lines · Jun Li

mode-switch:
description: Flag the port as possible handle of altmode switching
type: boolean

I don't think there is altmode enabled on iMX8QXP MEK board, there is only an orientation switch.

Okay, so I will send a change that removes mode-switch from the required properties list then.

Thanks