media: pci: intel: ivsc: select V4L2_FWNODE
Subsystems (2)
PATCH 1/1 media: pci: intel: ivsc: select V4L2_FWNODE
From: Arnd Bergmann <[email protected]>
Some missing select statements were already added back, but I ran into another one that is missing:
ERROR: modpost: "v4l2_fwnode_endpoint_free" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
ERROR: modpost: "v4l2_fwnode_endpoint_alloc_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
ERROR: modpost: "v4l2_fwnode_endpoint_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
--- drivers/media/pci/intel/ivsc/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/media/pci/intel/ivsc/Kconfig +1 -0
@@ -7,6 +7,7 @@ config INTEL_VSC select MEDIA_CONTROLLER select VIDEO_V4L2_SUBDEV_API select V4L2_ASYNC + select V4L2_FWNODE help This adds support for Intel Visual Sensing Controller (IVSC).
Signature · 1 line
2.39.2
Sakari Ailus
maintainerHi Arnd,
Quoted 20 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Some missing select statements were already added back, but I ran into another one that is missing:
ERROR: modpost: "
v4l2_fwnode_endpoint_free" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
ERROR: modpost: "v4l2_fwnode_endpoint_alloc_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
ERROR: modpost: "v4l2_fwnode_endpoint_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!Fixes 29006e196a566 ("media: pci: intel: ivsc: Add CSI submodule")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/media/pci/intel/ivsc/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/media/pci/intel/ivsc/Kconfig +0
-0
drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 10
Quoted 4 lines
drivers/media/pci/intel/ivsc/Kconfig +1
-0@@ -7,6 +7,7 @@ config INTEL_VSC select MEDIA_CONTROLLER select VIDEO_V4L2_SUBDEV_API select V4L2_ASYNC + select V4L2_FWNODE
Thanks for the fix.
V4L2_FWNODE already implies V4L2_ASYNC so V4L2_ASYNC can be removed. I somehow thought this only needed V4L2_ASYNC but that indeed is not the case.
I'll just drop the line selecting V4L2_ASYNC above if that's fine.
Quoted 3 lines
drivers/media/pci/intel/ivsc/Kconfig +0
-0help This adds support for Intel Visual Sensing Controller (IVSC).
Signature · 3 lines
Regards, Sakari Ailus
Quoted 7 lines · Sakari Ailus
V4L2_FWNODEalready impliesV4L2_ASYNCsoV4L2_ASYNCcan be removed. I somehow thought this only neededV4L2_ASYNCbut that indeed is not the case.I'll just drop the line selecting
V4L2_ASYNCabove if that's fine.
Sure, sounds good to me.
Arnd