RDMA/cma: Initialize ib_sa_multicast structure to 0 when join
PATCH 1/1 RDMA/cma: Initialize ib_sa_multicast structure to 0 when join
Initialize the structure to 0 so that it's fields won't have random values. For example fields like rec.traffic_class (as well as rec.flow_label and rec.sl) is used to generate the user AH through:
cma_iboe_join_multicast
cma_make_mc_event
ib_init_ah_from_mcmember
And a random traffic_class causes a random IP DSCP in RoCEv2.
---
Changelog:
v1:
* Initialize the ib_sa_multicast structure instead of the rec.traffic_class field only
v0: https://lore.kernel.org/all/[email protected]/
--- drivers/infiniband/core/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/core/cma.c +1 -1
@@ -4968,7 +4968,7 @@ static int cma_iboe_join_multicast(struct rdma_id_private *id_priv,int err =0 ;struct sockaddr *addr = (struct sockaddr *)&mc->addr;struct net_device *ndev =NULL ; -struct ib_sa_multicast ib; +struct ib_sa_multicast ib = {};enum ib_gid_type gid_type;bool send_only;
Signature · 1 line
2.37.1
Leon Romanovsky
AppliedQuoted 8 lines · Mark Zhang
Initialize the structure to 0 so that it's fields won't have random values. For example fields like rec.traffic_class (as well as rec.flow_label and rec.sl) is used to generate the user AH through:
cma_iboe_join_multicast
cma_make_mc_event
ib_init_ah_from_mcmember[...]
Applied, thanks!
[1/1] RDMA/cma: Initialize ib_sa_multicast structure to 0 when join
https://git.kernel.org/rdma/rdma/c/76ad7aca17e88e
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>