media: dt-bindings: hynix,hi846: Document orientation and rotation
Subsystems (2)
PATCH 1/1 media: dt-bindings: hynix,hi846: Document orientation and rotation
From: Fabio Estevam <[email protected]>
Document the 'orientation' and 'rotation' properties, which are valid for the SK Hynix Hi-846 sensor.
--- Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml +4 -0
@@ -48,6 +48,10 @@ properties: vddd-supply: description: Definition of the regulator used for the VDDD power supply. + orientation: true + + rotation: true + port: $ref: /schemas/graph.yaml#/$defs/port-base unevaluatedProperties: false
Signature · 1 line
2.34.1
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Document the 'orientation' and 'rotation' properties, which are valid for the SK Hynix Hi-846 sensor.
Signed-off-by Fabio Estevam <[email protected]>
Best regards,
Krzysztof
Am Mittwoch, dem 27.09.2023 um 15:16 -0300 schrieb Fabio Estevam:
Quoted 26 lines
From: Fabio Estevam <[email protected]>
Document the 'orientation' and 'rotation' properties, which are valid for the SK Hynix Hi-846 sensor.
Signed-off-by Fabio Estevam <[email protected]>---
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 4
++++1 file changed, 4 insertions(+)diff --git
a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yamlb/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yamlindex1e2df8cf2937..ab0ff6f60fc0100644Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml +0
-0@@ -48,6 +48,10 @@ properties:vddd-supply:
description: Definition of the regulator used for the VDDD power supply.
+ orientation: trueDocumentation/devicetree/bindings/media/i2c/hynix,hi846.yaml +3
-0+ + rotation: true +
Quoted 3 lines
port:
$ref: /schemas/graph.yaml#/$defs/port-base
unevaluatedProperties: false
hi Fabio,
thanks a lot, I like to have this fixed. I always thought we could re- use media/video-interface-devices.yaml for these properties somehow...
if your change is preferred,
martin
Hi Martin,
On 28/09/2023 06:20, Martin Kepplinger wrote:
unevaluatedProperties: false
Quoted 9 lines
hi Fabio,
thanks a lot, I like to have this fixed. I always thought we could re- use
media/video-interface-devices.yamlfor these properties somehow...if your change is preferred,
Good point on video-interface-devices.yaml.
Indeed, we should pass a reference to it.
Otherwise, after this patch, hynix,hi846.yaml will only check for the presence of orientation/rotation properties and not check whether the values are valid.
I will submit a v2 that adds the aditional ref to video-interface-devices.yaml
Thanks!