Skip to contentSkip to conversation

ARM: locomo: fix locomolcd_power declaration

PATCH Applied Arnd Bergmann 2 participants 2 messages Sep 27, 2023 – Sep 28, 2023

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 ARM: locomo: fix locomolcd_power declaration

From: Arnd Bergmann <[email protected]>

The locomolcd driver has one remaining missing-prototype warning:

drivers/video/backlight/locomolcd.c:83:6: error: no previous prototype for 'locomolcd_power' [-Werror=missing-prototypes]

There is in fact an unused prototype with a similar name in a global header, so move the actual one there and remove the old one.

Signed-off-by Arnd Bergmann <[email protected]>
---
 arch/arm/include/asm/hardware/locomo.h     | 2 +-
 arch/arm/mach-sa1100/include/mach/collie.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)
arch/arm/include/asm/hardware/locomo.h +1 -1
index 246a3de25931d..aaaedafef7cce 100644
@@ -195,7 +195,7 @@ struct locomo_driver {
 
 #define LOCOMO_DRIVER_NAME(_ldev) ((_ldev)->dev.driver->name)
 
-void locomo_lcd_power(struct locomo_dev *, int, unsigned int);
+extern void locomolcd_power(int on);
 
 int locomo_driver_register(struct locomo_driver *);
 void locomo_driver_unregister(struct locomo_driver *);
arch/arm/mach-sa1100/include/mach/collie.h +0 -2
index b7bc23ffd3c69..c95273c9567bb 100644
@@ -16,8 +16,6 @@
 
 #include "hardware.h" /* Gives GPIO_MAX */
 
-extern void locomolcd_power(int on);
-
 #define COLLIE_SCOOP_GPIO_BASE	(GPIO_MAX + 1)
 #define COLLIE_GPIO_CHARGE_ON	(COLLIE_SCOOP_GPIO_BASE + 0)
 #define COLLIE_SCP_DIAG_BOOT1	SCOOP_GPCR_PA12
Signature · 1 line
2.39.2
CI Applied
#1 lore raw
This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <[email protected]>:

Quoted 10 lines · On Wed, 27 Sep 2023 21:38:10 +0200 you wrote:

From: Arnd Bergmann <[email protected]>

The locomolcd driver has one remaining missing-prototype warning:

drivers/video/backlight/locomolcd.c:83:6: error: no previous prototype for 'locomolcd_power' [-Werror=missing-prototypes]

There is in fact an unused prototype with a similar name in a global header, so move the actual one there and remove the old one.

[...]

Here is the summary with links:
- ARM: locomo: fix locomolcd_power declaration

    https://git.kernel.org/soc/soc/c/5e8a380b2dd3

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html