Skip to contentSkip to conversation

Hugetlb: Migrating libhugetlbfs test truncate_reserve_wraparound.c

PATCH Superseded Geetika 2 participants 3 messages Sep 28, 2023 – Mar 27, 2024

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Geetika

author
#0 lore raw

PATCH 1/1 Hugetlb: Migrating libhugetlbfs test truncate_reserve_wraparound.c

Test Description:
Test to verify the Hugepages_Rsvd before and after mmap, truncate and sigbus operations. At one stage, improper handling of tests against i_size could mess
up accounting of reserved hugepages on certain truncate operations.

---
 runtest/hugetlb                               |   1 +
 testcases/kernel/mem/.gitignore               |   1 +
 .../kernel/mem/hugetlb/hugemmap/hugemmap38.c  | 124 ++++++++++++++++++
 3 files changed, 126 insertions(+)
 create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap38.c
runtest/hugetlb +1 -0
index 299c07ac9..2ffd35aec 100644
@@ -35,6 +35,7 @@ hugemmap29 hugemmap29
 hugemmap30 hugemmap30
 hugemmap31 hugemmap31
 hugemmap32 hugemmap32
+hugemmap38 hugemmap38
 hugemmap05_1 hugemmap05 -m
 hugemmap05_2 hugemmap05 -s
 hugemmap05_3 hugemmap05 -s -m
testcases/kernel/mem/.gitignore +1 -0
index 7258489ed..346bf9533 100644
@@ -34,6 +34,7 @@
 /hugetlb/hugemmap/hugemmap30
 /hugetlb/hugemmap/hugemmap31
 /hugetlb/hugemmap/hugemmap32
+/hugetlb/hugemmap/hugemmap38
 /hugetlb/hugeshmat/hugeshmat01
 /hugetlb/hugeshmat/hugeshmat02
 /hugetlb/hugeshmat/hugeshmat03
testcases/kernel/mem/hugetlb/hugemmap/hugemmap38.c new file +124 -0

124 lines not on this page · raw message

Signature · 5 lines
2.39.2 (Apple Git-143)


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi,

Please have look at my comments at your colleague patch [1] [2], these changes apply a lot for your patches as well.

[1] https://lore.kernel.org/ltp/20231128111024.GA364870@pevik/
[2] https://lore.kernel.org/ltp/20231128112254.GA367506@pevik/

...

runtest/hugetlb hugemmap29 hugemmap29 · line 38

Quoted 6 lines

+++ b/runtest/hugetlb

runtest/hugetlb +1 -0
@@ -35,6 +35,7 @@ hugemmap29 hugemmap29
 hugemmap30 hugemmap30
 hugemmap31 hugemmap31
 hugemmap32 hugemmap32
+hugemmap38 hugemmap38

nit: Why not hugemmap34? (your colleague used hugemmap33 for his patch [1].

runtest/hugetlb hugemmap29 hugemmap29 · line 41

Quoted 3 lines
runtest/hugetlb +0 -0
 hugemmap05_1 hugemmap05 -m
 hugemmap05_2 hugemmap05 -s
 hugemmap05_3 hugemmap05 -s -m

...

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#2 lore raw
Quoted 7 lines · Petr Vorel

Hi,

Please have look at my comments at your colleague patch [1] [2], these changes apply a lot for your patches as well.

[1] https://lore.kernel.org/ltp/20231128111024.GA364870@pevik/
[2] https://lore.kernel.org/ltp/20231128112254.GA367506@pevik/

I will have a look at both of these and apply the changes that apply to this testcase and send the next version.

Quoted 8 lines

...

runtest/hugetlb hugemmap29 hugemmap29 · line 38

Quoted 6 lines

+++ b/runtest/hugetlb

runtest/hugetlb +1 -0
@@ -35,6 +35,7 @@ hugemmap29 hugemmap29
  hugemmap30 hugemmap30
  hugemmap31 hugemmap31
  hugemmap32 hugemmap32
+hugemmap38 hugemmap38

nit: Why not hugemmap34? (your colleague used hugemmap33 for his patch [1].

We already have:

hugemmap34 : https://lore.kernel.org/ltp/[email protected]/
hugemmap36 : https://lore.kernel.org/ltp/[email protected]/
hugemmap35 : https://lore.kernel.org/all/[email protected]/
hugemmap37 : https://lore.kernel.org/ltp/[email protected]/

Hence hugemmap38!

Quoted 7 lines

runtest/hugetlb hugemmap29 hugemmap29 · line 41

Quoted 3 lines
runtest/hugetlb +0 -0
  hugemmap05_1 hugemmap05 -m
  hugemmap05_2 hugemmap05 -s
  hugemmap05_3 hugemmap05 -s -m

...

Kind regards,
Petr

Thanks & Regards,
Geetika

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp