Skip to contentSkip to conversation

README: Update overlayfs URL

PATCH Superseded Vyacheslav Yurkov 2 participants 4 messages Sep 28, 2023 – Oct 1, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 README: Update overlayfs URL

Overlayfs-tools and overlayfs-progs projects have been merged together.

---
 README | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
README +4 -4
index d9db9675..e558efc9 100644
@@ -19,7 +19,7 @@ Ubuntu or Debian
         xfslibs-dev
 
    For OverlayFS install:
-    - see https://github.com/hisilicon/overlayfs-progs
+    - see https://github.com/kmxz/overlayfs-tools
 
 Fedora
 ------
@@ -37,7 +37,7 @@ Fedora
         xfsprogs-devel
 
    For OverlayFS build and install:
-    - see https://github.com/hisilicon/overlayfs-progs
+    - see https://github.com/kmxz/overlayfs-tools
 
 RHEL or CentOS
 --------------
@@ -75,7 +75,7 @@ RHEL or CentOS
      - see https://github.com/markfasheh/ocfs2-tools
 
     For OverlayFS build and install:
-     - see https://github.com/hisilicon/overlayfs-progs
+     - see https://github.com/kmxz/overlayfs-tools
 
 SUSE Linux Enterprise or openSUSE
 ---------------------------------
@@ -95,7 +95,7 @@ SUSE Linux Enterprise or openSUSE
      $ sudo zypper install xfsdump xfsprogs-devel
 
     For OverlayFS build and install:
-     - see https://github.com/hisilicon/overlayfs-progs
+     - see https://github.com/kmxz/overlayfs-tools
 
 Build and install test, libs and utils
 --------------------------------------
Signature · 1 line
2.35.1
#1 lore raw
Quoted 3 lines · Vyacheslav Yurkov

Overlayfs-tools and overlayfs-progs projects have been merged together.

Nice :)

Do you also have any plans to improve the tools?

README Ubuntu or Debian · line 21

Quoted 13 lines
---
 README | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
README +0 -0
index d9db9675..e558efc9 100644
@@ -19,7 +19,7 @@ Ubuntu or Debian
         xfslibs-dev
 
    For OverlayFS install:

While you are fixing the README:

1. Above should read 'build and install' like the rest of the sections
2. Please refrain from the use of letter case OverlayFS - it is inconsistent with the rest of fstests
3. This reads as if installing overlayfs-tools is a prerequisite for testing overlayfs, which is not true. In fact, in most likelihood, there are very few people that run fstests with fsck.overlay, so it would be more accurate to say:

For fsck.overlay [optional], build and install:

4. Because fsck.overlay is not mandatory and because it is not distro specific, I think this instruction should be moved to README.overlay.
Note that the instructions to install unionmount testsuite are in README.overlay and while they are also not mandatory fo testing overlayfs, they likely add much more test coverage then fsck.overlay does, so no reason to promote installing fsck.overlay more than installing unionmount

Thanks,
Amir.

Quoted 35 lines
README +4 -5
-    - see https://github.com/hisilicon/overlayfs-progs
+    - see https://github.com/kmxz/overlayfs-tools
 
 Fedora
 ------
@@ -37,7 +37,7 @@ Fedora
         xfsprogs-devel
 
    For OverlayFS build and install:
-    - see https://github.com/hisilicon/overlayfs-progs
+    - see https://github.com/kmxz/overlayfs-tools
 
 RHEL or CentOS
 --------------
@@ -75,7 +75,7 @@ RHEL or CentOS
      - see https://github.com/markfasheh/ocfs2-tools
 
     For OverlayFS build and install:
-     - see https://github.com/hisilicon/overlayfs-progs
+     - see https://github.com/kmxz/overlayfs-tools
 
 SUSE Linux Enterprise or openSUSE
 ---------------------------------
@@ -95,7 +95,7 @@ SUSE Linux Enterprise or openSUSE
      $ sudo zypper install xfsdump xfsprogs-devel
 
     For OverlayFS build and install:
-     - see https://github.com/hisilicon/overlayfs-progs
+     - see https://github.com/kmxz/overlayfs-tools
 
 Build and install test, libs and utils
 --------------------------------------
--

2.35.1

#2 lore raw
Quoted 6 lines · Amir Goldstein
Quoted 2 lines · Vyacheslav Yurkov

Overlayfs-tools and overlayfs-progs projects have been merged together.

Nice :)

Do you also have any plans to improve the tools?

Thanks for the review!
I'll move the instructions completely to README.overlay in V2 then. Is there a particular reason that the file starts from an empty line? (perhaps I could remove that as well in the same patch)

Right now the plan was only to maintain both projects and accept patches from others. Perhaps I will also update the build system to something up-to-date. As for further development, unfortunately I don't have a project behind ATM to improve the tools further. If something pops up (or you have something), I could try to find a capacity for that.

Thanks,
Vyacheslav

#3 lore raw
Quoted 5 lines · Vyacheslav Yurkov
Quoted 3 lines · Amir Goldstein
Quoted 2 lines · Vyacheslav Yurkov

Overlayfs-tools and overlayfs-progs projects have been merged together.

Quoted 7 lines
Quoted 3 lines

Nice :)

Do you also have any plans to improve the tools?

Thanks for the review!
I'll move the instructions completely to README.overlay in V2 then. Is there a particular reason that the file starts from an empty line?

No reason.

Quoted 2 lines

(perhaps I could remove that as well in the same patch)

OK.

Quoted 5 lines

Right now the plan was only to maintain both projects and accept patches from others. Perhaps I will also update the build system to something up-to-date. As for further development, unfortunately I don't have a project behind ATM to improve the tools further. If something pops up (or you have something), I could try to find a capacity for that.

Gao was asking about an offline merge tool, so I pointed him at overlayfs-tools:

https://lore.kernel.org/linux-unionfs/[email protected]/

Maybe he can explain what features in specific he was looking for.

Thanks,
Amir.