Skip to contentSkip to conversation

adapter: Add Version and Manufacturer props to org.bluez.Adapter1.

PATCH Applied [email protected] 3 participants 4 messages Sep 29, 2023 – Oct 4, 2023 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 adapter: Add Version and Manufacturer props to org.bluez.Adapter1.

From: Vibhav Pant <[email protected]>

This allows DBus clients to find an adapter's version and manufacturer company code without querying the management API.

---
 src/adapter.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
src/adapter.c +28 -0
index 8a7c53a9e..8c267d418 100644
@@ -260,6 +260,7 @@ struct btd_adapter {
 
 	bdaddr_t bdaddr;		/* controller Bluetooth address */
 	uint8_t bdaddr_type;		/* address type */
+	uint8_t version;                /* controller core spec version */
 	uint32_t dev_class;		/* controller class of device */
 	char *name;			/* controller device name */
 	char *short_name;		/* controller short name */
@@ -3540,6 +3541,29 @@ static gboolean property_experimental_exists(const GDBusPropertyTable *property,
 	return !queue_isempty(adapter->exps);
 }
 
+static gboolean property_get_manufacturer(const GDBusPropertyTable *property,
+					  DBusMessageIter *iter,
+					  void *user_data)
+{
+	struct btd_adapter *adapter = user_data;
+	dbus_uint16_t val = adapter->manufacturer;
+
+	dbus_message_iter_append_basic(iter, DBUS_TYPE_UINT16, &val);
+
+	return TRUE;
+}
+
+static gboolean property_get_version(const GDBusPropertyTable *property,
+				     DBusMessageIter *iter, void *user_data)
+{
+	struct btd_adapter *adapter = user_data;
+	uint8_t val = adapter->version;
+
+	dbus_message_iter_append_basic(iter, DBUS_TYPE_BYTE, &val);
+
+	return TRUE;
+}
+
 static DBusMessage *remove_device(DBusConnection *conn,
 					DBusMessage *msg, void *user_data)
 {
@@ -3898,6 +3922,8 @@ static const GDBusPropertyTable adapter_properties[] = {
 	{ "Roles", "as", property_get_roles },
 	{ "ExperimentalFeatures", "as", property_get_experimental, NULL,
 					property_experimental_exists },
+	{ "Manufacturer", "q", property_get_manufacturer },
+	{ "Version", "y", property_get_version },
 	{ }
 };
 
@@ -10164,6 +10190,8 @@ static void read_info_complete(uint8_t status, uint16_t length,
 	adapter->supported_settings = btohl(rp->supported_settings);
 	adapter->current_settings = btohl(rp->current_settings);
 
+	adapter->version = rp->version;
+
 	clear_uuids(adapter);
 	clear_devices(adapter);
 
Signature · 1 line
2.42.0
#1 lore raw

PATCH v2 2/2 adapter-api: Add docs for properties Manufacturer and Version.

From: Vibhav Pant <[email protected]>

---
 doc/adapter-api.txt | 11 +++++++++++
 1 file changed, 11 insertions(+)
doc/adapter-api.txt +11 -0
index d38ce7171..10c290c62 100644
@@ -360,3 +360,14 @@ Properties	string Address [readonly]
 
 			List of 128-bit UUIDs that represents the experimental
 			features currently enabled.
+
+		uint16 Manufacturer [readonly]
+
+			The manufacturer of the device, as a uint16 company
+			identifier defined by the Core Bluetooth Specification.
+
+		byte Version [readonly]
+
+			The Bluetooth version supported by the device, as a
+			core version code defined by the Core Bluetooth
+			Specification.
Signature · 1 line
2.42.0
#2 lore raw
In reply to [email protected]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=788805

---Test result---

Test Summary:

CheckPatch                    PASS      1.09 seconds
GitLint                       FAIL      1.72 seconds
BuildEll                      PASS      28.83 seconds
BluezMake                     PASS      1024.19 seconds
MakeCheck                     PASS      13.04 seconds
MakeDistcheck                 PASS      165.71 seconds
CheckValgrind                 PASS      265.79 seconds
CheckSmatch                   PASS      356.05 seconds
bluezmakeextell               PASS      109.50 seconds
IncrementalBuild              PASS      1741.06 seconds
ScanBuild                     PASS      1098.65 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2,1/2] adapter: Add Version and Manufacturer props to org.bluez.Adapter1.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (81>80): "[BlueZ,v2,1/2] adapter: Add Version and Manufacturer props to org.bluez.Adapter1."
1: T3 Title has trailing punctuation (.): "[BlueZ,v2,1/2] adapter: Add Version and Manufacturer props to org.bluez.Adapter1."
[BlueZ,v2,2/2] adapter-api: Add docs for properties Manufacturer and Version.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "[BlueZ,v2,2/2] adapter-api: Add docs for properties Manufacturer and Version."

---
Regards,
Linux Bluetooth

#3 lore raw
In reply to [email protected]
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 7 lines · On Fri, 29 Sep 2023 18:37:24 +0530 you wrote:

From: Vibhav Pant <[email protected]>

This allows DBus clients to find an adapter's version and manufacturer company code without querying the management API.

---
 src/adapter.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Here is the summary with links:
- [BlueZ,v2,1/2] adapter: Add Version and Manufacturer props to org.bluez.Adapter1.

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f2677c0153fd
  - [BlueZ,v2,2/2] adapter-api: Add docs for properties Manufacturer and Version.
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6393012d4680

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html