Skip to contentSkip to conversation

arm64: dts: ls1012a: Remove big-endian from thermal

PATCH Applied Fabio Estevam 3 participants 5 messages Sep 29, 2023 – Dec 13, 2023

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 arm64: dts: ls1012a: Remove big-endian from thermal

From: Fabio Estevam <[email protected]>

Per qoriq-thermal.yaml, 'big-endian' is not a valid property.

When the 'little-endian' property is absent, the default is big endian.

Remove it to fix the following schema warning:

tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#

---
 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi +0 -1
index a863022529ac..d0733451d3ce 100644
@@ -346,7 +346,6 @@ tmu: tmu@1f00000 {
 					       0x00030004 0x00000047
 					       0x00030005 0x00000053
 					       0x00030006 0x00000060>;
-			big-endian;
 			#thermal-sensor-cells = <1>;
 		};
 
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per qoriq-thermal.yaml, 'big-endian' is not a valid property.

Quoted 8 lines

When the 'little-endian' property is absent, the default is big endian.

Remove it to fix the following schema warning:

tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#

Leo,

Can you confirm this is fine?

Shawn

Quoted 19 lines
---
 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi +0 -1
index a863022529ac..d0733451d3ce 100644
@@ -346,7 +346,6 @@ tmu: tmu@1f00000 {
 					       0x00030004 0x00000047
 					       0x00030005 0x00000053
 					       0x00030006 0x00000060>;
-			big-endian;
 			#thermal-sensor-cells = <1>;
 		};
 
Signature · 1 line
2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author reviewer
#2 lore raw

Hi Leo,

Quoted 10 lines · Shawn Guo
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per qoriq-thermal.yaml, 'big-endian' is not a valid property.

When the 'little-endian' property is absent, the default is big endian.

Remove it to fix the following schema warning:

Quoted 8 lines
Quoted 4 lines

tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#

Leo,

Can you confirm this is fine?

Do you agree with this change?

Quoted 19 lines

Shawn

Quoted 16 lines
---
 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi +0 -1
index a863022529ac..d0733451d3ce 100644
@@ -346,7 +346,6 @@ tmu: tmu@1f00000 {
                                             0x00030004 0x00000047
                                             0x00030005 0x00000053
                                             0x00030006 0x00000060>;
-                     big-endian;
                      #thermal-sensor-cells = <1>;
              };
 
Quoted 3 lines
Quoted 3 lines

--
2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Acked-by
#3 lore raw
Quoted 35 lines

-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: Tuesday, December 5, 2023 4:00 PM
To: Shawn Guo <[email protected]>; Leo Li <[email protected]>
Cc: [email protected]; Fabio Estevam <[email protected]>
Subject: Re: [PATCH] arm64: dts: ls1012a: Remove big-endian from thermal

Hi Leo,

Quoted 11 lines · Shawn Guo
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per qoriq-thermal.yaml, 'big-endian' is not a valid property.

When the 'little-endian' property is absent, the default is big endian.

Remove it to fix the following schema warning:

tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-

9]+'

Quoted 1 line
Quoted 1 line

from schema $id:

https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevice
tree.org%2Fschemas%2Fthermal%2Fqoriq- thermal.yaml%23&data=05%7C01%7Cleoyang.li%40nxp.com%7Caefb2100b7 a34977023908dbf5dd81a5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 %7C638374103934974217%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C %7C&sdata=yUSalG9%2B0INDoSpIIu1aCsIM9Jt%2BuiPnNIWHY0uuzik%3D&re served=0

Quoted 1 line
Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Leo,

Can you confirm this is fine?

Do you agree with this change?

You are right. Thanks for the fix.

Quoted 21 lines
Quoted 9 lines

Shawn

Review

Quoted 5 lines
---
 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
 1 file changed, 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi

Quoted 11 lines
Quoted 11 lines

index a863022529ac..d0733451d3ce 100644

arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi +0 -1
@@ -346,7 +346,6 @@ tmu: tmu@1f00000 {
                                             0x00030004 0x00000047
                                             0x00030005 0x00000053
                                             0x00030006 0x00000060>;
-                     big-endian;
                      #thermal-sensor-cells = <1>;
              };
 
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

--
2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Applied
#4 lore raw
In reply to Fabio Estevam
Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per qoriq-thermal.yaml, 'big-endian' is not a valid property.

Quoted 8 lines

When the 'little-endian' property is absent, the default is big endian.

Remove it to fix the following schema warning:

tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml#

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel