smartpqi man page updates
v4 cover smartpqi man page updates
These patches are based the man page content found ingit://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
The Linux man page smartpqi.4 is out-of-date with the man page provided by our out-of-box driver. This patch series brings the Linux man page up to date.
The changes are:
smarpqi-update-copyright-and-email-addresses
The copyright, email, and URLs have changed to Microchip.
smartpqi-update-module-parameter-descriptions
We changed some descriptions of some of our module parameters. Clarifies what their default values are.
smartpqi-add-module-parameter_disable_managed_interrupts
We added a new module parameter to allow users to disable how interrupts are managed allowing them to change affinity.
smartpqi-add-module-parameter_ctrl_ready_timeout
We added a new module parameter to allow users to change how
long the driver waits for the controller becomes ready. The
default is 180 seconds and can be changed from 30-1800 seconds.
The longer wait times are useful for large configurations.
smartpqi-update_FILES_section
Minor change to the FILES section. The word "Logical" was changed to "Disk" since HBA disks are also supported.
smartpqi-update-host-attribute-descriptions
Updated the descriptions of existing host attributes accessed through sysfs.
smartpqi-update-device-attribute-descriptions
Updated the descriptions of existing device attributes accessed through sysfs.
smartpqi-add-host-attributes
We added some new host attributes:
enable_stream_detection: For RAID5/6 sequential write operations, this
can help increase IOPS. Reduces Read/Modify/Write operations. This is for AIO capable devices. (Volumes consisting of non-rotating media).
enable_r5_writes: Send down RAID 5 write operations down the AIO path.
enable_r6_writes: Send down RAID 6 write operations down the AIO path.
smartpqi-add-device-attributes
We added some new device attributes:
lunid - SCSI LUN ID
unique_id - 16-byte ID that uniquely identifies the device within the controller. path_info - Host:Bus:Target:Lun (h:b:t:l), device type, Active/Inactive raid_bypass_cnt - Count of the number of request sent down the AIO path. sas_ncq_prio_enable - Enables SATA NCQ priority support.
smartpqi-add-sg-entry-to-see_also
Simple addition of the sg(4) driver to the SEE ALSO section.
Changes since V3:
Updated content for the following pages due to reviews by:
Alejandro Colomar <[email protected]>
smartpqi: add module parameter ctrl_ready_timeout
smartpqi: update FILES section
smartpqi: update host attribute descriptions
smartpqi: add host attributes
smartpqi: add device attributes
The other patches have already been applied and were removed from the remaining patch set after a rebase.
Thanks for your attention and reviews for these patches.
Changes since V2:
Resending due to bad e-mail address for maintainer.
Changes since V1:
Broke up the large patch into multiple smaller patches due to review by:
Alejandro Colomar <[email protected]>
---
Don Brace (5):
smartpqi: add module parameter ctrl_ready_timeout
smartpqi: update FILES section
smartpqi: update host attribute descriptions
smartpqi: add host attributes
smartpqi: add device attributes
man4/smartpqi.4 | 182 ++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 162 insertions(+), 20 deletions(-)
Signature · 1 line
2.42.0.296.g493f462273
PATCH v4 1/5 smartpqi: add module parameter ctrl_ready_timeout
Allow user to change the length of time that the driver will wait for the controller to become ready.
--- man4/smartpqi.4 | 6 ++++++ 1 file changed, 6 insertions(+)
man4/smartpqi.4 +6 -0
@@ -17,6 +17,7 @@ smartpqi \- Microchip Smart Storage SCSI driver .RB [ expose_ld_first= { 0 | 1 }] .RB [ hide_vsep= { 0 | 1 }] .RB [ disable_managed_interrupts= { 0 | 1 }] +.RB [ ctrl_ready_timeout= { 0 | 30-1800 }] .YS .SH DESCRIPTION .B smartpqi
@@ -107,6 +108,11 @@ Disables driver utilization of Linux kernel managed interrupts for controllers. The managed interrupts feature automatically distributes interrupts to all available CPUs and assigns SMP affinity. The default value is 0 (managed interrupts enabled). +.TP +.BR ctrl_ready_timeout= { 0 | 30-1800 } +This option specifies the timeout in seconds for the driver to wait +for controller ready. The valid range is 0 or 30-1800. The default value +is 0, which causes the driver to use a timeout of 180 seconds. .SH FILES .SS Device nodes Logical drives are accessed via the SCSI disk driver
Signature · 1 line
2.42.0.296.g493f462273
Alejandro Colomar
maintainerRe: [PATCH v4 1/5] smartpqi: add module parameter ctrl_ready_timeout
Hi Don,
Quoted 25 lines · Don Brace
Allow user to change the length of time that the driver will wait for the controller to become ready.
Reviewed-by Scott Benesh <[email protected]>Reviewed-by Scott Teel <[email protected]>Reviewed-by Mike McGowen <[email protected]>Reviewed-by Kevin Barnett <[email protected]>Signed-off-by Don Brace <[email protected]>--- man4/smartpqi.4 | 6 ++++++ 1 file changed, 6 insertions(+)man4/smartpqi.4 +1
-0@@ -17,6 +17,7 @@ smartpqi \- Microchip Smart Storage SCSI driver .RB [ expose_ld_first= { 0 | 1 }] .RB [ hide_vsep= { 0 | 1 }] .RB [ disable_managed_interrupts= { 0 | 1 }] +.RB [ ctrl_ready_timeout= { 0 | 30-1800 }] .YS .SH DESCRIPTION .B smartpqi
man4/smartpqi.4 Disables driver utilization of Linux kernel managed interrupts for controllers. · line 114
Quoted 7 lines
man4/smartpqi.4 +4
-0@@ -107,6 +108,11 @@ Disables driver utilization of Linux kernel managed interrupts for controllers. The managed interrupts feature automatically distributes interrupts to all available CPUs and assigns SMP affinity. The default value is 0 (managed interrupts enabled). +.TP +.BR ctrl_ready_timeout= { 0 | 30-1800 } +This option specifies the timeout in seconds for the driver to wait +for controller ready. The valid range is 0 or 30-1800. The default value
How about "for the controller to be ready"?
Also, please break lines after period (per "semantic newlines" guidelines in man-pages(7)).
$ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p'
Use semantic newlines
In the source of a manual page, new sentences should be started
on new lines, long sentences should be split into lines at
clause breaks (commas, semicolons, colons, and so on), and long
clauses should be split at phrase boundaries. This convention,
sometimes known as "semantic newlines", makes it easier to see
the effect of patches, which often operate at the level of in‐
dividual sentences, clauses, or phrases.Regarding ranges, please say 0 or [30, 1800], to use standard syntax.
Thanks,
Alex
Quoted 7 lines
man4/smartpqi.4 +1
-0+is 0, which causes the driver to use a timeout of 180 seconds. .SH FILES .SS Device nodes Logical drives are accessed via the SCSI disk driverSignature · 1 line
2.42.0.296.g493f462273
PATCH v4 2/5 smartpqi: update FILES section
In reply to Don BraceMinor description changes for Device nodes.
Change "Logical drives" to "Disk drives".
--- man4/smartpqi.4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
man4/smartpqi.4 +1 -1
@@ -115,7 +115,7 @@ for controller ready. The valid range is 0 or 30-1800. The default value is 0, which causes the driver to use a timeout of 180 seconds. .SH FILES .SS Device nodes -Logical drives are accessed via the SCSI disk driver +Disk drives are accessed via the SCSI disk driver .RI ( sd ), tape drives via the SCSI tape driver .RI ( st ),
Signature · 1 line
2.42.0.296.g493f462273
PATCH v4 3/5 smartpqi: update host attribute descriptions
In reply to Don BraceMinor description changes for host attributes.
Just some small changes to the host attribute descriptions. Remove the "version" sysfs entry. This entry was changed to two sysfs entries: driver_version and firmware_version.
--- man4/smartpqi.4 | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-)
man4/smartpqi.4 +2 -19
@@ -135,29 +135,12 @@ The host attribute is a write-only attribute. Writing to this attribute will cause the driver to scan for new, changed, or removed devices (e.g., hot-plugged tape drives, or newly -configured or deleted logical drives) and notify the SCSI mid-layer of +configured or deleted logical volumes) and notify the SCSI mid-layer of any changes detected. Usually this action is triggered automatically by configuration changes, so the user should not normally have to write to this file. Doing so may be useful when hot-plugging devices such as tape drives or -entire storage boxes containing pre-configured logical drives. -.TP -.IR /sys/class/scsi_host/host * /version -The host -.I version -attribute is a read-only attribute. -This attribute contains the driver version and the controller firmware -version. -.IP -For example: -.IP -.in +4n -.EX -$ \c -.B cat /sys/class/scsi_host/host1/version -driver: 1.1.2\-126 -firmware: 1.29\-112 -.EE +entire storage boxes containing pre-configured logical volumes. .in .TP .IR /sys/class/scsi_host/host * /lockup_action
Signature · 1 line
2.42.0.296.g493f462273
Alejandro Colomar
maintainerRe: [PATCH v4 3/5] smartpqi: update host attribute descriptions
Hi Don,
Quoted 5 lines · Don Brace
Minor description changes for host attributes.
Just some small changes to the host attribute descriptions. Remove the "version" sysfs entry. This entry was changed to two sysfs entries:
driver_versionandfirmware_version.
Should we add a HISTORY section and document the old "version" sysfs entry there, saying that it has been replaced by those two entries?
Thanks,
Alex
Quoted 49 lines
Reviewed-by Scott Benesh <[email protected]>Reviewed-by Scott Teel <[email protected]>Reviewed-by Mike McGowen <[email protected]>Reviewed-by Kevin Barnett <[email protected]>Signed-off-by Don Brace <[email protected]>--- man4/smartpqi.4 | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-)man4/smartpqi.4 +2
-19@@ -135,29 +135,12 @@ The host attribute is a write-only attribute. Writing to this attribute will cause the driver to scan for new, changed, or removed devices (e.g., hot-plugged tape drives, or newly -configured or deleted logical drives) and notify the SCSI mid-layer of +configured or deleted logical volumes) and notify the SCSI mid-layer of any changes detected. Usually this action is triggered automatically by configuration changes, so the user should not normally have to write to this file. Doing so may be useful when hot-plugging devices such as tape drives or -entire storage boxes containing pre-configured logical drives. -.TP -.IR /sys/class/scsi_host/host * /version -The host -.I version -attribute is a read-only attribute. -This attribute contains the driver version and the controller firmware -version. -.IP -For example: -.IP -.in +4n -.EX -$ \c -.B cat /sys/class/scsi_host/host1/version -driver: 1.1.2\-126 -firmware: 1.29\-112 -.EE +entire storage boxes containing pre-configured logical volumes. .in .TP .IR /sys/class/scsi_host/host * /lockup_actionSignature · 1 line
2.42.0.296.g493f462273
PATCH v4 4/5 smartpqi: add host attributes
In reply to Don BraceAdd in some host level sysfs entries:enable_stream_detection - Send RAID 5/6 writes down the normal I/O path.
Allow for full-stripe write requests.ssd_smart_path_enabled - Indicates that our Accelerated I/O path is
enabled. (AIO).
enable_r5_writes - Allow RAID 5 write operations down the AIO path.enable_r6_writes - Allow RAID 6 write operations down the AIO path.
--- man4/smartpqi.4 | 59 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+)
man4/smartpqi.4 +59 -0
@@ -235,6 +235,65 @@ $ \c Adaptec .EE .in +.TP +.I /sys/class/scsi_host/host*/enable_stream_detection +The +.I enable_stream_detection +attribute is read-write. +This attribute enables/disables stream detection in the driver. +Enabling stream detection can improve sequential write performance for +ioaccel-enabled volumes. See the +.BI ssd_smart_path_enabled +disk attribute section for details on ioaccel-enabled volumes. +The default value is 1 (stream detection enabled). +.IP +Enable example: +.IP +.in +4n +.EX +$ \c +.B echo 1 > /sys/class/scsi_host/host1/enable_stream_detection +.EE +.in +.TP +.I /sys/class/scsi_host/host*/enable_r5_writes +The +.I enable_r5_writes +attribute is read-write. +This attribute enables/disables RAID 5 write operations for ioaccel-enabled +volumes. Enabling can improve sequential write performance. See the +.BI ssd_smart_path_enabled +disk attribute section for details on ioaccel-enabled volumes. +The default value is 1 (RAID 5 writes enabled). +.IP +Enable example: +.IP +.in +4n +.EX +$ \c +.B echo 1 > /sys/class/scsi_host/host1/enable_r5_writes +.EE +.in +.TP +.I /sys/class/scsi_host/host*/enable_r6_writes +The +.I enable_r6_writes +attribute is read-write. +This attribute enables/disables RAID 6 write operations for +ioaccel-enabled volumes. Enabling can improve sequential write performance. +See the +.BI ssd_smart_path_enabled +disk attribute section for details on ioaccel-enabled volumes. +The default value is 1 (RAID 6 writes enabled). +.IP +Enable example: +.IP +.in +4n +.EX +$ \c +.B echo 1 > /sys/class/scsi_host/host1/enable_r6_writes +.EE +.in .SS SmartPQI-specific disk attribute files in \f[BI]/sys\fP In the file specifications below, .I c
Signature · 1 line
2.42.0.296.g493f462273
PATCH v4 5/5 smartpqi: add device attributes
In reply to Don BraceAdd in some device level sysfs entry descriptions:
lunidunique_idpath_inforaid_bypass_cntsas_ncq_prio_enable
These have already been provided by the driver.
--- man4/smartpqi.4 | 94 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+)
man4/smartpqi.4 +94 -0
@@ -358,6 +358,100 @@ $ \c 0 .EE .in +.TP +.I /sys/class/scsi_disk/c : b : t : l/device/lunid +The +.I lunid +attribute is read-only. +This attribute contains the SCSI LUN ID for the device. +.IP +For example: +.IP +.in +4n +.EX +$ \c +.B cat /sys/class/scsi_disk/13:1:0:3/device/lunid +0x0300004000000000 +.EE +.in +.TP +.I /sys/class/scsi_disk/c : b : t : l/device/unique_id +The +.I unique_id +attribute is read-only. +This attribute contains a 16-byte ID that uniquely identifies the device +within the controller. +.IP +For example: +.IP +.in +4n +.EX +$ \c +.B cat /sys/class/scsi_disk/13:1:0:3/device/unique_id +600508B1001C6D4723A8E98D704FDB94 +.EE +.in +.TP +.I /sys/class/scsi_disk/c : b : t : l/device/path_info +The +.I path_info +attribute is read-only. +This attribute contains the c:b:t:l of the device along with the device +type and whether the device is Active or Inactive. If the device is an HBA +device, +.I path_info +will also display the PORT, BOX, and BAY the device is plugged into. +.IP +For example: +.IP +.in +4n +.EX +$ \c +.B cat /sys/class/scsi_disk/13:1:0:3/device/path_info +[13:1:0:3] Direct-Access Active + +$ \c +.B cat /sys/class/scsi_disk/12:0:9:0/device/path_info +[12:0:9:0] Direct-Access PORT: C1 BOX: 1 BAY: 14 Inactive +[12:0:9:0] Direct-Access PORT: C0 BOX: 1 BAY: 14 Active +.EE +.in +.TP +.I /sys/class/scsi_disk/13:1:0:3/device/raid_bypass_cnt +The +.I raid_bypass_cnt +attribute is read-only. +This attribute contains the number of I/O requests that have gone +through the ioaccel path for ioaccel-enabled volumes. See the +.BI ssd_smart_path_enabled +disk attribute section for details on ioaccel-enabled volumes. +.IP +For example: +.IP +.in +4n +.EX +$ \c +.B cat /sys/class/scsi_disk/13:1:0:3/device/raid_bypass_cnt +0x300 +.EE +.in +.TP +.I /sys/class/scsi_disk/13:1:0:3/device/sas_ncq_prio_enable +The +.I sas_ncq_prio_enable +attribute is read/write. +This attribute enables SATA NCQ priority support. +This attribute works only when device has NCQ support and +controller firmware can handle IO with NCQ priority attribute. +.IP +For example: +.IP +.in +4n +.EX +$ \c +.B echo 1 > /sys/class/scsi_disk/13:1:0:3/device/sas_ncq_prio_enable +.EE +.in .SH VERSIONS The .B smartpqi
Signature · 1 line
2.42.0.296.g493f462273