media: nuvoton: npcm-video: Fix sleeping in atomic context
Subsystems (2)
PATCH 1/1 media: nuvoton: npcm-video: Fix sleeping in atomic context
Fix sleeping in atomic context warnings reported by the Smatch static analysis tool. Use GFP_ATOMIC instead of GFP_KERNEL in atomic context.
--- drivers/media/platform/nuvoton/npcm-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/nuvoton/npcm-video.c +2 -2
@@ -412,7 +412,7 @@ static unsigned int npcm_video_add_rect(struct npcm_video *video,struct rect_list *list =NULL ;struct v4l2_rect *r; - list =kzalloc (sizeof (*list),GFP_KERNEL ); + list =kzalloc (sizeof (*list),GFP_ATOMIC );if (!list)return 0 ;
@@ -467,7 +467,7 @@ static struct rect_list *npcm_video_new_rect(struct npcm_video *video,struct rect_list *list =NULL ;struct v4l2_rect *r; - list =kzalloc (sizeof (*list),GFP_KERNEL ); + list =kzalloc (sizeof (*list),GFP_ATOMIC );if (!list)return NULL ;
Signature · 1 line
2.34.1
Quoted 24 lines · Marvin Lin
Fix sleeping in atomic context warnings reported by the Smatch static analysis tool. Use
GFP_ATOMICinstead ofGFP_KERNELin atomic context.Fixes 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine")Reported-by Dan Carpenter <[email protected]>Signed-off-by Marvin Lin <[email protected]>--- drivers/media/platform/nuvoton/npcm-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/nuvoton/npcm-video.c +1
-1@@ -412,7 +412,7 @@ static unsigned int npcm_video_add_rect(struct npcm_video *video,struct rect_list *list =NULL ;struct v4l2_rect *r; - list =kzalloc (sizeof (*list),GFP_KERNEL ); + list =kzalloc (sizeof (*list),GFP_ATOMIC );if (!list)return 0 ;
drivers/media/platform/nuvoton/npcm-video.c static struct rect_list *npcm_video_new_rect(struct npcm_video *video, · line 473
Quoted 8 lines
drivers/media/platform/nuvoton/npcm-video.c +1
-1@@ -467,7 +467,7 @@ static struct rect_list *npcm_video_new_rect(struct npcm_video *video,struct rect_list *list =NULL ;struct v4l2_rect *r; - list =kzalloc (sizeof (*list),GFP_KERNEL ); + list =kzalloc (sizeof (*list),GFP_ATOMIC );if (!list)return NULL ;
I'm not really sure this is the right approach.
Looking closer at the code I notice that npcm_video_irq is a threaded interrupt handler, so wouldn't it be easier to change the video->lock spinlock to a mutex?
Regards,
Hans
Hi Hans,
Thanks for the review.
Quoted 6 lines
drivers/media/platform/nuvoton/npcm-video.c static struct rect_list *npcm_video_new_rect(struct npcm_video *video, · line 472
Quoted 5 lines
drivers/media/platform/nuvoton/npcm-video.c +1
-1- list =kzalloc (sizeof (*list),GFP_KERNEL ); + list =kzalloc (sizeof (*list),GFP_ATOMIC );if (!list)return NULL ;
Quoted 6 lines
I'm not really sure this is the right approach.
Looking closer at the code I notice that
npcm_video_irqis a threaded interrupt handler, so wouldn't it be easier to change thevideo->lockspinlock to a mutex?
Agree it's better to use mutex. Will send v2 for this.
Regards,
Marvin