Skip to contentSkip to conversation

ARM: dts: omap4-embt2ws: Add Bluetooth

PATCH In review Andreas Kemnade 3 participants 12 messages Oct 4, 2023 – Dec 1, 2023

Subsystems (2)
Device tree bindings OMAP device tree support
lore
Share & tools
lore

Andreas Kemnade

author maintainer
#0 lore raw

PATCH v2 1/1 ARM: dts: omap4-embt2ws: Add Bluetooth

Since the required clock is now available, add bluetooth.

Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation.

Signed-off-by Andreas Kemnade <[email protected]>

---
Depends on: https://lore.kernel.org/linux-omap/[email protected]/T/#u

Changes in V2:
- more standard node name, removing unneeded label

 arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +6 -4
index 46a80eacf771..6a790124bcf5 100644
@@ -447,10 +447,12 @@ &uart2 {
 	interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
 			       &omap4_pmx_core OMAP4_UART2_RX>;
 
-	/*
-	 * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
-	 * which does not have a driver
-	 */
+	bluetooth-gnss {
+		compatible = "ti,wl1283-st";
+		enable-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;	/* GPIO_25 */
+		clocks = <&twl 1>;
+		clock-names = "ext_clock";
+	};
 };
 
 &uart3 {
Signature · 1 line
2.39.2
#1 lore raw
Quoted 22 lines · Andreas Kemnade

Since the required clock is now available, add bluetooth.

Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation.

Signed-off-by Andreas Kemnade <[email protected]>

---
Depends on: https://lore.kernel.org/linux-omap/[email protected]/T/#u

Changes in V2:
- more standard node name, removing unneeded label

 arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +0 -0
index 46a80eacf771..6a790124bcf5 100644

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts &uart2 { · line 450

Quoted 8 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +1 -4
@@ -447,10 +447,12 @@ &uart2 {
 	interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
 			       &omap4_pmx_core OMAP4_UART2_RX>;
 
-	/*
-	 * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
-	 * which does not have a driver
-	 */
+	bluetooth-gnss {

If you changed the bindings, please share a link. If not, this is not currently accepted and dtbs_check should point it out.

Best regards,
Krzysztof

author maintainer
#2 lore raw

[...]

Quoted 9 lines

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts &uart2 { · line 450

Quoted 5 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +1 -4
-	/*
-	 * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
-	 * which does not have a driver
-	 */
+	bluetooth-gnss {

If you changed the bindings, please share a link. If not, this is not currently accepted and dtbs_check should point it out.

$ make dtbs_check &>dtbs.log
$ grep -q omap4-epson-embt2ws.dtb dtbs.log  && echo yes
yes
$ grep bluetooth-gnss dtbs.log
$

So no complaints...

Regards,
Andreas

author maintainer
#3 lore raw
In reply to Krzysztof Kozlowski

Hi,

On Wed, 4 Oct 2023 09:59:59 +0200
Krzysztof Kozlowski <[email protected]> wrote:

[...]

Quoted 8 lines
Quoted 8 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +0 -0
index 46a80eacf771..6a790124bcf5 100644
@@ -447,10 +447,12 @@ &uart2 {
 	interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
 			       &omap4_pmx_core OMAP4_UART2_RX>;
Quoted 9 lines

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts &uart2 { · line 450

Quoted 5 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +1 -4
-	/*
-	 * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
-	 * which does not have a driver
-	 */
+	bluetooth-gnss {

If you changed the bindings, please share a link. If not, this is not currently accepted and dtbs_check should point it out.

according to dtbs_check:

good:
- bluetooth-gnss
- bluettooth-gnss

bad:
- bluettooth-gnnss
- tiwi (still there in pandaboards)

Regards,
Andreas

author maintainer
#4 lore raw
Quoted 26 lines · On Wed, 4 Oct 2023 16:53:14 +0200 Andreas Kemnade <[email protected]> wrote:

Hi,

On Wed, 4 Oct 2023 09:59:59 +0200
Krzysztof Kozlowski <[email protected]> wrote:

[...]

Quoted 8 lines
Quoted 8 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +0 -0
index 46a80eacf771..6a790124bcf5 100644
@@ -447,10 +447,12 @@ &uart2 {
 	interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
 			       &omap4_pmx_core OMAP4_UART2_RX>;
Quoted 9 lines

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts &uart2 { · line 450

Quoted 5 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +1 -4
-	/*
-	 * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
-	 * which does not have a driver
-	 */
+	bluetooth-gnss {

If you changed the bindings, please share a link. If not, this is not currently accepted and dtbs_check should point it out.

according to dtbs_check:

Quoted 8 lines

good:
- bluetooth-gnss
- bluettooth-gnss

bad:
- bluettooth-gnnss
- tiwi (still there in pandaboards)

The only authoritative source I find here:
Documentation/devicetree/bindings/serial/serial.yaml:
patternProperties:
"^bluetooth|gnss|gps|mcu$":

It allows:
everything starting with bluetooth
everything containing gnss
everything containing gps
everything ending with mcu

bluetooth-gnss starts with bluetooth, so it is allowed. Do you have anything else forbidding bluetooth-gnss?

Regards,
Andreas

Quoted 4 lines

Regards,
Andreas

#5 lore raw
Quoted 33 lines · Andreas Kemnade
Quoted 30 lines · On Wed, 4 Oct 2023 16:53:14 +0200 Andreas Kemnade <[email protected]> wrote:

Hi,

On Wed, 4 Oct 2023 09:59:59 +0200
Krzysztof Kozlowski <[email protected]> wrote:

[...]

Quoted 8 lines
Quoted 8 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +0 -0
index 46a80eacf771..6a790124bcf5 100644
@@ -447,10 +447,12 @@ &uart2 {
 	interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
 			       &omap4_pmx_core OMAP4_UART2_RX>;
Quoted 9 lines

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts &uart2 { · line 450

Quoted 5 lines
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +1 -4
-	/*
-	 * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
-	 * which does not have a driver
-	 */
+	bluetooth-gnss {

If you changed the bindings, please share a link. If not, this is not currently accepted and dtbs_check should point it out.

according to dtbs_check:

good:
- bluetooth-gnss
- bluettooth-gnss

Quoted 8 lines
Quoted 4 lines

bad:
- bluettooth-gnnss
- tiwi (still there in pandaboards)

The only authoritative source I find here:
Documentation/devicetree/bindings/serial/serial.yaml:
patternProperties:
"^bluetooth|gnss|gps|mcu$":

Yes, it's about this one.

Quoted 9 lines

It allows:
everything starting with bluetooth
everything containing gnss
everything containing gps
everything ending with mcu

bluetooth-gnss starts with bluetooth, so it is allowed. Do you have anything else forbidding bluetooth-gnss?

Heh, the pattern is wrong. This should be originally:
"^(bluetooth|gnss|gps|mcu)$":

I can fix it and also allow your use case.

Best regards,
Krzysztof

Reviewed-by on v2 1/1
#6 lore raw
In reply to Andreas Kemnade
Quoted 9 lines · Andreas Kemnade

Since the required clock is now available, add bluetooth.

Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation.

Signed-off-by Andreas Kemnade <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

maintainer
#7 lore raw
Quoted 8 lines · Krzysztof Kozlowski
Quoted 7 lines · Andreas Kemnade

Since the required clock is now available, add bluetooth.

Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation.

Quoted 5 lines
Quoted 2 lines
Signed-off-by Andreas Kemnade <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Applying into omap-for-v6.7/dt thanks.

Tony

maintainer
#8 lore raw
Quoted 9 lines · Tony Lindgren
Quoted 8 lines · Krzysztof Kozlowski
Quoted 7 lines · Andreas Kemnade

Since the required clock is now available, add bluetooth.

Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Andreas Kemnade <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Applying into omap-for-v6.7/dt thanks.

Looks like this causes the following #clock-cells warning so dropping this patch.

Regards,

Tony

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts:457.17-462.4: Warning (clocks_property):
/ocp/interconnect@48000000/segment@0/target-module@6c000/serial@0/bluetooth-gnss:
Missing property '#clock-cells' in node /ocp/interconnect@48000000/segment@0/targe

author maintainer
#9 lore raw

Hi Tony,

Quoted 21 lines · On Sat, 7 Oct 2023 10:24:42 +0300 Tony Lindgren <[email protected]> wrote:
Quoted 9 lines · Tony Lindgren
Quoted 8 lines · Krzysztof Kozlowski
Quoted 7 lines · Andreas Kemnade

Since the required clock is now available, add bluetooth.

Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Andreas Kemnade <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Applying into omap-for-v6.7/dt thanks.

Looks like this causes the following #clock-cells warning so dropping this patch.

Quoted 9 lines

Regards,

Tony

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts:457462.4: Warning (clocks_property):
/ocp/interconnect@48000000/segment@0/target-module@6c000/serial@0/bluetooth-gnss:
Missing property '#clock-cells' in node /ocp/interconnect@48000000/segment@0/targe

well, it depends on the wlan dts patch. I think we are better of with having both applied now. It is a better description of the hardware, and that is what the devicetree is about. Having wlan randomly working without undocumented description is IMHO worse than with a clear description.
The reason why this did not come to light earlier is because I had tested it on top of a bunch of regression fixes for the twl (which were accepted at that point) and I did miss the fact that I had also a had a local hack amoung them to enable the clock by a simple register write in _probe it twl-core.c.

I think as Stephen has little comments about the last version and just not collected anything else than fixes for -rc, I would think it simply will be applied. I think he just has a late start.

Regards,
Andreas

author maintainer
#10 lore raw
In reply to Tony Lindgren

Hi Tony,

Quoted 21 lines · On Sat, 7 Oct 2023 10:24:42 +0300 Tony Lindgren <[email protected]> wrote:
Quoted 9 lines · Tony Lindgren
Quoted 8 lines · Krzysztof Kozlowski
Quoted 7 lines · Andreas Kemnade

Since the required clock is now available, add bluetooth.

Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Andreas Kemnade <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Applying into omap-for-v6.7/dt thanks.

Looks like this causes the following #clock-cells warning so dropping this patch.

Quoted 8 lines

Regards,

Tony

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts:457.17-462.4: Warning (clocks_property):
/ocp/interconnect@48000000/segment@0/target-module@6c000/serial@0/bluetooth-gnss:
Missing property '#clock-cells' in node /ocp/interconnect@48000000/segment@0/targe

I do not get this warning on top of omap-for-v6.8/dt. So I think the time is really there for this patch.

Regards,
Andreas

maintainer
#11 lore raw
Quoted 9 lines · Andreas Kemnade
Quoted 4 lines · On Sat, 7 Oct 2023 10:24:42 +0300 Tony Lindgren <[email protected]> wrote:

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts:457.17-462.4: Warning (clocks_property):
/ocp/interconnect@48000000/segment@0/target-module@6c000/serial@0/bluetooth-gnss:
Missing property '#clock-cells' in node /ocp/interconnect@48000000/segment@0/targe

I do not get this warning on top of omap-for-v6.8/dt. So I think the time is really there for this patch.

OK thanks applying into omap-for-v6.8/dt.

Tony