Skip to contentSkip to conversation

dt-bindings: watchdog: fsl,scu-wdt: Document imx8dl

PATCH In review Fabio Estevam 3 participants 6 messages Oct 4, 2023 – Oct 25, 2023

Subsystems (2)
Device tree bindings Watchdog device drivers
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v2 1/1 dt-bindings: watchdog: fsl,scu-wdt: Document imx8dl

From: Fabio Estevam <[email protected]>

imx8dxl also contains the SCU watchdog block.

Add an entry for 'fsl,imx8dxl-sc-wdt'.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>

---
Changes since v1:
- Sent it as a standalone patch to the DT folks.
- Collected Conor's ack.

 Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml +3 -1
index 47701248cd8d..8b7aa922249b 100644
@@ -18,7 +18,9 @@ allOf:
 properties:
   compatible:
     items:
-      - const: fsl,imx8qxp-sc-wdt
+      - enum:
+          - fsl,imx8dxl-sc-wdt
+          - fsl,imx8qxp-sc-wdt
       - const: fsl,imx-sc-wdt
 
 required:
Signature · 1 line
2.34.1
author
#1 lore raw

Hi Rob,

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

imx8dxl also contains the SCU watchdog block.

Add an entry for 'fsl,imx8dxl-sc-wdt'.

Quoted 8 lines
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>

---
Changes since v1:
- Sent it as a standalone patch to the DT folks.
- Collected Conor's ack.

Can this go through your tree?

maintainer
#2 lore raw
Quoted 19 lines · Fabio Estevam

Hi Rob,

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

imx8dxl also contains the SCU watchdog block.

Add an entry for 'fsl,imx8dxl-sc-wdt'.

Quoted 8 lines
Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>

---
Changes since v1:
- Sent it as a standalone patch to the DT folks.
- Collected Conor's ack.

Quoted 1 line

Can this go through your tree?

I'm waiting to see if Guenter picks it up, but will if he doesn't.

Rob

maintainer
#3 lore raw
Quoted 20 lines · Rob Herring
Quoted 19 lines · Fabio Estevam

Hi Rob,

Quoted 15 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

imx8dxl also contains the SCU watchdog block.

Add an entry for 'fsl,imx8dxl-sc-wdt'.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>

---
Changes since v1:
- Sent it as a standalone patch to the DT folks.
- Collected Conor's ack.

Quoted 5 lines
Quoted 1 line

Can this go through your tree?

I'm waiting to see if Guenter picks it up, but will if he doesn't.

Rob

Watchdog patches are picked up by Wim; I only provide Reviewed-by: tags.

Guenter

maintainer Reviewed-by on v2 1/1
#4 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

imx8dxl also contains the SCU watchdog block.

Add an entry for 'fsl,imx8dxl-sc-wdt'.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 23 lines

---
Changes since v1:
- Sent it as a standalone patch to the DT folks.
- Collected Conor's ack.

  Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml +3 -1
index 47701248cd8d..8b7aa922249b 100644
@@ -18,7 +18,9 @@ allOf:
  properties:
    compatible:
      items:
-      - const: fsl,imx8qxp-sc-wdt
+      - enum:
+          - fsl,imx8dxl-sc-wdt
+          - fsl,imx8qxp-sc-wdt
        - const: fsl,imx-sc-wdt
 
  required:
maintainer
#5 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

imx8dxl also contains the SCU watchdog block.

Add an entry for 'fsl,imx8dxl-sc-wdt'.

Cc Wim Van Sebroeck <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>
Quoted 8 lines

---
Changes since v1:
- Sent it as a standalone patch to the DT folks.
- Collected Conor's ack.

 Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

It seems watchdog bindings aren't getting applied, so I've applied it. Wim, please take watchdog bindings in the future unless noted otherwise.

Rob