Add support for XLCDC to sam9x7 SoC family.
Subsystems (5)
Manikandan Muralidharan
maintainerv7 cover Add support for XLCDC to sam9x7 SoC family.
This patch series aims to add support for XLCDC IP of sam9x7 SoC family to the DRM subsystem.XLCDC IP has additional registers and new configuration bits compared to the existing register set of HLCDC IP. The new compatible string "microchip,sam9x75-xlcdc" is defined for sam9x75 variant of the sam9x7 SoC family.The is_xlcdc flag under driver data and IP specific driver ops helps to differentiate the XLCDC and existing HLCDC code within the same driver.
changes in v7:
* LCDC IP driver ops functions are declared static and its declaration are removed.
changes in v6:
* Fixed Cosmetic defects.
* Added comments for readability.
changes in v5:
* return value of regmap_read_poll_timeout is checked in failure case.
* HLCDC and XLCDC specific driver functions are now invoked using its IP specific driver ops w/o the need of checking is_xlcdc flag.
* Removed empty spaces and blank lines.
changes in v4:
* fixed kernel warnings reported by kernel test robot.
changes in v3:
* Removed de-referencing the value of is_xlcdc flag multiple times in a single function.
* Removed cpu_relax() call when using regmap_read_poll_timeout.
* Updated xfactor and yfactor equations using shift operators
* Defined CSC co-efficients in an array for code readability.
changes in v2:
* Change the driver compatible name from "microchip,sam9x7-xlcdc" to "microchip,sam9x75-xlcdc".
* Move is_xlcdc flag to driver data.
* Remove unsed Macro definitions.
* Add co-developed-bys tags
* Replace regmap_read() with regmap_read_poll_timeout() call
* Split code into two helpers for code readablitity.
Durai Manickam KR (1):
drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers
Manikandan Muralidharan (6):
drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and
HLCDC IP
drm: atmel-hlcdc: add LCD controller layer definition for sam9x75
drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver
drm: atmel-hlcdc: add DPI mode support for XLCDC
drm: atmel-hlcdc: add vertical and horizontal scaling support for
XLCDC
drm: atmel-hlcdc: add support for DSI output formats
.../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 175 +++++++-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 105 +++++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 86 ++++ .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 369 +++++++++++++++--- include/linux/mfd/atmel-hlcdc.h | 10 + 5 files changed, 647 insertions(+), 98 deletions(-)
Signature · 1 line
2.25.1
Manikandan Muralidharan
maintainerPATCH v7 1/7 drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and HLCDC IP
Add is_xlcdc flag and LCD IP specific ops in driver data to differentiate XLCDC and HLCDC code within the atmel-hlcdc driver files.
--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 37 ++++++++++++++++++++ 1 file changed, 37 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +37 -0
@@ -177,6 +177,9 @@ struct atmel_hlcdc_layer_cfg_layout {int csc; }; +struct atmel_hlcdc_plane_state ; +struct atmel_hlcdc_dc ; +/** * Atmel HLCDC DMA descriptor structure *
@@ -288,6 +291,36 @@ atmel_hlcdc_layer_to_plane(struct atmel_hlcdc_layer *layer) return container_of(layer, struct atmel_hlcdc_plane, layer); } +/** +* struct atmel_lcdc_dc_ops - describes atmel_lcdc ops group +* to differentiate HLCDC and XLCDC IP code support. +* @plane_setup_scaler: update the vertical and horizontal scaling factors +* @update_lcdc_buffers: update the each LCDC layers DMA registers. +* @lcdc_atomic_disable: disable LCDC interrupts and layers +* @lcdc_update_general_settings: update each LCDC layers general +* confiugration register. +* @lcdc_atomic_update: enable the LCDC layers and interrupts. +* @lcdc_csc_init: update the color space conversion co-efficient of +* High-end overlay register. +* @lcdc_irq_dbg: to raise alert incase of interrupt overrun in any LCDC layer. +*/ +struct atmel_lcdc_dc_ops { +void (*plane_setup_scaler)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_plane_state *state); +void (*update_lcdc_buffers)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_plane_state *state, +u32 sr,int i); +void (*lcdc_atomic_disable)(struct atmel_hlcdc_plane *plane); +void (*lcdc_update_general_settings)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_plane_state *state); +void (*lcdc_atomic_update)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_dc *dc); +void (*lcdc_csc_init)(struct atmel_hlcdc_plane *plane, +const struct atmel_hlcdc_layer_desc *desc); +void (*lcdc_irq_dbg)(struct atmel_hlcdc_plane *plane, +const struct atmel_hlcdc_layer_desc *desc); +}; +/** * Atmel HLCDC Display Controller description structure. *
@@ -304,8 +337,10 @@ atmel_hlcdc_layer_to_plane(struct atmel_hlcdc_layer *layer)* @conflicting_output_formats: true if RGBXXX output formats conflict with * each other. * @fixed_clksrc: true if clock source is fixed +* @is_xlcdc: true if XLCDC IP is supported * @layers: a layer description table describing available layers * @nlayers: layer description table size +* @ops: atmel lcdc dc ops */ struct atmel_hlcdc_dc_desc {int min_width;
@@ -317,8 +352,10 @@ struct atmel_hlcdc_dc_desc {int max_hpw;bool conflicting_output_formats;bool fixed_clksrc; +bool is_xlcdc;const struct atmel_hlcdc_layer_desc *layers;int nlayers; +const struct atmel_lcdc_dc_ops *ops; };/**
Signature · 1 line
2.25.1
Re: [PATCH v7 1/7] drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and HLCDC IP
Dear Community Members,
I hope this message finds you well. I'm writing to kindly remind you about this patch series my colleague submitted for review.
I understand that everyone is busy,I would greatly appreciate your feedback. I thank everyone who participated in the review of the previous revisions.
I strongly believe your feedback would help improve the quality of the code. Thanks in advance.
Regards,
Hari
Quoted 91 lines · Manikandan Muralidharan
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Add
is_xlcdcflag and LCD IP specific ops in driver data to differentiate XLCDC and HLCDC code within the atmel-hlcdc driver files.Signed-off-by Manikandan Muralidharan <[email protected]>--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 37 ++++++++++++++++++++ 1 file changed, 37 insertions(+)drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +37
-1@@ -177,6 +177,9 @@ struct atmel_hlcdc_layer_cfg_layout {int csc; }; +struct atmel_hlcdc_plane_state ; +struct atmel_hlcdc_dc ; +/** * Atmel HLCDC DMA descriptor structure * @@ -288,6 +291,36 @@ atmel_hlcdc_layer_to_plane(struct atmel_hlcdc_layer *layer) return container_of(layer, struct atmel_hlcdc_plane, layer); } +/** +* struct atmel_lcdc_dc_ops - describes atmel_lcdc ops group +* to differentiate HLCDC and XLCDC IP code support. +* @plane_setup_scaler: update the vertical and horizontal scaling factors +* @update_lcdc_buffers: update the each LCDC layers DMA registers. +* @lcdc_atomic_disable: disable LCDC interrupts and layers +* @lcdc_update_general_settings: update each LCDC layers general +* confiugration register. +* @lcdc_atomic_update: enable the LCDC layers and interrupts. +* @lcdc_csc_init: update the color space conversion co-efficient of +* High-end overlay register. +* @lcdc_irq_dbg: to raise alert incase of interrupt overrun in any LCDC layer. +*/ +struct atmel_lcdc_dc_ops { +void (*plane_setup_scaler)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_plane_state *state); +void (*update_lcdc_buffers)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_plane_state *state, +u32 sr,int i); +void (*lcdc_atomic_disable)(struct atmel_hlcdc_plane *plane); +void (*lcdc_update_general_settings)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_plane_state *state); +void (*lcdc_atomic_update)(struct atmel_hlcdc_plane *plane, +struct atmel_hlcdc_dc *dc); +void (*lcdc_csc_init)(struct atmel_hlcdc_plane *plane, +const struct atmel_hlcdc_layer_desc *desc); +void (*lcdc_irq_dbg)(struct atmel_hlcdc_plane *plane, +const struct atmel_hlcdc_layer_desc *desc); +}; +/** * Atmel HLCDC Display Controller description structure. * @@ -304,8 +337,10 @@ atmel_hlcdc_layer_to_plane(struct atmel_hlcdc_layer *layer)* @conflicting_output_formats: true if RGBXXX output formats conflict with * each other. * @fixed_clksrc: true if clock source is fixed +* @is_xlcdc: true if XLCDC IP is supported * @layers: a layer description table describing available layers * @nlayers: layer description table size +* @ops: atmel lcdc dc ops */ struct atmel_hlcdc_dc_desc {int min_width;@@ -317,8 +352,10 @@ struct atmel_hlcdc_dc_desc {int max_hpw;bool conflicting_output_formats;bool fixed_clksrc; +bool is_xlcdc;const struct atmel_hlcdc_layer_desc *layers;int nlayers; +const struct atmel_lcdc_dc_ops *ops; };/** -- 2.25.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Manikandan Muralidharan
maintainerPATCH v7 2/7 drm: atmel-hlcdc: add LCD controller layer definition for sam9x75
In reply to Manikandan MuralidharanAdd the LCD controller layer definition and descriptor structure for sam9x75 for the following layers:
- Base Layer
- Overlay1 Layer
- Overlay2 Layer
- High End Overlay
--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 97 ++++++++++++++++++++ 1 file changed, 97 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +97 -0
@@ -462,6 +462,99 @@ static const struct atmel_hlcdc_dc_desc atmel_hlcdc_dc_sam9x60 = { .layers = atmel_hlcdc_sam9x60_layers, }; +static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = { + { + .name ="base" , + .formats = &atmel_hlcdc_plane_rgb_formats, + .regs_offset =0x60 , + .id =0 , + .type =ATMEL_HLCDC_BASE_LAYER , + .cfgs_offset =0x1c , + .layout = { + .xstride = {2 }, + .default_color =3 , + .general_config =4 , + .disc_pos =5 , + .disc_size =6 , + }, + .clut_offset =0x700 , + }, + { + .name ="overlay1" , + .formats = &atmel_hlcdc_plane_rgb_formats, + .regs_offset =0x160 , + .id =1 , + .type =ATMEL_HLCDC_OVERLAY_LAYER , + .cfgs_offset =0x1c , + .layout = { + .pos =2 , + .size =3 , + .xstride = {4 }, + .pstride = {5 }, + .default_color =6 , + .chroma_key =7 , + .chroma_key_mask =8 , + .general_config =9 , + }, + .clut_offset =0xb00 , + }, + { + .name ="overlay2" , + .formats = &atmel_hlcdc_plane_rgb_formats, + .regs_offset =0x260 , + .id =2 , + .type =ATMEL_HLCDC_OVERLAY_LAYER , + .cfgs_offset =0x1c , + .layout = { + .pos =2 , + .size =3 , + .xstride = {4 }, + .pstride = {5 }, + .default_color =6 , + .chroma_key =7 , + .chroma_key_mask =8 , + .general_config =9 , + }, + .clut_offset =0xf00 , + }, + { + .name ="high-end-overlay" , + .formats = &atmel_hlcdc_plane_rgb_and_yuv_formats, + .regs_offset =0x360 , + .id =3 , + .type =ATMEL_HLCDC_OVERLAY_LAYER , + .cfgs_offset =0x30 , + .layout = { + .pos =2 , + .size =3 , + .memsize =4 , + .xstride = {5 ,7 }, + .pstride = {6 ,8 }, + .default_color =9 , + .chroma_key =10 , + .chroma_key_mask =11 , + .general_config =12 , + .csc =16 , + .scaler_config =23 , + }, + .clut_offset =0x1300 , + }, +}; + +static const struct atmel_hlcdc_dc_desc atmel_xlcdc_dc_sam9x75 = { + .min_width =0 , + .min_height =0 , + .max_width =2048 , + .max_height =2048 , + .max_spw =0xff , + .max_vpw =0xff , + .max_hpw =0x3ff , + .fixed_clksrc = true, + .is_xlcdc = true, + .nlayers =ARRAY_SIZE (atmel_xlcdc_sam9x75_layers), + .layers = atmel_xlcdc_sam9x75_layers, +}; +static const struct of_device_id atmel_hlcdc_of_match[] = { { .compatible ="atmel,at91sam9n12-hlcdc" ,
@@ -487,6 +580,10 @@ static const struct of_device_id atmel_hlcdc_of_match[] = { .compatible = "microchip,sam9x60-hlcdc", .data = &atmel_hlcdc_dc_sam9x60, }, + { + .compatible = "microchip,sam9x75-xlcdc", + .data = &atmel_xlcdc_dc_sam9x75, + }, { /* sentinel */ }, };MODULE_DEVICE_TABLE (of, atmel_hlcdc_of_match);
Signature · 1 line
2.25.1
Manikandan Muralidharan
maintainerPATCH v7 3/7 drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers
In reply to Manikandan MuralidharanFrom: Durai Manickam KR <[email protected]>
The register address of the XLCDC IP used in SAM9X7 SoC family are different from the previous HLCDC. Defining those address space with valid macros.
--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 42 ++++++++++++++++++++ include/linux/mfd/atmel-hlcdc.h | 10 +++++ 2 files changed, 52 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +42 -0
@@ -15,6 +15,7 @@#include <drm/drm_plane.h> +/* LCD controller common registers */ #define ATMEL_HLCDC_LAYER_CHER 0x0#define ATMEL_HLCDC_LAYER_CHDR 0x4#define ATMEL_HLCDC_LAYER_CHSR 0x8
@@ -128,6 +129,47 @@#define ATMEL_HLCDC_MAX_LAYERS 6 +/* XLCDC controller specific registers */ +#define ATMEL_XLCDC_LAYER_ENR 0x10 +#define ATMEL_XLCDC_LAYER_EN BIT(0) + +#define ATMEL_XLCDC_LAYER_IER 0x0 +#define ATMEL_XLCDC_LAYER_IDR 0x4 +#define ATMEL_XLCDC_LAYER_ISR 0xc +#define ATMEL_XLCDC_LAYER_OVR_IRQ (p) BIT(2 + (8 * (p))) + +#define ATMEL_XLCDC_LAYER_PLANE_ADDR (p) (((p) * 0x4) + 0x18) + +#define ATMEL_XLCDC_LAYER_DMA_CFG 0 + +#define ATMEL_XLCDC_LAYER_DMA BIT(0) +#define ATMEL_XLCDC_LAYER_REP BIT(1) +#define ATMEL_XLCDC_LAYER_DISCEN BIT(4) + +#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS (4 << 6) +#define ATMEL_XLCDC_LAYER_SFACTA_ONE BIT(9) +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS (6 << 11) +#define ATMEL_XLCDC_LAYER_DFACTA_ONE BIT(14) + +#define ATMEL_XLCDC_LAYER_A0_SHIFT 16 +#define ATMEL_XLCDC_LAYER_A0 (x) \ + ((x) << ATMEL_XLCDC_LAYER_A0_SHIFT) + +#define ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE BIT(0) +#define ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE BIT(1) +#define ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE BIT(4) +#define ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE BIT(5) + +#define ATMEL_XLCDC_LAYER_VXSYCFG_ONE BIT(0) +#define ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE BIT(4) +#define ATMEL_XLCDC_LAYER_VXSCCFG_ONE BIT(16) +#define ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE BIT(20) + +#define ATMEL_XLCDC_LAYER_HXSYCFG_ONE BIT(0) +#define ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE BIT(4) +#define ATMEL_XLCDC_LAYER_HXSCCFG_ONE BIT(16) +#define ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE BIT(20) +/** * Atmel HLCDC Layer registers layout structure *
include/linux/mfd/atmel-hlcdc.h +10 -0
@@ -22,6 +22,8 @@#define ATMEL_HLCDC_DITHER BIT(6)#define ATMEL_HLCDC_DISPDLY BIT(7)#define ATMEL_HLCDC_MODE_MASK GENMASK(9, 8) +#define ATMEL_XLCDC_MODE_MASK GENMASK(10, 8) +#define ATMEL_XLCDC_DPI BIT(11)#define ATMEL_HLCDC_PP BIT(10)#define ATMEL_HLCDC_VSPSU BIT(12)#define ATMEL_HLCDC_VSPHO BIT(13)
@@ -34,6 +36,12 @@#define ATMEL_HLCDC_IDR 0x30#define ATMEL_HLCDC_IMR 0x34#define ATMEL_HLCDC_ISR 0x38 +#define ATMEL_XLCDC_ATTRE 0x3c + +#define ATMEL_XLCDC_BASE_UPDATE BIT(0) +#define ATMEL_XLCDC_OVR1_UPDATE BIT(1) +#define ATMEL_XLCDC_OVR3_UPDATE BIT(2) +#define ATMEL_XLCDC_HEO_UPDATE BIT(3)#define ATMEL_HLCDC_CLKPOL BIT(0)#define ATMEL_HLCDC_CLKSEL BIT(2)
@@ -48,6 +56,8 @@#define ATMEL_HLCDC_DISP BIT(2)#define ATMEL_HLCDC_PWM BIT(3)#define ATMEL_HLCDC_SIP BIT(4) +#define ATMEL_XLCDC_SD BIT(5) +#define ATMEL_XLCDC_CM BIT(6)#define ATMEL_HLCDC_SOF BIT(0)#define ATMEL_HLCDC_SYNCDIS BIT(1)
Signature · 1 line
2.25.1
Manikandan Muralidharan
maintainerPATCH v7 4/7 drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver
In reply to Manikandan MuralidharanXLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag and with HLCDC and XLCDC IP specific ops. HEO scaling, window resampling, Alpha blending, YUV-to-RGB conversion in XLCDC is derived and handled using additional configuration bits and registers. Writing one to the Enable fields of each layer in LCD_ATTRE is required to reflect the values set in Configuration, FBA, Enable registers of each layer.
--- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 33 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 6 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 3 + .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 349 +++++++++++++++--- 4 files changed, 329 insertions(+), 62 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +31 -2
@@ -79,6 +79,7 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)unsigned int mask =ATMEL_HLCDC_CLKDIV_MASK |ATMEL_HLCDC_CLKPOL ;unsigned int cfg =0 ;int div, ret; +bool is_xlcdc = crtc->dc->desc->is_xlcdc;/* get encoder from crtc */ drm_for_each_encoder (en_iter, ddev) {
@@ -164,10 +165,10 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) state =drm_crtc_state_to_atmel_hlcdc_crtc_state (c->state); cfg = state->output_mode <<8 ; -if (adj->flags &DRM_MODE_FLAG_NVSYNC ) +if (!is_xlcdc && (adj->flags &DRM_MODE_FLAG_NVSYNC )) cfg |=ATMEL_HLCDC_VSPOL ; -if (adj->flags &DRM_MODE_FLAG_NHSYNC ) +if (!is_xlcdc && (adj->flags &DRM_MODE_FLAG_NHSYNC )) cfg |=ATMEL_HLCDC_HSPOL ; regmap_update_bits(regmap, ATMEL_HLCDC_CFG(5),
@@ -202,6 +203,20 @@ static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c,pm_runtime_get_sync (dev->dev); +if (crtc->dc->desc->is_xlcdc) { +regmap_write (regmap,ATMEL_HLCDC_DIS ,ATMEL_XLCDC_CM ); +if (regmap_read_poll_timeout (regmap,ATMEL_HLCDC_SR , status, + !(status &ATMEL_XLCDC_CM ), +10 ,1000 )) +dev_warn (dev->dev,"Atmel LCDC status register CMSTS timeout\n" ); + +regmap_write (regmap,ATMEL_HLCDC_DIS ,ATMEL_XLCDC_SD ); +if (regmap_read_poll_timeout (regmap,ATMEL_HLCDC_SR , status, + status &ATMEL_XLCDC_SD , +10 ,1000 )) +dev_warn (dev->dev,"Atmel LCDC status register SDSTS timeout\n" ); + } +regmap_write (regmap,ATMEL_HLCDC_DIS ,ATMEL_HLCDC_DISP );while (!regmap_read (regmap,ATMEL_HLCDC_SR , &status) && (status &ATMEL_HLCDC_DISP ))
@@ -256,6 +271,20 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c, !(status & ATMEL_HLCDC_DISP))cpu_relax (); +if (crtc->dc->desc->is_xlcdc) { +regmap_write (regmap,ATMEL_HLCDC_EN ,ATMEL_XLCDC_CM ); +if (regmap_read_poll_timeout (regmap,ATMEL_HLCDC_SR , status, + status &ATMEL_XLCDC_CM , +10 ,1000 )) +dev_warn (dev->dev,"Atmel LCDC status register CMSTS timeout\n" ); + +regmap_write (regmap,ATMEL_HLCDC_EN ,ATMEL_XLCDC_SD ); +if (regmap_read_poll_timeout (regmap,ATMEL_HLCDC_SR , status, + !(status &ATMEL_XLCDC_SD ), +10 ,1000 )) +dev_warn (dev->dev,"Atmel LCDC status register SDSTS timeout\n" ); + } +pm_runtime_put_sync (dev->dev); }
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +6 -0
@@ -58,6 +58,7 @@ static const struct atmel_hlcdc_dc_desc atmel_hlcdc_dc_at91sam9n12 = { .conflicting_output_formats = true, .nlayers = ARRAY_SIZE(atmel_hlcdc_at91sam9n12_layers), .layers = atmel_hlcdc_at91sam9n12_layers, + .ops = &atmel_hlcdc_ops, };static const struct atmel_hlcdc_layer_desc atmel_hlcdc_at91sam9x5_layers[] = {
@@ -151,6 +152,7 @@ static const struct atmel_hlcdc_dc_desc atmel_hlcdc_dc_at91sam9x5 = { .conflicting_output_formats = true, .nlayers = ARRAY_SIZE(atmel_hlcdc_at91sam9x5_layers), .layers = atmel_hlcdc_at91sam9x5_layers, + .ops = &atmel_hlcdc_ops, };static const struct atmel_hlcdc_layer_desc atmel_hlcdc_sama5d3_layers[] = {
@@ -269,6 +271,7 @@ static const struct atmel_hlcdc_dc_desc atmel_hlcdc_dc_sama5d3 = { .conflicting_output_formats = true, .nlayers = ARRAY_SIZE(atmel_hlcdc_sama5d3_layers), .layers = atmel_hlcdc_sama5d3_layers, + .ops = &atmel_hlcdc_ops, };static const struct atmel_hlcdc_layer_desc atmel_hlcdc_sama5d4_layers[] = {
@@ -364,6 +367,7 @@ static const struct atmel_hlcdc_dc_desc atmel_hlcdc_dc_sama5d4 = { .max_hpw = 0x3ff, .nlayers = ARRAY_SIZE(atmel_hlcdc_sama5d4_layers), .layers = atmel_hlcdc_sama5d4_layers, + .ops = &atmel_hlcdc_ops, };static const struct atmel_hlcdc_layer_desc atmel_hlcdc_sam9x60_layers[] = {
@@ -460,6 +464,7 @@ static const struct atmel_hlcdc_dc_desc atmel_hlcdc_dc_sam9x60 = { .fixed_clksrc = true, .nlayers = ARRAY_SIZE(atmel_hlcdc_sam9x60_layers), .layers = atmel_hlcdc_sam9x60_layers, + .ops = &atmel_hlcdc_ops, };static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = {
@@ -553,6 +558,7 @@ static const struct atmel_hlcdc_dc_desc atmel_xlcdc_dc_sam9x75 = { .is_xlcdc = true, .nlayers = ARRAY_SIZE(atmel_xlcdc_sam9x75_layers), .layers = atmel_xlcdc_sam9x75_layers, + .ops = &atmel_xlcdc_ops, };static const struct of_device_id atmel_hlcdc_of_match[] = {
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +3 -0
@@ -424,6 +424,9 @@ struct atmel_hlcdc_dc { } suspend; }; +extern const struct atmel_lcdc_dc_ops atmel_hlcdc_ops; +extern const struct atmel_lcdc_dc_ops atmel_xlcdc_ops; +extern struct atmel_hlcdc_formats atmel_hlcdc_plane_rgb_formats;extern struct atmel_hlcdc_formats atmel_hlcdc_plane_rgb_and_yuv_formats;
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +289 -60
452 lines not on this page · raw message
Signature · 1 line
2.25.1
Manikandan Muralidharan
maintainerPATCH v7 5/7 drm: atmel-hlcdc: add DPI mode support for XLCDC
In reply to Manikandan MuralidharanAdd support for Display Pixel Interface (DPI) Compatible Mode support in atmel-hlcdc driver for XLCDC IP along with legacy pixel mapping. DPI mode BIT is configured in LCDC_CFG5 register.
--- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 21 +++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +19 -2
@@ -30,10 +30,12 @@* * @base: base CRTC state * @output_mode: RGBXXX output mode +* @dpi: output DPI mode */ struct atmel_hlcdc_crtc_state {struct drm_crtc_state base;unsigned int output_mode; +u8 dpi; }; static inline struct atmel_hlcdc_crtc_state *
@@ -164,6 +166,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) state =drm_crtc_state_to_atmel_hlcdc_crtc_state (c->state); cfg = state->output_mode <<8 ; +if (is_xlcdc) + cfg |= state->dpi <<11 ;if (!is_xlcdc && (adj->flags &DRM_MODE_FLAG_NVSYNC )) cfg |=ATMEL_HLCDC_VSPOL ;
@@ -176,7 +180,9 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)ATMEL_HLCDC_VSPDLYS |ATMEL_HLCDC_VSPDLYE |ATMEL_HLCDC_DISPPOL |ATMEL_HLCDC_DISPDLY |ATMEL_HLCDC_VSPSU |ATMEL_HLCDC_VSPHO | -ATMEL_HLCDC_GUARDTIME_MASK |ATMEL_HLCDC_MODE_MASK , +ATMEL_HLCDC_GUARDTIME_MASK | + (is_xlcdc ?ATMEL_XLCDC_MODE_MASK | +ATMEL_XLCDC_DPI :ATMEL_HLCDC_MODE_MASK ), cfg);clk_disable_unprepare (crtc->dc->hlcdc->sys_clk);
@@ -374,7 +380,15 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state) hstate =drm_crtc_state_to_atmel_hlcdc_crtc_state (state); hstate->output_mode =fls (output_fmts) -1 ; - +if (crtc->dc->desc->is_xlcdc) { +/* check if MIPI DPI bit needs to be set */ +if (fls (output_fmts) >3 ) { + hstate->output_mode -=4 ; + hstate->dpi =1 ; + }else { + hstate->dpi =0 ; + } + }return 0 ; }
@@ -478,6 +492,7 @@ static struct drm_crtc_state * atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc) {struct atmel_hlcdc_crtc_state *state, *cur; +struct atmel_hlcdc_crtc *c =drm_crtc_to_atmel_hlcdc_crtc (crtc);if (WARN_ON (!crtc->state))return NULL ;
@@ -489,6 +504,8 @@ atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc) cur =drm_crtc_state_to_atmel_hlcdc_crtc_state (crtc->state); state->output_mode = cur->output_mode; +if (c->dc->desc->is_xlcdc) + state->dpi = cur->dpi;return &state->base; }
Signature · 1 line
2.25.1
Manikandan Muralidharan
maintainerPATCH v7 6/7 drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC
In reply to Manikandan MuralidharanUpdate the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which supports vertical and horizontal scaling with Bilinear and Bicubic co-efficients taps for Chroma and Luma componenets of the Pixel.
--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 ++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 4 ++++ .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 20 +++++++++++++++++++ 3 files changed, 26 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +2 -0
@@ -541,6 +541,8 @@ static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = { .general_config = 12, .csc = 16, .scaler_config = 23, + .vxs_config = 30, + .hxs_config = 31, }, .clut_offset = 0x1300, },
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +4 -0
@@ -198,6 +198,8 @@* @disc_pos: discard area position register * @disc_size: discard area size register * @csc: color space conversion register +* @vxs_config: vertical scalar filter taps control register +* @hxs_config: horizontal scalar filter taps control register */ struct atmel_hlcdc_layer_cfg_layout {int xstride[ATMEL_HLCDC_LAYER_MAX_PLANES ];
@@ -217,6 +219,8 @@ struct atmel_hlcdc_layer_cfg_layout {int disc_pos;int disc_size;int csc; +int vxs_config; +int hxs_config; };struct atmel_hlcdc_plane_state ;
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +20 -0
@@ -966,6 +966,26 @@ static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane, desc->layout.csc + i, xlcdc_csc_coeffs[i]); } + +if (desc->layout.vxs_config && desc->layout.hxs_config) { +/* +* Updating vxs.config and hxs.config fixes the +* Green Color Issue in SAM9X7 EGT Video Player App +*/ +atmel_hlcdc_layer_write_cfg (&plane->layer, + desc->layout.vxs_config, +ATMEL_XLCDC_LAYER_VXSYCFG_ONE | +ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE | +ATMEL_XLCDC_LAYER_VXSCCFG_ONE | +ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE ); + +atmel_hlcdc_layer_write_cfg (&plane->layer, + desc->layout.hxs_config, +ATMEL_XLCDC_LAYER_HXSYCFG_ONE | +ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE | +ATMEL_XLCDC_LAYER_HXSCCFG_ONE | +ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE ); + } }static int atmel_hlcdc_plane_init_properties (struct atmel_hlcdc_plane *plane)
Signature · 1 line
2.25.1
Manikandan Muralidharan
maintainerPATCH v7 7/7 drm: atmel-hlcdc: add support for DSI output formats
In reply to Manikandan MuralidharanAdd support for the following DPI mode if the encoder type is DSI as per the XLCDC IP datasheet:
- 16BPPCFG1
- 16BPPCFG2
- 16BPPCFG3
- 18BPPCFG1
- 18BPPCFG2
- 24BPP
--- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 123 +++++++++++++----- 1 file changed, 88 insertions(+), 35 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +88 -35
@@ -295,11 +295,18 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c, } -#define ATMEL_HLCDC_RGB444_OUTPUT BIT(0) -#define ATMEL_HLCDC_RGB565_OUTPUT BIT(1) -#define ATMEL_HLCDC_RGB666_OUTPUT BIT(2) -#define ATMEL_HLCDC_RGB888_OUTPUT BIT(3) -#define ATMEL_HLCDC_OUTPUT_MODE_MASK GENMASK(3, 0) +#define ATMEL_HLCDC_RGB444_OUTPUT BIT(0) +#define ATMEL_HLCDC_RGB565_OUTPUT BIT(1) +#define ATMEL_HLCDC_RGB666_OUTPUT BIT(2) +#define ATMEL_HLCDC_RGB888_OUTPUT BIT(3) +#define ATMEL_HLCDC_DPI_RGB565C1_OUTPUT BIT(4) +#define ATMEL_HLCDC_DPI_RGB565C2_OUTPUT BIT(5) +#define ATMEL_HLCDC_DPI_RGB565C3_OUTPUT BIT(6) +#define ATMEL_HLCDC_DPI_RGB666C1_OUTPUT BIT(7) +#define ATMEL_HLCDC_DPI_RGB666C2_OUTPUT BIT(8) +#define ATMEL_HLCDC_DPI_RGB888_OUTPUT BIT(9) +#define ATMEL_HLCDC_OUTPUT_MODE_MASK GENMASK(3, 0) +#define ATMEL_XLCDC_OUTPUT_MODE_MASK GENMASK(9, 0)static int atmel_hlcdc_connector_output_mode (struct drm_connector_state *state) {
@@ -313,53 +320,99 @@ static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state)if (!encoder) encoder = connector->encoder; -switch (atmel_hlcdc_encoder_get_bus_fmt (encoder)) { -case 0 : -break ; -case MEDIA_BUS_FMT_RGB444_1X12 : -return ATMEL_HLCDC_RGB444_OUTPUT ; -case MEDIA_BUS_FMT_RGB565_1X16 : -return ATMEL_HLCDC_RGB565_OUTPUT ; -case MEDIA_BUS_FMT_RGB666_1X18 : -return ATMEL_HLCDC_RGB666_OUTPUT ; -case MEDIA_BUS_FMT_RGB888_1X24 : -return ATMEL_HLCDC_RGB888_OUTPUT ; -default : -return -EINVAL ; - } - -for (j =0 ; j < info->num_bus_formats; j++) { -switch (info->bus_formats[j]) { -case MEDIA_BUS_FMT_RGB444_1X12 : - supported_fmts |=ATMEL_HLCDC_RGB444_OUTPUT ; +if (encoder->encoder_type ==DRM_MODE_ENCODER_DSI ) { +/* +* atmel-hlcdc to support DSI formats with DSI video pipeline +* when DRM_MODE_ENCODER_DSI type is set by +* connector driver component. +*/ +switch (atmel_hlcdc_encoder_get_bus_fmt (encoder)) { +case 0 :break ;case MEDIA_BUS_FMT_RGB565_1X16 : - supported_fmts |=ATMEL_HLCDC_RGB565_OUTPUT ; -break ; +return ATMEL_HLCDC_DPI_RGB565C1_OUTPUT ;case MEDIA_BUS_FMT_RGB666_1X18 : - supported_fmts |=ATMEL_HLCDC_RGB666_OUTPUT ; -break ; +return ATMEL_HLCDC_DPI_RGB666C1_OUTPUT ; +case MEDIA_BUS_FMT_RGB666_1X24_CPADHI : +return ATMEL_HLCDC_DPI_RGB666C2_OUTPUT ;case MEDIA_BUS_FMT_RGB888_1X24 : - supported_fmts |=ATMEL_HLCDC_RGB888_OUTPUT ; -break ; +return ATMEL_HLCDC_DPI_RGB888_OUTPUT ;default : +return -EINVAL ; + } + +for (j =0 ; j < info->num_bus_formats; j++) { +switch (info->bus_formats[j]) { +case MEDIA_BUS_FMT_RGB565_1X16 : + supported_fmts |= +ATMEL_HLCDC_DPI_RGB565C1_OUTPUT ; +break ; +case MEDIA_BUS_FMT_RGB666_1X18 : + supported_fmts |= +ATMEL_HLCDC_DPI_RGB666C1_OUTPUT ; +break ; +case MEDIA_BUS_FMT_RGB666_1X24_CPADHI : + supported_fmts |= +ATMEL_HLCDC_DPI_RGB666C2_OUTPUT ; +break ; +case MEDIA_BUS_FMT_RGB888_1X24 : + supported_fmts |= +ATMEL_HLCDC_DPI_RGB888_OUTPUT ; +break ; +default : +break ; + } + } + }else { +switch (atmel_hlcdc_encoder_get_bus_fmt (encoder)) { +case 0 :break ; +case MEDIA_BUS_FMT_RGB444_1X12 : +return ATMEL_HLCDC_RGB444_OUTPUT ; +case MEDIA_BUS_FMT_RGB565_1X16 : +return ATMEL_HLCDC_RGB565_OUTPUT ; +case MEDIA_BUS_FMT_RGB666_1X18 : +return ATMEL_HLCDC_RGB666_OUTPUT ; +case MEDIA_BUS_FMT_RGB888_1X24 : +return ATMEL_HLCDC_RGB888_OUTPUT ; +default : +return -EINVAL ; } - } +for (j =0 ; j < info->num_bus_formats; j++) { +switch (info->bus_formats[j]) { +case MEDIA_BUS_FMT_RGB444_1X12 : + supported_fmts |=ATMEL_HLCDC_RGB444_OUTPUT ; +break ; +case MEDIA_BUS_FMT_RGB565_1X16 : + supported_fmts |=ATMEL_HLCDC_RGB565_OUTPUT ; +break ; +case MEDIA_BUS_FMT_RGB666_1X18 : + supported_fmts |=ATMEL_HLCDC_RGB666_OUTPUT ; +break ; +case MEDIA_BUS_FMT_RGB888_1X24 : + supported_fmts |=ATMEL_HLCDC_RGB888_OUTPUT ; +break ; +default : +break ; + } + } + }return supported_fmts; }static int atmel_hlcdc_crtc_select_output_mode (struct drm_crtc_state *state) { -unsigned int output_fmts =ATMEL_HLCDC_OUTPUT_MODE_MASK ; +unsigned int output_fmts;struct atmel_hlcdc_crtc_state *hstate;struct drm_connector_state *cstate;struct drm_connector *connector; -struct atmel_hlcdc_crtc *crtc; +struct atmel_hlcdc_crtc *crtc =drm_crtc_to_atmel_hlcdc_crtc (state->crtc);int i; +bool is_xlcdc = crtc->dc->desc->is_xlcdc; - crtc =drm_crtc_to_atmel_hlcdc_crtc (state->crtc); + output_fmts = is_xlcdc ?ATMEL_XLCDC_OUTPUT_MODE_MASK : +ATMEL_HLCDC_OUTPUT_MODE_MASK ;for_each_new_connector_in_state (state->state, connector, cstate, i) {unsigned int supported_fmts =0 ;
@@ -380,7 +433,7 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state) hstate =drm_crtc_state_to_atmel_hlcdc_crtc_state (state); hstate->output_mode =fls (output_fmts) -1 ; -if (crtc->dc->desc->is_xlcdc) { +if (is_xlcdc) {/* check if MIPI DPI bit needs to be set */ if (fls (output_fmts) >3 ) { hstate->output_mode -=4 ;
Signature · 1 line
2.25.1
[email protected]
maintainerQuoted 8 lines · Manikandan Muralidharan
This patch series aims to add support for XLCDC IP of sam9x7 SoC family to the DRM subsystem.XLCDC IP has additional registers and new configuration bits compared to the existing register set of HLCDC IP. The new compatible string "microchip,sam9x75-xlcdc" is defined for sam9x75 variant of the sam9x7 SoC family.The
is_xlcdcflag under driver data and IP specific driver ops helps to differentiate the XLCDC and existing HLCDC code within the same driver.
Hi All,
I would appreciate any additional insights you may have on the recent changes in this version.
Quoted 54 lines
changes in v7:
* LCDC IP driver ops functions are declared static and its declaration are removed.changes in v6:
* Fixed Cosmetic defects.
* Added comments for readability.changes in v5:
* return value ofregmap_read_poll_timeoutis checked in failure case.
* HLCDC and XLCDC specific driver functions are now invoked using its IP specific driver ops w/o the need of checkingis_xlcdcflag.
* Removed empty spaces and blank lines.changes in v4:
* fixed kernel warnings reported by kernel test robot.changes in v3:
* Removed de-referencing the value ofis_xlcdcflag multiple times in a single function.
* Removedcpu_relax()call when usingregmap_read_poll_timeout.
* Updated xfactor and yfactor equations using shift operators
* Defined CSC co-efficients in an array for code readability.changes in v2:
* Change the driver compatible name from "microchip,sam9x7-xlcdc" to "microchip,sam9x75-xlcdc".
* Moveis_xlcdcflag to driver data.
* Remove unsed Macro definitions.
* Add co-developed-bys tags
* Replaceregmap_read()withregmap_read_poll_timeout()call
* Split code into two helpers for code readablitity.Durai Manickam KR (1):
drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registersManikandan Muralidharan (6):
drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and
HLCDC IP
drm: atmel-hlcdc: add LCD controller layer definition for sam9x75
drm:atmel_hlcdc: Add support for XLCDC in atmel LCD driver
drm: atmel-hlcdc: add DPI mode support for XLCDC
drm: atmel-hlcdc: add vertical and horizontal scaling support for
XLCDC
drm: atmel-hlcdc: add support for DSI output formats.../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 175 +++++++-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 105 +++++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 86 ++++ .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 369 +++++++++++++++--- include/linux/mfd/atmel-hlcdc.h | 10 + 5 files changed, 647 insertions(+), 98 deletions(-)
Signature · 2 lines
Thanks and Regards, Manikandan M.