firmware: ti_sci: Use device_get_match_data()
PATCH 1/1 firmware: ti_sci: Use device_get_match_data()
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers.
--- drivers/firmware/ti_sci.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
drivers/firmware/ti_sci.c +5 -8
@@ -16,7 +16,10 @@#include <linux/kernel.h> #include <linux/mailbox_client.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> +#include <linux/property.h> #include <linux/semaphore.h> #include <linux/slab.h> #include <linux/soc/ti/ti-msgmgr.h>
@@ -3293,7 +3296,6 @@ MODULE_DEVICE_TABLE(of, ti_sci_of_match);static int ti_sci_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev; -const struct of_device_id *of_id;const struct ti_sci_desc *desc;struct ti_sci_xfer *xfer;struct ti_sci_info *info =NULL ;
@@ -3304,12 +3306,7 @@ static int ti_sci_probe(struct platform_device *pdev)int reboot =0 ;u32 h_id; - of_id =of_match_device (ti_sci_of_match, dev); -if (!of_id) { -dev_err (dev,"OF data missing\n" ); -return -EINVAL ; - } - desc = of_id->data; + desc =device_get_match_data (dev); info =devm_kzalloc (dev,sizeof (*info),GFP_KERNEL );if (!info)
Signature · 1 line
2.40.1
Hi Rob Herring,
Quoted 5 lines · Rob Herring
Use preferred
device_get_match_data()instead ofof_match_device()to get the driver match data. With this, adjust the includes to explicitly include the correct headers.
I have applied the following to branch ti-drivers-soc-next on [1]. Thank you!
[1/1] firmware: ti_sci: Use device_get_match_data()
commit: 05e5f732850632f24310b677d16787136733f5d4
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Signature · 9 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel