kasan:print the original fault addr when access invalid shadow
Subsystems (3)
PATCH v2 1/1 kasan:print the original fault addr when access invalid shadow
when the checked address is illegal,the corresponding shadow address from kasan_mem_to_shadow may have no mapping in mmu table. Access such shadow address causes kernel oops.
Here is a sample about oops on arm64(VA 39bit)
with KASAN_SW_TAGS and KASAN_OUTLINE on:
[ffffffb80aaaaaaa] pgd=000000005d3ce003, p4d=000000005d3ce003,
pud=000000005d3ce003, pmd=0000000000000000 Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP Modules linked in: CPU: 3 PID: 100 Comm: sh Not tainted 6.6.0-rc1-dirty #43 Hardware name: linux,dummy-virt (DT) pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __hwasan_load8_noabort+0x5c/0x90 lr : do_ib_ob+0xf4/0x110
ffffffb80aaaaaaa is the shadow address for efffff80aaaaaaaa. The problem is reading invalid shadow in kasan_check_range.
The generic kasan also has similar oops.
It only reports the shadow address which causes oops but not the original address.
Commit 2f004eea0fc8("x86/kasan: Print original address on #GP") introduce to kasan_non_canonical_hook but limit it to KASAN_INLINE.
This patch extends it to KASAN_OUTLINE mode.
---
v2:
- In view of the possible perf impact by checking shadow address,change to use kasan_non_canonical_hook as it works after oops.
--- include/linux/kasan.h | 6 +++--- mm/kasan/report.c | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-)
include/linux/kasan.h +3 -3
@@ -466,10 +466,10 @@ static inline void kasan_free_module_shadow(const struct vm_struct *vm) {}#endif /* (CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS) && !CONFIG_KASAN_VMALLOC */ -#ifdef CONFIG_KASAN_INLINE +#ifdef CONFIG_KASAN void kasan_non_canonical_hook (unsigned long addr); -#else /* CONFIG_KASAN_INLINE */ +#else /* CONFIG_KASAN */ static inline void kasan_non_canonical_hook (unsigned long addr) { } -#endif /* CONFIG_KASAN_INLINE */ +#endif /* CONFIG_KASAN */ #endif /* LINUX_KASAN_H */
mm/kasan/report.c +1 -3
@@ -621,9 +621,8 @@ void kasan_report_async(void) }#endif /* CONFIG_KASAN_HW_TAGS */ -#ifdef CONFIG_KASAN_INLINE /* -* With CONFIG_KASAN_INLINE, accesses to bogus pointers (outside the high +* With CONFIG_KASAN, accesses to bogus pointers (outside the high * canonical half of the address space) cause out-of-bounds shadow memory reads * before the actual access. For addresses in the low canonical half of the * address space, as well as most non-canonical addresses, that out-of-bounds
@@ -659,4 +658,3 @@ void kasan_non_canonical_hook(unsigned long addr)pr_alert ("KASAN: %s in range [0x%016lx-0x%016lx]\n" , bug_type, orig_addr, orig_addr +KASAN_GRANULE_SIZE -1 ); } -#endif
Signature · 1 line
2.18.0
Andrew Morton
maintainerQuoted 20 lines · On Mon, 9 Oct 2023 15:37:48 +0800 Haibo Li <[email protected]> wrote:
when the checked address is illegal,the corresponding shadow address from
kasan_mem_to_shadowmay have no mapping in mmu table. Access such shadow address causes kernel oops.
Here is a sample about oops on arm64(VA 39bit)
withKASAN_SW_TAGSandKASAN_OUTLINEon:[
ffffffb80aaaaaaa] pgd=000000005d3ce003, p4d=000000005d3ce003,pud=000000005d3ce003, pmd=0000000000000000 Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP Modules linked in: CPU: 3 PID: 100 Comm: sh Not tainted 6.6.0-rc1-dirty #43 Hardware name: linux,dummy-virt (DT) pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __hwasan_load8_noabort+0x5c/0x90 lr : do_ib_ob+0xf4/0x110
ffffffb80aaaaaaais the shadow address forefffff80aaaaaaaa. The problem is reading invalid shadow inkasan_check_range.The generic kasan also has similar oops.
Quoted 7 lines
It only reports the shadow address which causes oops but not the original address.
Commit 2f004eea0fc8("x86/kasan: Print original address on #GP") introduce to
kasan_non_canonical_hookbut limit it toKASAN_INLINE.This patch extends it to
KASAN_OUTLINEmode.
Is 2f004eea0fc8 a suitable Fixes: target for this? If not, what is?
Also, I'm assuming that we want to backport this fix into earlier kernel versions?
Quoted 25 lines · On Mon, 9 Oct 2023 15:37:48 +0800 Haibo Li <[email protected]> wrote:
Quoted 24 lines
when the checked address is illegal,the corresponding shadow address from
kasan_mem_to_shadowmay have no mapping in mmu table. Access such shadow address causes kernel oops.
Here is a sample about oops on arm64(VA 39bit)
withKASAN_SW_TAGSandKASAN_OUTLINEon:[
ffffffb80aaaaaaa] pgd=000000005d3ce003, p4d=000000005d3ce003,pud=000000005d3ce003, pmd=0000000000000000 Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP Modules linked in: CPU: 3 PID: 100 Comm: sh Not tainted 6.6.0-rc1-dirty #43 Hardware name: linux,dummy-virt (DT) pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __hwasan_load8_noabort+0x5c/0x90 lr : do_ib_ob+0xf4/0x110
ffffffb80aaaaaaais the shadow address forefffff80aaaaaaaa. The problem is reading invalid shadow inkasan_check_range.The generic kasan also has similar oops.
It only reports the shadow address which causes oops but not the original address.
Quoted 7 lines
Quoted 4 lines
Commit 2f004eea0fc8("x86/kasan: Print original address on #GP") introduce to
kasan_non_canonical_hookbut limit it toKASAN_INLINE.This patch extends it to
KASAN_OUTLINEmode.Is
2f004eea0fc8a suitable Fixes: target for this? If not, what is?
Yes, 2f004eea0fc8 is a suitable fix.
All we need is a better crash report for this case.
After commit 2f004eea0fc8 and commit07b742a4d912 ("arm64: mm: log potential KASAN shadow alias"), it is easy to understand the original address when
out-of-bounds KASAN shadow accesses occur.
Currently, this feature is only available for the KASAN_INLINE case. As Jann said, it is also suitable for the KASAN_OUTLINE case.
Quoted 2 lines
Also, I'm assuming that we want to backport this fix into earlier kernel versions?
My opinion:
As it is to improve crash report,there is no requirement to backport.
Quoted 78 lines · Haibo Li
when the checked address is illegal,the corresponding shadow address from
kasan_mem_to_shadowmay have no mapping in mmu table. Access such shadow address causes kernel oops.
Here is a sample about oops on arm64(VA 39bit)
withKASAN_SW_TAGSandKASAN_OUTLINEon:[
ffffffb80aaaaaaa] pgd=000000005d3ce003, p4d=000000005d3ce003,pud=000000005d3ce003, pmd=0000000000000000 Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP Modules linked in: CPU: 3 PID: 100 Comm: sh Not tainted 6.6.0-rc1-dirty #43 Hardware name: linux,dummy-virt (DT) pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __hwasan_load8_noabort+0x5c/0x90 lr : do_ib_ob+0xf4/0x110
ffffffb80aaaaaaais the shadow address forefffff80aaaaaaaa. The problem is reading invalid shadow inkasan_check_range.The generic kasan also has similar oops.
It only reports the shadow address which causes oops but not the original address.
Commit 2f004eea0fc8("x86/kasan: Print original address on #GP") introduce to
kasan_non_canonical_hookbut limit it toKASAN_INLINE.This patch extends it to
KASAN_OUTLINEmode.Signed-off-by Haibo Li <[email protected]>---
v2:
- In view of the possible perf impact by checking shadow address,change to usekasan_non_canonical_hookas it works after oops.--- include/linux/kasan.h | 6 +++--- mm/kasan/report.c | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-)include/linux/kasan.h +3
-3@@ -466,10 +466,10 @@ static inline void kasan_free_module_shadow(const struct vm_struct *vm) {}#endif /* (CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS) && !CONFIG_KASAN_VMALLOC */ -#ifdef CONFIG_KASAN_INLINE +#ifdef CONFIG_KASAN void kasan_non_canonical_hook (unsigned long addr); -#else /* CONFIG_KASAN_INLINE */ +#else /* CONFIG_KASAN */ static inline void kasan_non_canonical_hook (unsigned long addr) { } -#endif /* CONFIG_KASAN_INLINE */ +#endif /* CONFIG_KASAN */ #endif /* LINUX_KASAN_H */ mm/kasan/report.c +1
-4@@ -621,9 +621,8 @@ void kasan_report_async(void) }#endif /* CONFIG_KASAN_HW_TAGS */ -#ifdef CONFIG_KASAN_INLINE /* -* With CONFIG_KASAN_INLINE, accesses to bogus pointers (outside the high +* With CONFIG_KASAN, accesses to bogus pointers (outside the high * canonical half of the address space) cause out-of-bounds shadow memory reads * before the actual access. For addresses in the low canonical half of the * address space, as well as most non-canonical addresses, that out-of-bounds @@ -659,4 +658,3 @@ void kasan_non_canonical_hook(unsigned long addr)pr_alert ("KASAN: %s in range [0x%016lx-0x%016lx]\n" , bug_type, orig_addr, orig_addr +KASAN_GRANULE_SIZE -1 ); } -#endif --
Quoted 2 lines
2.18.0
Thank you!
On a related note, I have debugged the reason why kasan_non_canonical_hook sometimes doesn't get engaged properly for the SW_TAGS mode. I'll post a fix next week.