arm64: dts: ti: k3-j7200: Fixes for various dtbs_checks warnings
Subsystems (2)
v4 cover arm64: dts: ti: k3-j7200: Fixes for various dtbs_checks warnings
Hi,
Few fixups for j7200 dtbs_check warnings.
This is V4 for the following series rebased and tested with 6.6-rc5,
V3 : https://lore.kernel.org/all/[email protected]
V2 : https://lore.kernel.org/all/[email protected]/
V1 : https://lore.kernel.org/all/[email protected]/
Bootlog with basic hyperflash testing (6.6.0-rc5-next-20231009):
https://gist.github.com/vaishnavachath/f7265e932725fd992dbc4e48b993e9c0
Patch 2/2 depends on the following patch under review which enables reg-mux to be used when parent node is not syscon :
https://lore.kernel.org/all/[email protected]/
Changelog:
V3->V4:
* Rebase and tested with 6.6-rc5
V2->V3:
* Drop pinctrl fix patch as the fix [2] is already merged to next.
* Keep register regions unchanged as it is correct according to memory map, update commit message.
V1->V2:
* Address feedback as recommended in [3].
* Address feedback from Udit to limit the FSS register region size as per TRM.
* Use reg-mux changes in [4] to simplify the hbmc-mux modelling
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/all/20230503115130.c7m4a7crub7kmfjw@gluten/
[4] https://lore.kernel.org/all/[email protected]/
Nishanth Menon (2):
arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to
ti,j721e-system-controller
arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1
PATCH v4 1/2 arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller
From: Nishanth Menon <[email protected]>
Use ti,j721e-system-controller to be explicit about the syscon node we are using.
---
No changes since V1.
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1 -1
@@ -165,7 +165,7 @@ }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>;
Signature · 1 line
2.17.1
Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller
Quoted 31 lines · Vaishnav Achath
From: Nishanth Menon <[email protected]>
Use ti,j721e-system-controller to be explicit about the syscon node we are using.
Signed-off-by Nishanth Menon <[email protected]>Signed-off-by Vaishnav Achath <[email protected]>---
No changes since V1.
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1
-1@@ -165,7 +165,7 @@ }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>;Signature · 1 line
2.17.1
Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller
In reply to Vaishnav AchathQuoted 19 lines · Vaishnav Achath
From: Nishanth Menon <[email protected]>
Use ti,j721e-system-controller to be explicit about the syscon node we are using.
Signed-off-by Nishanth Menon <[email protected]>Signed-off-by Vaishnav Achath <[email protected]>---
No changes since V1.
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0
-0
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi line 168
Quoted 5 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1
-1@@ -165,7 +165,7 @@ }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
There is already a "ti,j721e-system-controller" in the main domain dtsi. And this is not one of those. You are hiding a valid DT warning by adding an incorrect compatible string that just so happens to not throw the warning.
This should be a "simple-bus" node.
Andrew
Quoted 3 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0
-0reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>;
PATCH v4 2/2 arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux
In reply to Vaishnav AchathFrom: Nishanth Menon <[email protected]>
FSS node claims to be a syscon node, while it actually is a simple bus where OSPI, HBMC peripherals are located and a mux for path select between OSPI and Hyperbus which can be modelled as a reg-mux. So model it accordingly and use reg-mux to describe the hbmc_mux.
---
V2->V3:
* Keep register regions unchanged as it is correct according to memory map.
* Update commit messages as per Vignesh's suggestion.
V1->V2:
* Address feedback from Udit to limit the FSS register region size as per TRM.
* Use reg-mux changes to simplify the hbmc-mux modelling.
* Update commit message to reflect changes.
Depends on:
https://lore.kernel.org/all/[email protected]/
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +5 -4
@@ -507,15 +507,16 @@ status = "disabled"; }; - fss: syscon@47000000 { - compatible = "syscon", "simple-mfd"; + fss: bus@47000000 { + compatible = "simple-bus"; reg = <0x00 0x47000000 0x00 0x100>; #address-cells = <2>; #size-cells = <2>; ranges; - hbmc_mux: hbmc-mux { - compatible = "mmio-mux"; + hbmc_mux: mux-controller@47000004 { + compatible = "reg-mux"; + reg = <0x00 0x47000004 0x00 0x2>; #mux-control-cells = <1>; mux-reg-masks = <0x4 0x2>; /* HBMC select */ };
Signature · 1 line
2.17.1
Re: [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux
Quoted 57 lines · Vaishnav Achath
From: Nishanth Menon <[email protected]>
FSS node claims to be a syscon node, while it actually is a simple bus where OSPI, HBMC peripherals are located and a mux for path select between OSPI and Hyperbus which can be modelled as a reg-mux. So model it accordingly and use reg-mux to describe the
hbmc_mux.Signed-off-by Nishanth Menon <[email protected]>Signed-off-by Vaishnav Achath <[email protected]>---
V2->V3:
* Keep register regions unchanged as it is correct according to memory map.
* Update commit messages as per Vignesh's suggestion.
V1->V2:
* Address feedback from Udit to limit the FSS register region size as per TRM.
* Use reg-mux changes to simplify the hbmc-mux modelling.
* Update commit message to reflect changes.Depends on:
https://lore.kernel.org/all/[email protected]/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +5
-4@@ -507,15 +507,16 @@ status = "disabled"; }; - fss: syscon@47000000 { - compatible = "syscon", "simple-mfd"; + fss: bus@47000000 { + compatible = "simple-bus"; reg = <0x00 0x47000000 0x00 0x100>; #address-cells = <2>; #size-cells = <2>; ranges; - hbmc_mux: hbmc-mux { - compatible = "mmio-mux"; + hbmc_mux: mux-controller@47000004 { + compatible = "reg-mux"; + reg = <0x00 0x47000004 0x00 0x2>; #mux-control-cells = <1>; mux-reg-masks = <0x4 0x2>; /* HBMC select */ };Signature · 1 line
2.17.1