Skip to contentSkip to conversation

samples: kprobes: Fixes a typo

PATCH In review Atul Kumar Pant 3 participants 7 messages Aug 17, 2023 – Oct 11, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samples: kprobes: Fixes a typo

Fixes typo in a function name.

---
 samples/kprobes/kretprobe_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/kprobes/kretprobe_example.c +1 -1
index cbf16542d84e..ed79fd3d48fb 100644
@@ -35,7 +35,7 @@ struct my_data {
 	ktime_t entry_stamp;
 };
 
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
 static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
 {
 	struct my_data *data;
Signature · 6 lines
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
#1 lore raw
Quoted 23 lines · Atul Kumar Pant

Fixes typo in a function name.

---
 samples/kprobes/kretprobe_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/kprobes/kretprobe_example.c +1 -1
index cbf16542d84e..ed79fd3d48fb 100644
@@ -35,7 +35,7 @@ struct my_data {
 	ktime_t entry_stamp;
 };
 
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
 static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
 {
 	struct my_data *data;
Signature · 1 line
2.25.1

Hi all, can someone provide comments on this change.

#2 lore raw
Quoted 16 lines · Atul Kumar Pant
Quoted 15 lines · Atul Kumar Pant

Fixes typo in a function name.

---
 samples/kprobes/kretprobe_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/kprobes/kretprobe_example.c +0 -0
index cbf16542d84e..ed79fd3d48fb 100644
@@ -35,7 +35,7 @@ struct my_data {
 	ktime_t entry_stamp;
 };
 
Quoted 10 lines
Quoted 8 lines
samples/kprobes/kretprobe_example.c +1 -1
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
 static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
 {
 	struct my_data *data;
Signature · 1 line
2.25.1

Hi all, can someone provide comments on this change.

Hi all, can someone please review this change. It has been not reviewed for quite some time.
_______________________________________________
Linux-kernel-mentees mailing list [email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

maintainer
#3 lore raw
Quoted 28 lines · On Sat, 7 Oct 2023 21:09:00 +0530 Atul Kumar Pant <[email protected]>…
Quoted 16 lines · Atul Kumar Pant
Quoted 15 lines · Atul Kumar Pant

Fixes typo in a function name.

---
 samples/kprobes/kretprobe_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/kprobes/kretprobe_example.c +0 -0
index cbf16542d84e..ed79fd3d48fb 100644
@@ -35,7 +35,7 @@ struct my_data {
 	ktime_t entry_stamp;
 };
 
Quoted 10 lines
Quoted 8 lines
samples/kprobes/kretprobe_example.c +1 -1
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
 static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
 {
 	struct my_data *data;
Signature · 1 line
2.25.1

Hi all, can someone provide comments on this change.

Quoted 2 lines

Hi all, can someone please review this change. It has been not reviewed for quite some time.

That's because trivial typos in comments are considered very low priority, and are usually only added (if they are ever added) if the maintainer has extra time, which may not be for a while.

-- Steve

#4 lore raw
Quoted 31 lines · On Mon, 9 Oct 2023 09:51:03 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 28 lines · On Sat, 7 Oct 2023 21:09:00 +0530 Atul Kumar Pant <[email protected]>…
Quoted 26 lines · Atul Kumar Pant
Quoted 23 lines · Atul Kumar Pant

Fixes typo in a function name.

---
 samples/kprobes/kretprobe_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/kprobes/kretprobe_example.c +1 -1
index cbf16542d84e..ed79fd3d48fb 100644
@@ -35,7 +35,7 @@ struct my_data {
 	ktime_t entry_stamp;
 };
 
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
 static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
 {
 	struct my_data *data;
Signature · 1 line
2.25.1

Hi all, can someone provide comments on this change.

Quoted 6 lines
Quoted 2 lines

Hi all, can someone please review this change. It has been not reviewed for quite some time.

That's because trivial typos in comments are considered very low priority, and are usually only added (if they are ever added) if the maintainer has extra time, which may not be for a while.

Anyway, let me pick this. I found this in my inbox now. :)

Thank you,

Quoted 2 lines

-- Steve

Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
#5 lore raw
Quoted 34 lines · Masami Hiramatsu
Quoted 31 lines · On Mon, 9 Oct 2023 09:51:03 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 28 lines · On Sat, 7 Oct 2023 21:09:00 +0530 Atul Kumar Pant <[email protected]>…
Quoted 26 lines · Atul Kumar Pant
Quoted 23 lines · Atul Kumar Pant

Fixes typo in a function name.

---
 samples/kprobes/kretprobe_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/kprobes/kretprobe_example.c +1 -1
index cbf16542d84e..ed79fd3d48fb 100644
@@ -35,7 +35,7 @@ struct my_data {
 	ktime_t entry_stamp;
 };
 
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
 static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
 {
 	struct my_data *data;
Signature · 1 line
2.25.1

Hi all, can someone provide comments on this change.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Hi all, can someone please review this change. It has been not reviewed for quite some time.

That's because trivial typos in comments are considered very low priority, and are usually only added (if they are ever added) if the maintainer has extra time, which may not be for a while.

Anyway, let me pick this. I found this in my inbox now. :)

Thank you. Sorry for the redundant emails for reviewing the change :)

Quoted 9 lines

Thank you,

Quoted 2 lines

-- Steve

Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#6 lore raw
In reply to Steven Rostedt
Quoted 31 lines · Steven Rostedt
Quoted 28 lines · On Sat, 7 Oct 2023 21:09:00 +0530 Atul Kumar Pant <[email protected]>…
Quoted 26 lines · Atul Kumar Pant
Quoted 23 lines · Atul Kumar Pant

Fixes typo in a function name.

---
 samples/kprobes/kretprobe_example.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/kprobes/kretprobe_example.c +1 -1
index cbf16542d84e..ed79fd3d48fb 100644
@@ -35,7 +35,7 @@ struct my_data {
 	ktime_t entry_stamp;
 };
 
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
 static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
 {
 	struct my_data *data;
Signature · 1 line
2.25.1

Hi all, can someone provide comments on this change.

Quoted 8 lines
Quoted 2 lines

Hi all, can someone please review this change. It has been not reviewed for quite some time.

That's because trivial typos in comments are considered very low priority, and are usually only added (if they are ever added) if the maintainer has extra time, which may not be for a while.

-- Steve

Thank you Steve for the response. I wasn't aware of this.