Skip to contentSkip to conversation

staging: rts5208: Fix checkpatch macro warnings

PATCH Superseded Soumya Negi 1 participant 2 messages Oct 12, 2023 – Oct 13, 2023 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover staging: rts5208: Fix checkpatch macro warnings

In the driver staging/rts5208, checkpatch.pl warns of possible precedence issues in the header rtsx.h because macro arguments are not parenthesized. This patch set handles the respective macros differently(as needed) in each patch to fix the warnings. Patches can be applied in any order.

Soumya Negi (2):
staging: rts5208: Refactor macros to static inline functions
staging: rts5208: Remove macros scsi_lock(), scsi_unlock()

 drivers/staging/rts5208/rtsx.c | 24 ++++++-------
 drivers/staging/rts5208/rtsx.h | 66 ++++++++++++++++++++--------------
 2 files changed, 52 insertions(+), 38 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Soumya Negi

In the driver staging/rts5208, checkpatch.pl warns of possible precedence issues in the header rtsx.h because macro arguments are not parenthesized. This patch set handles the respective macros differently(as needed) in each patch to fix the warnings. Patches can be applied in any order.

Quoted 7 lines

Soumya Negi (2):
staging: rts5208: Refactor macros to static inline functions
staging: rts5208: Remove macros scsi_lock(), scsi_unlock()

 drivers/staging/rts5208/rtsx.c | 24 ++++++-------
 drivers/staging/rts5208/rtsx.h | 66 ++++++++++++++++++++--------------
 2 files changed, 52 insertions(+), 38 deletions(-)

Please ignore this patch set. Its incomplete & the rest of the patches were not sent successfully. I have successfuly resent the complete patchset(unchanged) as v2 with an explanation after --- in the cover patch.

Quoted 3 lines
Signature · 1 line
2.17.1