Skip to contentSkip to conversation

staging: wlan-ng: remove helper function prism2sta_inf_handover()

PATCH In review Calvince Otieno 4 participants 7 messages Oct 13, 2023 – Oct 16, 2023 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: wlan-ng: remove helper function prism2sta_inf_handover()

prism2sta_inf_handover() function basically calls pr_debug() to print a literal string. This can be done by the parent function directly.

---
Patch version v2:
- Replace pr_debug() utility function with the module specific netdev_dbg()

 drivers/staging/wlan-ng/prism2sta.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/prism2sta.c +2 -1
index caeceb89c9fa..cf07cf04e20c 100644
@@ -1697,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
 	/* Dispatch */
 	switch (inf->infotype) {
 	case HFA384x_IT_HANDOVERADDR:
-		pr_debug("received infoframe:HANDOVER (unhandled)\n");
+		netdev_dbg(wlandev->netdev,
+				"received infoframe:HANDOVER (unhandled)\n");
 		break;
 	case HFA384x_IT_COMMTALLIES:
 		prism2sta_inf_tallies(wlandev, inf);
Signature · 1 line
Calvince Otieno
#1 lore raw

Hi Calvince,

...

drivers/staging/wlan-ng/prism2sta.c void prism2sta_ev_info(struct wlandevice *wlandev, · line 1701

Quoted 7 lines
drivers/staging/wlan-ng/prism2sta.c +2 -1
@@ -1697,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
 	/* Dispatch */
 	switch (inf->infotype) {
 	case HFA384x_IT_HANDOVERADDR:
-		pr_debug("received infoframe:HANDOVER (unhandled)\n");
+		netdev_dbg(wlandev->netdev,
+				"received infoframe:HANDOVER (unhandled)\n");

but then you generate this:

CHECK: Alignment should match open parenthesis #240: FILE: drivers/staging/wlan-ng/prism2sta.c:1701:
+ netdev_dbg(wlandev->netdev,
+ "received infoframe:HANDOVER (unhandled)\n");

total: 0 errors, 0 warnings, 1 checks, 9 lines checked

:-)

Make it a habit... before sending a patch check it with checkpatch, in order to be sure you are not introducing other checkpatch errors.

Don't rush... take your time, check your changes carefully; use checkpatch, compile test, run sparse, etc. Give others time to see your patch and comment.

Andi

#2 lore raw
In reply to Calvince Otieno
Quoted 7 lines · Calvince Otieno

prism2sta_inf_handover() function basically calls pr_debug() to print a literal string. This can be done by the parent function directly.

---
Patch version v2:
- Replace pr_debug() utility function with the module specific netdev_dbg()

This isn't a v2 patch, right? This patch assumes that we applied the v1 patch...

This patch is not white space damaged though so that's good.

regards,
dan carpenter

#3 lore raw
Quoted 10 lines · Dan Carpenter
Quoted 7 lines · Calvince Otieno

prism2sta_inf_handover() function basically calls pr_debug() to print a literal string. This can be done by the parent function directly.

---
Patch version v2:
- Replace pr_debug() utility function with the module specific netdev_dbg()

Quoted 9 lines

This isn't a v2 patch, right? This patch assumes that we applied the v1 patch...

This patch is not white space damaged though so that's good.

regards,
dan carpenter

Hello Dan,
Does this response mean that the patch was accepted?

--
Kind regards,
Calvince Otieno

#4 lore raw
Quoted 16 lines · Calvince Otieno
Quoted 15 lines · Dan Carpenter
Quoted 7 lines · Calvince Otieno

prism2sta_inf_handover() function basically calls pr_debug() to print a literal string. This can be done by the parent function directly.

---
Patch version v2:
- Replace pr_debug() utility function with the module specific netdev_dbg()

This isn't a v2 patch, right? This patch assumes that we applied the v1 patch...

This patch is not white space damaged though so that's good.

Quoted 7 lines
Quoted 4 lines

regards,
dan carpenter

Hello Dan,
Does this response mean that the patch was accepted?

No, sorry.

#5 lore raw
In reply to Calvince Otieno
Quoted 16 lines · Calvince Otieno
Quoted 15 lines · Dan Carpenter
Quoted 7 lines · Calvince Otieno

prism2sta_inf_handover() function basically calls pr_debug() to print a literal string. This can be done by the parent function directly.

---
Patch version v2:
- Replace pr_debug() utility function with the module specific netdev_dbg()

This isn't a v2 patch, right? This patch assumes that we applied the v1 patch...

This patch is not white space damaged though so that's good.

Quoted 7 lines
Quoted 4 lines

regards,
dan carpenter

Hello Dan,
Does this response mean that the patch was accepted?

Ugh... No, sorry. I suck at emails. White space damaged is not good. I left out the word not... :/

You need to figure out what's going on there. Some of your patches are not white space damaged so sometimes you're doing it right but here the spaces were replaced with tabs so it doesn't apply.

regards,
dan carpenter

#6 lore raw
Quoted 25 lines · Dan Carpenter
Quoted 16 lines · Calvince Otieno
Quoted 15 lines · Dan Carpenter
Quoted 7 lines · Calvince Otieno

prism2sta_inf_handover() function basically calls pr_debug() to print a literal string. This can be done by the parent function directly.

---
Patch version v2:
- Replace pr_debug() utility function with the module specific netdev_dbg()

This isn't a v2 patch, right? This patch assumes that we applied the v1 patch...

This patch is not white space damaged though so that's good.

Quoted 7 lines
Quoted 4 lines

regards,
dan carpenter

Hello Dan,
Does this response mean that the patch was accepted?

Quoted 6 lines

Ugh... No, sorry. I suck at emails. White space damaged is not good. I left out the word not... :/

You need to figure out what's going on there. Some of your patches are not white space damaged so sometimes you're doing it right but here the spaces were replaced with tabs so it doesn't apply.

Wow... I absolutely suck at writing emails and *reading emails*. This wasn't the white space damaged patch. This was the okay one.

However you sent a v2 patch in the wrong way. You just posted a fixup instead of resending the patch. You've sent v2 patches before but let me send you my blog link anyway...

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter