Skip to contentSkip to conversation

dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema

PATCH Applied Rob Herring 2 participants 3 messages Oct 16, 2023 – Oct 30, 2023

Subsystems (2)
Device tree bindings Arm Qualcomm mailing list
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema

The soundwire-controller.yaml schema already defines the form for devices in child nodes, so there's no need to do the same in the QCom controller binding. Add a $ref to the soundwire-controller.yaml schema and drop the child node schema.

Signed-off-by Rob Herring <[email protected]>
---
 .../bindings/soundwire/qcom,soundwire.yaml       | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)
Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml +4 -12
index 7d60a9654912..3591c8c49bfe 100644
@@ -209,17 +209,6 @@ properties:
   label:
     maxItems: 1
 
-patternProperties:
-  "^.*@[0-9a-f],[0-9a-f]$":
-    type: object
-    additionalProperties: true
-    description:
-      Child nodes for a standalone audio codec or speaker amplifier IC.
-      It has RX and TX Soundwire secondary devices.
-    properties:
-      compatible:
-        pattern: "^sdw[0-9a-f]{1}[0-9a-f]{4}[0-9a-f]{4}[0-9a-f]{2}$"
-
 required:
   - compatible
   - reg

@@ -240,7 +229,10 @@ oneOf:
   - required:
       - qcom,ports-sinterval
 
-additionalProperties: false
+allOf:
+  - $ref: soundwire-controller.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.42.0
author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring

The soundwire-controller.yaml schema already defines the form for devices in child nodes, so there's no need to do the same in the QCom controller binding. Add a $ref to the soundwire-controller.yaml schema and drop the child node schema.

Signed-off-by Rob Herring <[email protected]>
---
 .../bindings/soundwire/qcom,soundwire.yaml       | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

Applied, thanks!