Skip to contentSkip to conversation

ASoC: dt-bindings: tas5805m: Disallow undefined properties

PATCH In review Rob Herring 3 participants 4 messages Oct 16, 2023 – Oct 17, 2023

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: tas5805m: Disallow undefined properties

Device specific bindings should not allow undefined properties. This is accomplished in json-schema with 'additionalProperties: false'.

Examples should be last in the schema, so move additionalProperties up while we're here.

---
 Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/tas5805m.yaml +3 -2
index 63edf52f061c..12c41974274e 100644
@@ -37,6 +37,8 @@ properties:
       generated from TI's PPC3 tool.
     $ref: /schemas/types.yaml#/definitions/string
 
+additionalProperties: false
+
 examples:
   - |
     i2c {
@@ -52,5 +54,4 @@ examples:
                 ti,dsp-config-name = "mono_pbtl_48khz";
         };
     };
-
-additionalProperties: true
+...
Signature · 1 line
2.42.0
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rob Herring

Device specific bindings should not allow undefined properties. This is accomplished in json-schema with 'additionalProperties: false'.

Examples should be last in the schema, so move additionalProperties up while we're here.

Thanks,
Conor.

Quoted 28 lines
---
 Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/tas5805m.yaml +3 -2
index 63edf52f061c..12c41974274e 100644
@@ -37,6 +37,8 @@ properties:
       generated from TI's PPC3 tool.
     $ref: /schemas/types.yaml#/definitions/string
 
+additionalProperties: false
+
 examples:
   - |
     i2c {
@@ -52,5 +54,4 @@ examples:
                 ti,dsp-config-name = "mono_pbtl_48khz";
         };
     };
-
-additionalProperties: true
+...
Signature · 1 line
2.42.0
maintainer
#2 lore raw
Quoted 10 lines · Conor Dooley
Quoted 7 lines · Rob Herring

Device specific bindings should not allow undefined properties. This is accomplished in json-schema with 'additionalProperties: false'.

Examples should be last in the schema, so move additionalProperties up while we're here.

Rob, I don't have the original patch for this. It looks like whatever email troubles you were having are persisting - if there's anything else you've sent me I'm just unawaere of it.

maintainer
#3 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

Device specific bindings should not allow undefined properties. This is accomplished in json-schema with 'additionalProperties: false'.

Examples should be last in the schema, so move additionalProperties up while we're here.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: tas5805m: Disallow undefined properties

      commit: 086357275fc7635c5a2856c667b3d2f7604403fa

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark