Skip to contentSkip to conversation

imx7d-sdb-u-boot: Pass SPDX-License tag

PATCH In review Fabio Estevam 3 participants 9 messages Aug 8, 2023 – Oct 16, 2023

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 imx7d-sdb-u-boot: Pass SPDX-License tag

From: Fabio Estevam <[email protected]>

SPDX-License tag is missing and checkpatch complains about it.

Add the SPDX-License tag using the same one from imx7d-sdb.dts.

---
 arch/arm/dts/imx7d-sdb-u-boot.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/dts/imx7d-sdb-u-boot.dtsi +2 -0
index ac1d6e2e6480..818528c418f5 100644
@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+
 &fec2 {
 	status = "disable";
 };
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH 2/3 mx7dsabresd: Convert to watchdog driver model

From: Fabio Estevam <[email protected]>

Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset.

Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset.

---
 arch/arm/dts/imx7d-sdb-u-boot.dtsi | 12 ++++++++++++
 configs/mx7dsabresd_defconfig      |  3 +++
 2 files changed, 15 insertions(+)
arch/arm/dts/imx7d-sdb-u-boot.dtsi +12 -0
index 818528c418f5..2e234b6b5828 100644
@@ -1,5 +1,13 @@
 // SPDX-License-Identifier: GPL-2.0+ OR MIT
 
+/ {
+	wdt-reboot {
+		compatible = "wdt-reboot";
+		wdt = <&wdog1>;
+		bootph-pre-ram;
+	};
+};
+
 &fec2 {
 	status = "disable";
 };
@@ -58,3 +66,7 @@
 		>;
 	};
 };
+
+&wdog1 {
+	bootph-pre-ram;
+};
configs/mx7dsabresd_defconfig +3 -0
index 26e68d30d267..1c8105f44f28 100644
@@ -73,6 +73,8 @@ CONFIG_MXC_UART=y
 CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_SOFT_SPI=y
+CONFIG_SYSRESET=y
+CONFIG_SYSRESET_WATCHDOG=y
 CONFIG_IMX_THERMAL=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
@@ -85,4 +87,5 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0525
 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_IMX_WATCHDOG=y
 CONFIG_ERRNO_STR=y
Signature · 1 line
2.34.1
Reviewed-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] mx7dsabresd: Convert to watchdog driver model

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset.

Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset.

Awesome

#3 lore raw

PATCH 2/3 mx7dsabresd: Convert to watchdog driver model

In reply to Fabio Estevam
Quoted 7 lines

From: Fabio Estevam <[email protected]>
Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
author reviewer
#4 lore raw

PATCH 3/3 smegw01: Convert to watchdog driver model

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset.

Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset.

---
 arch/arm/dts/imx7d-smegw01-u-boot.dtsi | 13 +++++++++++++
 configs/smegw01_defconfig              |  3 +++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/dts/imx7d-smegw01-u-boot.dtsi
arch/arm/dts/imx7d-smegw01-u-boot.dtsi new file +13 -0
new file mode 100644
index 000000000000..cf7ba3a95817
@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/ {
+	wdt-reboot {
+		compatible = "wdt-reboot";
+		wdt = <&wdog1>;
+		bootph-pre-ram;
+	};
+};
+
+&wdog1 {
+	bootph-pre-ram;
+};
configs/smegw01_defconfig +3 -0
index 7f1b2bee8e16..a3d289eeca1a 100644
@@ -80,5 +80,8 @@ CONFIG_DM_REGULATOR_GPIO=y
 CONFIG_SPECIFY_CONSOLE_INDEX=y
 CONFIG_DM_SERIAL=y
 CONFIG_MXC_UART=y
+CONFIG_SYSRESET=y
+CONFIG_SYSRESET_WATCHDOG=y
 CONFIG_IMX_THERMAL=y
+CONFIG_IMX_WATCHDOG=y
 # CONFIG_CMD_BOOTEFI_BOOTMGR is not set
Signature · 1 line
2.34.1
Reviewed-by on v1 3/3
#5 lore raw

Re: [PATCH 3/3] smegw01: Convert to watchdog driver model

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset.

Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset.

#6 lore raw

PATCH 3/3 smegw01: Convert to watchdog driver model

In reply to Fabio Estevam
Quoted 7 lines

From: Fabio Estevam <[email protected]>
Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Reviewed-by on v1 1/3
#7 lore raw
In reply to Fabio Estevam
Quoted 16 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

SPDX-License tag is missing and checkpatch complains about it.

Add the SPDX-License tag using the same one from imx7d-sdb.dts.

---
  arch/arm/dts/imx7d-sdb-u-boot.dtsi | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/dts/imx7d-sdb-u-boot.dtsi +0 -0
index ac1d6e2e6480..818528c418f5 100644

arch/arm/dts/imx7d-sdb-u-boot.dtsi line 5

Quoted 5 lines
arch/arm/dts/imx7d-sdb-u-boot.dtsi +2 -0
@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+
  &fec2 {
  	status = "disable";
  };
#8 lore raw

PATCH 1/3 imx7d-sdb-u-boot: Pass SPDX-License tag

In reply to Fabio Estevam
Quoted 5 lines

From: Fabio Estevam <[email protected]>
SPDX-License tag is missing and checkpatch complains about it. Add the SPDX-License tag using the same one from imx7d-sdb.dts.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================