Skip to contentSkip to conversation

drm/msm/a6xx: add QMP dependency

PATCH Applied Arnd Bergmann 3 participants 4 messages Oct 16, 2023 – Dec 3, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/a6xx: add QMP dependency

From: Arnd Bergmann <[email protected]>

When QMP is in a loadable module, the A6xx GPU driver fails to link as built-in:

x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'

Add the usual dependency that still allows compiling without QMP but otherwise avoids the broken combination of options.

Fixes 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
---
 drivers/gpu/drm/msm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/msm/Kconfig +1 -0
index 6309a857ca312..ad70b611b44f0 100644
@@ -6,6 +6,7 @@ config DRM_MSM
 	depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
 	depends on COMMON_CLK
 	depends on IOMMU_SUPPORT
+	depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n
 	depends on QCOM_OCMEM || QCOM_OCMEM=n
 	depends on QCOM_LLCC || QCOM_LLCC=n
 	depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When QMP is in a loadable module, the A6xx GPU driver fails to link as built-in:

x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'

Quoted 6 lines

Add the usual dependency that still allows compiling without QMP but otherwise avoids the broken combination of options.

Fixes 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")

---

Right, thanks!

Konrad

Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When QMP is in a loadable module, the A6xx GPU driver fails to link as built-in:

x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'

Quoted 8 lines

Add the usual dependency that still allows compiling without QMP but otherwise avoids the broken combination of options.

Fixes 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
---
  drivers/gpu/drm/msm/Kconfig | 1 +
  1 file changed, 1 insertion(+)
Signature · 2 lines
With best wishes
Dmitry
#3 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

When QMP is in a loadable module, the A6xx GPU driver fails to link as built-in:

x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'

Add the usual dependency that still allows compiling without QMP but otherwise avoids the broken combination of options.

[...]

Applied, thanks!

[1/1] drm/msm/a6xx: add QMP dependency

      https://gitlab.freedesktop.org/lumag/msm/-/commit/96ab215b2d5e

Best regards,

Signature · 1 line
Dmitry Baryshkov <[email protected]>