dt-bindings: usb: vialab,vl817: remove reset-gpios from required list
Subsystems (2)
PATCH 1/1 dt-bindings: usb: vialab,vl817: remove reset-gpios from required list
The "reset-gpios" is optional in real case, for example reset pin is is hard wired to "high". And this fact is also reflected by the devm_gpio_get_optional() calling in driver code.
--- .../bindings/usb/thead,th1520-usb.yaml | 42 ++++++++++--------- .../devicetree/bindings/usb/vialab,vl817.yaml | 1 - 2 files changed, 23 insertions(+), 20 deletions(-)
Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml +23 -19
@@ -28,6 +28,10 @@ properties: ranges: true + thead,misc-syscon: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: a phandle to the misc system register controller syscon node. + '#address-cells': enum: [ 1, 2 ]
@@ -51,23 +55,23 @@ additionalProperties: false examples: - | - - usb { - compatible = "thead,th1520-usb"; - reg = <0xec03f000 0x1000>; - clocks = <&clk 1>, - <&clk 2>, - <&clk 3>, - <&clk 4>; - clock-names = "ref", "bus_early", "phy", "suspend"; - ranges; - #address-cells = <1>; - #size-cells = <1>; - - usb@e7040000 { - compatible = "snps,dwc3"; - reg = <0xe7040000 0x10000>; - interrupts = <68>; - dr_mode = "host"; - }; + usb@ec03f000 { + compatible = "thead,th1520-usb"; + reg = <0xec03f000 0x1000>; + thead,misc-syscon = <&misc_syscon>; + clocks = <&clk 1>, + <&clk 2>, + <&clk 3>, + <&clk 4>; + clock-names = "ref", "bus_early", "phy", "suspend"; + ranges; + #address-cells = <1>; + #size-cells = <1>; + + usb@e7040000 { + compatible = "snps,dwc3"; + reg = <0xe7040000 0x10000>; + interrupts = <68>; + dr_mode = "host"; + }; };
Documentation/devicetree/bindings/usb/vialab,vl817.yaml +0 -1
@@ -37,7 +37,6 @@ properties: required: - compatible - reg - - reset-gpios - vdd-supply - peer-hub
Signature · 1 line
2.40.1
Quoted 15 lines · Jisheng Zhang
The "reset-gpios" is optional in real case, for example reset pin is is hard wired to "high". And this fact is also reflected by the
devm_gpio_get_optional()calling in driver code.Signed-off-by Jisheng Zhang <[email protected]>--- .../bindings/usb/thead,th1520-usb.yaml | 42 ++++++++++--------- .../devicetree/bindings/usb/vialab,vl817.yaml | 1 - 2 files changed, 23 insertions(+), 20 deletions(-)Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml +0
-0
Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml properties: · line 33
Quoted 6 lines
Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml +3
-0@@ -28,6 +28,10 @@ properties: ranges: true + thead,misc-syscon: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: a phandle to the misc system register controller syscon node.
Either you combined two unrelated changes or this should be resets from reset-controller.
Best regards,
Krzysztof
Quoted 17 lines · Krzysztof Kozlowski
Quoted 16 lines · Jisheng Zhang
The "reset-gpios" is optional in real case, for example reset pin is is hard wired to "high". And this fact is also reflected by the
devm_gpio_get_optional()calling in driver code.Signed-off-by Jisheng Zhang <[email protected]>--- .../bindings/usb/thead,th1520-usb.yaml | 42 ++++++++++--------- .../devicetree/bindings/usb/vialab,vl817.yaml | 1 - 2 files changed, 23 insertions(+), 20 deletions(-)Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml +0
-0@@ -28,6 +28,10 @@ properties:
Quoted 8 lines
Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml properties: · line 33
Quoted 5 lines
Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml +3
-0ranges: true + thead,misc-syscon: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: a phandle to the misc system register controller syscon node.Either you combined two unrelated changes or this should be resets from reset-controller.
oops, this change isn't expected... I was working on TH1520 usb but add local changes step by step, but then found vl817 need to be patched. I forgot to reset TH1520 usb part. Sorry for noise. V2 will be sent out soon.