mm-make-__access_remote_vm-static.patch removed from -mm tree
The quilt patch titled
Subject: mm: make __access_remote_vm() static
has been removed from the -mm tree. Its filename was
mm-make-__access_remote_vm-static.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Lorenzo Stoakes <[email protected]>
Subject: mm: make __access_remote_vm() static
Date: Tue, 3 Oct 2023 00:14:51 +0100
Patch series "various improvements to the GUP interface", v2.
A series of fixes to simplify and improve the GUP interface with an eye to providing groundwork to future improvements:-
* __access_remote_vm() and access_remote_vm() are functionally identical, so make the former static such that in future we can potentially change the external-facing implementation details of this function.
* Extend is_valid_gup_args() to cover the missing FOLL_TOUCH case, and simplify things by defining INTERNAL_GUP_FLAGS to check against.
* Adjust __get_user_pages_locked() to explicitly treat a failure to pin any pages as an error in all circumstances other than FOLL_NOWAIT being specified, bringing it in line with the nommu implementation of this function.
* (With many thanks to Arnd who suggested this in the first instance) Update get_user_page_vma_remote() to explicitly only return a page or an error, simplifying the interface and avoiding the questionable IS_ERR_OR_NULL() pattern.
This patch (of 4):
access_remote_vm() passes through parameters to __access_remote_vm() directly, so remove the __access_remote_vm() function from mm.h and use access_remote_vm() in the one caller that needs it (ptrace_access_vm()).
This allows future adjustments to the GUP-internal __access_remote_vm() function while keeping the access_remote_vm() function stable.
---
include/linux/mm.h | 2 -- kernel/ptrace.c | 2 +- mm/memory.c | 4 ++-- mm/nommu.c | 4 ++-- 4 files changed, 5 insertions(+), 7 deletions(-)
include/linux/mm.h renamed from include/linux/mm.h~mm-make-__access_remote_vm-static +0 -2
@@ -2415,8 +2415,6 @@ extern int access_process_vm(struct task void *buf, int len, unsigned int gup_flags);extern int access_remote_vm (struct mm_struct *mm,unsigned long addr,void *buf,int len,unsigned int gup_flags); -extern int __access_remote_vm (struct mm_struct *mm,unsigned long addr, -void *buf,int len,unsigned int gup_flags); long get_user_pages_remote(struct mm_struct *mm, unsigned long start, unsigned long nr_pages,
kernel/ptrace.c renamed from kernel/ptrace.c~mm-make-__access_remote_vm-static +1 -1
@@ -59,7 +59,7 @@ int ptrace_access_vm(struct task_structreturn 0 ; } - ret =__access_remote_vm (mm, addr, buf, len, gup_flags); + ret =access_remote_vm (mm, addr, buf, len, gup_flags);mmput (mm);return ret;
mm/memory.c renamed from mm/memory.c~mm-make-__access_remote_vm-static +2 -2
@@ -5791,8 +5791,8 @@ EXPORT_SYMBOL_GPL(generic_access_phys);/* * Access another process' address space as given in mm. */ -int __access_remote_vm (struct mm_struct *mm,unsigned long addr,void *buf, -int len,unsigned int gup_flags) +static int __access_remote_vm (struct mm_struct *mm,unsigned long addr, +void *buf,int len,unsigned int gup_flags) {void *old_buf = buf;int write = gup_flags &FOLL_WRITE ;
mm/nommu.c renamed from mm/nommu.c~mm-make-__access_remote_vm-static +2 -2
@@ -1651,8 +1651,8 @@ vm_fault_t filemap_map_pages(struct vm_f }EXPORT_SYMBOL (filemap_map_pages); -int __access_remote_vm (struct mm_struct *mm,unsigned long addr,void *buf, -int len,unsigned int gup_flags) +static int __access_remote_vm (struct mm_struct *mm,unsigned long addr, +void *buf,int len,unsigned int gup_flags) {struct vm_area_struct *vma;int write = gup_flags &FOLL_WRITE ;
_
Patches currently in -mm which might be from [email protected] are