staging: sm750fb: Remove unused return values from functions
v2 cover staging: sm750fb: Remove unused return values from functions
Modifies the return type of different static functions to void and deletes unused return variables as the return value is being ignored in all subsequent function calls thus not useful to have a return type.
This improves code readability and maintainability.
Changes in v2:
- Ammend wording in cover letter.
- Drop variable 'ret' entirely as it is unused.
<[email protected]>, Dan Carpenter <[email protected]>
Dorcas AnonoLitunya (2):
staging: sm750fb: Remove unused return value in
display_control_adjust_sm750le()
staging: sm750fb: Remove unused return variable in
program_mode_registers()
drivers/staging/sm750fb/ddk750_mode.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
Signature · 1 line
2.42.0.345.gaab89be2eb
PATCH v2 1/2 staging: sm750fb: Remove unused return value in display_control_adjust_sm750le()
Modifies the return type of display_control_adjust_sm750le() to void from unsigned long as the return value is being ignored in all subsequent function calls.
This improves code readability and maintainability.
--- drivers/staging/sm750fb/ddk750_mode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_mode.c +1 -3
@@ -13,7 +13,7 @@* HW only supports 7 predefined pixel clocks, and clock select is * in bit 29:27 of Display Control register. */ -static unsigned long +static void display_control_adjust_sm750le (struct mode_parameter *mode_param,unsigned long disp_control) {
@@ -70,8 +70,6 @@ display_control_adjust_sm750le(struct mode_parameter *mode_param, disp_control |=DISPLAY_CTRL_CLOCK_PHASE ;poke32 (CRT_DISPLAY_CTRL , disp_control); - -return disp_control; }/* only timing related registers will be programed */
Signature · 1 line
2.42.0.345.gaab89be2eb
Greg Kroah-Hartman
maintainerRe: [PATCH v2 1/2] staging: sm750fb: Remove unused return value in display_control_adjust_sm750le()
Quoted 11 lines · Dorcas AnonoLitunya
Modifies the return type of
display_control_adjust_sm750le()to void from unsigned long as the return value is being ignored in all subsequent function calls.This improves code readability and maintainability.
Suggested-by Greg Kroah-Hartman <[email protected]>Signed-off-by Dorcas AnonoLitunya <[email protected]>--- drivers/staging/sm750fb/ddk750_mode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
This patch doesn't apply against my latest branch. Please rebase it and resend.
thanks,
greg k-h
Re: [PATCH v2 1/2] staging: sm750fb: Remove unused return value in display_control_adjust_sm750le()
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Dorcas AnonoLitunya
Modifies the return type of
display_control_adjust_sm750le()to void from unsigned long as the return value is being ignored in all subsequent function calls.This improves code readability and maintainability.
Suggested-by Greg Kroah-Hartman <[email protected]>Signed-off-by Dorcas AnonoLitunya <[email protected]>--- drivers/staging/sm750fb/ddk750_mode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Quoted 6 lines
This patch doesn't apply against my latest branch. Please rebase it and resend.
thanks,
greg k-h
Hi Greg,
Sorry for the delay. Was occupied on the project starter tasks. I have rebased the patch and resent it. Thanks!
Dorcas
PATCH v2 2/2 staging: sm750fb: Remove unused return variable in program_mode_registers()
In reply to Dorcas AnonoLitunyaDrops variable ret as it is unused in the code. This therefore modifies the return type of program_mode_registers() to void from int since the return value is being ignored in all function calls. This improves code readability and maintainability.
---
Changes in v2:
- Drop variable 'ret' entirely as it is unused.
<[email protected]>, Dan Carpenter <[email protected]>
drivers/staging/sm750fb/ddk750_mode.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/sm750fb/ddk750_mode.c +2 -6
@@ -73,10 +73,9 @@ display_control_adjust_sm750le(struct mode_parameter *mode_param, }/* only timing related registers will be programed */ -static int program_mode_registers (struct mode_parameter *mode_param, -struct pll_value *pll) +static void program_mode_registers (struct mode_parameter *mode_param, +struct pll_value *pll) { -int ret =0 ;int cnt =0 ;unsigned int tmp, reg;
@@ -199,10 +198,7 @@ static int program_mode_registers(struct mode_parameter *mode_param,break ;poke32 (PANEL_DISPLAY_CTRL , tmp | reg); } - }else { - ret =-1 ; } -return ret; }int ddk750_set_mode_timing (struct mode_parameter *parm,enum clock_type clock)
Signature · 1 line
2.42.0.345.gaab89be2eb