Skip to contentSkip to conversation

mmc: block: Use octal for file permissions

PATCH In review Edson Juliano Drosdeck 2 participants 2 messages Oct 19, 2023 – Oct 23, 2023 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: block: Use octal for file permissions

Octal permissions are preferred as stated in Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions with octal permissions when creating the files.

---
 drivers/mmc/core/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/core/block.c +1 -1
index b5b414a71e0b..edb653d8fbfa 100644
@@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
 
 	if (mmc_card_mmc(card)) {
 		md->ext_csd_dentry =
-			debugfs_create_file("ext_csd", S_IRUSR, root, card,
+			debugfs_create_file("ext_csd", 0400, root, card,
 					    &mmc_dbg_ext_csd_fops);
 	}
 }
Signature · 1 line
2.39.2
#1 lore raw
Quoted 6 lines · Edson Juliano Drosdeck

Octal permissions are preferred as stated in Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions with octal permissions when creating the files.

Thanks for your patch!

Replacing symbolic permissions with octal permissions makes sense to me. However, I don't want one patch per line that needs to be changed.

Instead, please go over all the files in drivers/mmc/core and fix all of them in one patch. Another patch can be done for drivers/mmc/hosts/*

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/core/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/core/block.c +1 -2
index b5b414a71e0b..edb653d8fbfa 100644
@@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
 
        if (mmc_card_mmc(card)) {
                md->ext_csd_dentry =
-                       debugfs_create_file("ext_csd", S_IRUSR, root, card,
+                       debugfs_create_file("ext_csd", 0400, root, card,
                                            &mmc_dbg_ext_csd_fops);
        }
 }
--

2.39.2