Skip to contentSkip to conversation

staging: media: atomisp: Removed duplicate comment and fixed comment format

PATCH RESEND In review Jonathan Bergh 2 participants 3 messages Oct 21, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: media: atomisp: Removed duplicate comment and fixed comment format

Fixed the following issues:
* Removed a duplicate comment
* Fixed up minor comment format issue

---
 drivers/staging/media/atomisp/i2c/gc2235.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/media/atomisp/i2c/gc2235.h +1 -4
index 55ea422291ba..ade28950db73 100644
@@ -74,9 +74,6 @@
 #define GC2235_COARSE_INTG_TIME_MIN 1
 #define GC2235_COARSE_INTG_TIME_MAX_MARGIN 6
 
-/*
- * GC2235 System control registers
- */
 /*
  * GC2235 System control registers
  */
@@ -167,7 +164,7 @@ enum gc2235_tok_type {
 	GC2235_TOK_MASK = 0xfff0
 };
 
-/**
+/*
  * struct gc2235_reg - MI sensor  register format
  * @type: type of the register
  * @reg: 8-bit offset to register
Signature · 1 line
2.34.1
#1 lore raw

Hi Jonathan,

Quoted 5 lines · Jonathan Bergh

Fixed the following issues:
* Removed a duplicate comment
* Fixed up minor comment format issue

Thank you for your patch, but please don't resend it every week.

I did see the original patch and it looks fine but I have not had any time to work in atomisp support recently and this does not seem like something which needs to get merged urgently.

I'll pick this up next time I have time to do a bunch of atomisp work.

Regards,

Hans

Quoted 27 lines
---
 drivers/staging/media/atomisp/i2c/gc2235.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/media/atomisp/i2c/gc2235.h +1 -4
index 55ea422291ba..ade28950db73 100644
@@ -74,9 +74,6 @@
 #define GC2235_COARSE_INTG_TIME_MIN 1
 #define GC2235_COARSE_INTG_TIME_MAX_MARGIN 6
 
-/*
- * GC2235 System control registers
- */
 /*
  * GC2235 System control registers
  */
@@ -167,7 +164,7 @@ enum gc2235_tok_type {
 	GC2235_TOK_MASK = 0xfff0
 };
 
-/**
+/*
  * struct gc2235_reg - MI sensor  register format
  * @type: type of the register
  * @reg: 8-bit offset to register
#2 lore raw
Quoted 8 lines · Hans de Goede

Hi Jonathan,

Quoted 5 lines · Jonathan Bergh

Fixed the following issues:
* Removed a duplicate comment
* Fixed up minor comment format issue

Hi Hans, thanks for the msg.

Quoted 3 lines

Thank you for your patch, but please don't resend it every week.

Apologies. I dont remember when i sent the original but I was cleaning up today and thought i would resend it. (I dont recall resending prior to today (?) but if so, apologies).

Quoted 7 lines

I did see the original patch and it looks fine but I have not had any time to work in atomisp support recently and this does not seem like something which needs to get merged urgently.

I'll pick this up next time I have time to do a bunch of atomisp work.

Yes, for sure, it was just a small thing.
Thanks Hans
br
Jonathan