Skip to contentSkip to conversation

Add DesignWare Mobile mmc driver

PATCH Superseded Jyan Chou 3 participants 10 messages Oct 18, 2023 – Oct 21, 2023

Subsystems (4)

v2 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Jyan Chou

author
#0 lore raw

v2 cover Add DesignWare Mobile mmc driver

We added Synopsys DesignWare mmc cmdq driver and also added Realtek mmc driver to make good use of it.

Jyan Chou (4):
mmc: solve DMA boundary limitation of CQHCI driver
mmc: Add Synopsys DesignWare mmc cmdq host driver
mmc: Add dw mobile mmc cmdq rtk driver
mmc: Add dt-bindings for realtek mmc driver

 .../bindings/mmc/realtek-dw-mshc.yaml         |  119 ++
 drivers/mmc/host/Kconfig                      |   22 +
 drivers/mmc/host/Makefile                     |    2 +
 drivers/mmc/host/cqhci-core.c                 |    8 +-
 drivers/mmc/host/cqhci.h                      |    2 +
 drivers/mmc/host/dw_mmc_cqe-rtk.c             |  998 ++++++++++
 drivers/mmc/host/dw_mmc_cqe-rtk.h             |  159 ++
 drivers/mmc/host/dw_mmc_cqe.c                 | 1619 +++++++++++++++++
 drivers/mmc/host/dw_mmc_cqe.h                 |  444 +++++
 9 files changed, 3372 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml
 create mode 100644 drivers/mmc/host/dw_mmc_cqe-rtk.c
 create mode 100644 drivers/mmc/host/dw_mmc_cqe-rtk.h
 create mode 100644 drivers/mmc/host/dw_mmc_cqe.c
 create mode 100644 drivers/mmc/host/dw_mmc_cqe.h
Signature · 1 line
2.42.0
author
#1 lore raw

PATCH v2 1/4 mmc: solve DMA boundary limitation of CQHCI driver

Due to synopsys data book's description, it had a limitation while using DMA that buffer size and start address must not exceed 128 MB.

We add an option setup_tran_desc to make tran_desc setting flexible.

---
v0 -> v1:
- Separate different patch supports into single patch.

v1 -> v2:
- Export cqhci_set_tran_desc for setting the descriptor's callback function.
---

---
 drivers/mmc/host/cqhci-core.c | 8 +++++++-
 drivers/mmc/host/cqhci.h      | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)
drivers/mmc/host/cqhci-core.c +7 -1
index b3d7d6d8d654..5560329d2a7d 100644
@@ -474,7 +474,7 @@ static int cqhci_dma_map(struct mmc_host *host, struct mmc_request *mrq)
 	return sg_count;
 }
 
-static void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
+void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
 				bool dma64)
 {
 	__le32 *attr = (__le32 __force *)desc;
@@ -495,6 +495,7 @@ static void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
 		dataddr[0] = cpu_to_le32(addr);
 	}
 }
+EXPORT_SYMBOL(cqhci_set_tran_desc);
 
 static int cqhci_prep_tran_desc(struct mmc_request *mrq,
 			       struct cqhci_host *cq_host, int tag)
@@ -516,6 +517,11 @@ static int cqhci_prep_tran_desc(struct mmc_request *mrq,
 
 	desc = get_trans_desc(cq_host, tag);
 
+	if (cq_host->ops->setup_tran_desc) {
+		cq_host->ops->setup_tran_desc(data, cq_host, desc, sg_count);
+		return 0;
+	}
+
 	for_each_sg(data->sg, sg, sg_count, i) {
 		addr = sg_dma_address(sg);
 		len = sg_dma_len(sg);
drivers/mmc/host/cqhci.h +2 -0
index 1a12e40a02e6..cb3dfb161c54 100644
@@ -289,6 +289,8 @@ struct cqhci_host_ops {
 				 u64 *data);
 	void (*pre_enable)(struct mmc_host *mmc);
 	void (*post_disable)(struct mmc_host *mmc);
+	void (*setup_tran_desc)(struct mmc_data *data,
+		struct cqhci_host *cq_host, u8 *desc, int sg_count);
 #ifdef CONFIG_MMC_CRYPTO
 	int (*program_key)(struct cqhci_host *cq_host,
 			   const union cqhci_crypto_cfg_entry *cfg, int slot);
Signature · 1 line
2.42.0
#2 lore raw

Re: [PATCH V2][1/4] mmc: solve DMA boundary limitation of CQHCI driver

kernel test robot noticed the following build warnings:

Hi Jyan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on ulf-hansson-mmc-mirror/next v6.6-rc6 next-20231018] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jyan-Chou/mmc-solve-DMA-boundary-limitation-of-CQHCI-driver/20231018-135532
base:   linus/master
patch link:    https://lore.kernel.org/r/20231018055326.18256-2-jyanchou%40realtek.com
patch subject: [PATCH V2][1/4] mmc: solve DMA boundary limitation of CQHCI driver
config: csky-randconfig-001-20231019 (https://download.01.org/0day-ci/archive/20231019/[email protected]/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231019/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

In file included from drivers/mmc/host/sdhci_am654.c:17:

>> drivers/mmc/host/cqhci.h:292:40: warning: 'struct mmc_data' declared inside parameter list will not be visible outside of this definition or declaration
     292 |         void (*setup_tran_desc)(struct mmc_data *data,
         |                                        ^~~~~~~~
--
>> drivers/mmc/host/cqhci-core.c:477:6: warning: no previous prototype for 'cqhci_set_tran_desc' [-Wmissing-prototypes]

477 | void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
| ^~~~~~~~~~~~~~~~~~~

vim +292 drivers/mmc/host/cqhci.h

281
282 struct cqhci_host_ops {
283 void (*dumpregs)(struct mmc_host *mmc);
284 void (*write_l)(struct cqhci_host *host, u32 val, int reg);
285 u32 (*read_l)(struct cqhci_host *host, int reg);
286 void (*enable)(struct mmc_host *mmc);
287 void (*disable)(struct mmc_host *mmc, bool recovery);
288 void (*update_dcmd_desc)(struct mmc_host *mmc, struct mmc_request *mrq,
289 u64 *data);
290 void (*pre_enable)(struct mmc_host *mmc);
291 void (*post_disable)(struct mmc_host *mmc);

 > 292		void (*setup_tran_desc)(struct mmc_data *data,

293 struct cqhci_host *cq_host, u8 *desc, int sg_count);
294 #ifdef CONFIG_MMC_CRYPTO
295 int (*program_key)(struct cqhci_host *cq_host,
296 const union cqhci_crypto_cfg_entry *cfg, int slot);
297 #endif
298 };
299

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#3 lore raw

Re: [PATCH V2][1/4] mmc: solve DMA boundary limitation of CQHCI driver

In reply to Jyan Chou
kernel test robot noticed the following build warnings:

Hi Jyan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc6 next-20231019]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jyan-Chou/mmc-solve-DMA-boundary-limitation-of-CQHCI-driver/20231018-135532
base:   linus/master
patch link:    https://lore.kernel.org/r/20231018055326.18256-2-jyanchou%40realtek.com
patch subject: [PATCH V2][1/4] mmc: solve DMA boundary limitation of CQHCI driver
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231019/[email protected]/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231019/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/mmc/host/cqhci-core.c:477:6: warning: no previous prototype for function 'cqhci_set_tran_desc' [-Wmissing-prototypes]
   void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
        ^

drivers/mmc/host/cqhci-core.c:477:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
^
static
1 warning generated.

vim +/cqhci_set_tran_desc +477 drivers/mmc/host/cqhci-core.c

476

 > 477	void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,

478 bool dma64)
479 {
480 __le32 *attr = (__le32 __force *)desc;
481
482 *attr = (CQHCI_VALID(1) |
483 CQHCI_END(end ? 1 : 0) |
484 CQHCI_INT(0) |
485 CQHCI_ACT(0x4) |
486 CQHCI_DAT_LENGTH(len));
487
488 if (dma64) {
489 __le64 *dataddr = (__le64 __force *)(desc + 4);
490
491 dataddr[0] = cpu_to_le64(addr);
492 } else {
493 __le32 *dataddr = (__le32 __force *)(desc + 4);
494
495 dataddr[0] = cpu_to_le32(addr);
496 }
497 }
498 EXPORT_SYMBOL(cqhci_set_tran_desc);
499

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
author
#4 lore raw

PATCH v2 2/4 mmc: Add Synopsys DesignWare mmc cmdq host driver

In reply to Jyan Chou

We implemented cmdq feature on Synopsys DesignWare mmc driver. The difference between dw_mmc.c and dw_mmc_cqe.c were distinct register definitions, mmc user flow and the addition of cmdq.

New version of User Guide had modify mmc driver's usage flow, we may need to renew code to precisely follow user guide.

More over, We added a wait status function to satisfy synopsys user guide's description, since this flow might be specific in synopsys host driver only.

—--
v0 -> v1:
- Seperate different support into single patch.
- Fix the compiler complains.

v1 -> v2:
- Remove dw_mci_cqe_set_tran_desc due to the duplicated function.
- Add ->pre_enable() / ->post_disable()
---

---
 drivers/mmc/host/Kconfig      |   13 +
 drivers/mmc/host/Makefile     |    1 +
 drivers/mmc/host/dw_mmc_cqe.c | 1619 +++++++++++++++++++++++++++++++++
 drivers/mmc/host/dw_mmc_cqe.h |  444 +++++++++
 4 files changed, 2077 insertions(+)
 create mode 100644 drivers/mmc/host/dw_mmc_cqe.c
 create mode 100644 drivers/mmc/host/dw_mmc_cqe.h
drivers/mmc/host/Kconfig +13 -0
index 159a3e9490ae..894b89a396bb 100644
@@ -762,6 +762,19 @@ config MMC_DW_PLTFM
 
 	  If unsure, say Y.
 
+config MMC_DW_CQE
+	tristate "Synopsys DesignWare Memory Card with CQE Interface"
+	depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
+	select MMC_CQHCI
+	help
+	 This selects support for the Synopsys DesignWare Mobile Storage IP
+	 block after JEDEC Standard version 5.1. Select this option for SD and
+	 MMC interfaces that use command queue.
+
+	 If you have a controller with this interface, say Y or M here.
+
+	 If unsure, say Y.
+
 config MMC_DW_BLUEFIELD
 	tristate "BlueField specific extensions for Synopsys DW Memory Card Interface"
 	depends on MMC_DW
drivers/mmc/host/Makefile +1 -0
index a693fa3d3f1c..23546b7b692e 100644
@@ -55,6 +55,7 @@ obj-$(CONFIG_MMC_DW_K3)		+= dw_mmc-k3.o
 obj-$(CONFIG_MMC_DW_PCI)	+= dw_mmc-pci.o
 obj-$(CONFIG_MMC_DW_ROCKCHIP)	+= dw_mmc-rockchip.o
 obj-$(CONFIG_MMC_DW_STARFIVE)	+= dw_mmc-starfive.o
+obj-$(CONFIG_MMC_DW_CQE)	+= dw_mmc_cqe.o
 obj-$(CONFIG_MMC_SH_MMCIF)	+= sh_mmcif.o
 obj-$(CONFIG_MMC_JZ4740)	+= jz4740_mmc.o
 obj-$(CONFIG_MMC_VUB300)	+= vub300.o
drivers/mmc/host/dw_mmc_cqe.c new file +1619 -0

1,619 lines not on this page · raw message

drivers/mmc/host/dw_mmc_cqe.h new file +444 -0

444 lines not on this page · raw message

Signature · 1 line
2.42.0
author
#5 lore raw

PATCH v2 3/4 mmc: Add dw mobile mmc cmdq rtk driver

In reply to Jyan Chou

Add Realtek mmc driver to make good use Synopsys
DesignWare mmc cmdq host driver.

---
v0 -> v1:
1. Seperate different support into single patch.
2. Fix the compiler complains.
---

---
 drivers/mmc/host/Kconfig          |   9 +
 drivers/mmc/host/Makefile         |   1 +
 drivers/mmc/host/dw_mmc_cqe-rtk.c | 998 ++++++++++++++++++++++++++++++
 drivers/mmc/host/dw_mmc_cqe-rtk.h | 159 +++++
 4 files changed, 1167 insertions(+)
 create mode 100644 drivers/mmc/host/dw_mmc_cqe-rtk.c
 create mode 100644 drivers/mmc/host/dw_mmc_cqe-rtk.h
drivers/mmc/host/Kconfig +9 -0
index 894b89a396bb..23544b226b8e 100644
@@ -775,6 +775,15 @@ config MMC_DW_CQE
 
 	 If unsure, say Y.
 
+config MMC_DW_CQE_RTK
+	tristate "Realtek Soc's specific extensions for Synopsys DW Memory Card Interface"
+	depends on MMC_DW_CQE
+	select REGULATOR_FIXED_VOLTAGE
+	help
+	 This selects support for Realtek SoC specific extensions to the
+	 Synopsys DesignWare Memory Card Interface driver. Select this option
+	 for platforms after RTD16xxb SoC's.
+
 config MMC_DW_BLUEFIELD
 	tristate "BlueField specific extensions for Synopsys DW Memory Card Interface"
 	depends on MMC_DW
drivers/mmc/host/Makefile +1 -0
index 23546b7b692e..fe4676202b95 100644
@@ -56,6 +56,7 @@ obj-$(CONFIG_MMC_DW_PCI)	+= dw_mmc-pci.o
 obj-$(CONFIG_MMC_DW_ROCKCHIP)	+= dw_mmc-rockchip.o
 obj-$(CONFIG_MMC_DW_STARFIVE)	+= dw_mmc-starfive.o
 obj-$(CONFIG_MMC_DW_CQE)	+= dw_mmc_cqe.o
+obj-$(CONFIG_MMC_DW_CQE_RTK)    += dw_mmc_cqe-rtk.o
 obj-$(CONFIG_MMC_SH_MMCIF)	+= sh_mmcif.o
 obj-$(CONFIG_MMC_JZ4740)	+= jz4740_mmc.o
 obj-$(CONFIG_MMC_VUB300)	+= vub300.o
drivers/mmc/host/dw_mmc_cqe-rtk.c new file +998 -0

998 lines not on this page · raw message

drivers/mmc/host/dw_mmc_cqe-rtk.h new file +159 -0

159 lines not on this page · raw message

Signature · 1 line
2.42.0
author
#6 lore raw

PATCH v2 4/4 mmc: Add dt-bindings for realtek mmc driver

In reply to Jyan Chou

Document the device-tree bindings for Realtek SoCs mmc driver.

---
v0 -> v2:
- Add dt-binding.
---

---
 .../bindings/mmc/realtek-dw-mshc.yaml         | 119 ++++++++++++++++++
 1 file changed, 119 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml
Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml new file +119 -0
new file mode 100644
index 000000000000..f398a595c5c5
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/realtek-dw-mshc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek designware mobile storage host controller
+
+description:
+  Realtek uses the Synopsys designware mobile storage host controller
+  to interface a SoC with storage medium. This file documents the Realtek
+  specific extensions.
+
+allOf:
+  - $ref: synopsys-dw-mshc-common.yaml#
+
+maintainers:
+  - Jyan Chou <[email protected]>
+
+# Everything else is described in the common file
+properties:
+  compatible:
+    enum:
+      - realtek,rtd-dw-cqe-emmc
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 2
+    maxItems: 4
+    description:
+      Handle to "biu" and "ciu" clocks for the bus interface unit clock and
+      the card interface unit clock.
+
+  clock-names:
+    minItems: 2
+    items:
+      - const: biu
+      - const: ciu
+      - const: vp0
+      - const: vp1
+    description:
+      "vp0" and "vp1" are used to control the clock phases.
+
+  power-domains:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: reset
+
+  speed-step:
+    maxItems: 1
+    description:
+	"speed-step" represents the bus speed mode of emmc. "3" means HS400,
+	"2" means HS200, "0" means HS.
+
+  pinctrl-names:
+    maxItems: 10
+    items:
+      - const: default
+      - const: sdr50
+      - const: ddr50
+      - const: hs200
+      - const: hs400
+      - const: tune0
+      - const: tune1
+      - const: tune2
+      - const: tune3
+      - const: tune4
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - pinctrl-names
+  - pinctrl
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    emmc: emmc@12000 {
+        compatible = "realtek,rtd-dw-cqe-emmc";
+        reg = <0x00012000 0x00600>,
+		<0x00012180 0x00060>;
+        reg-names = "emmc","cqhci";
+        interrupts = <0 42 4>;
+        clocks = <&cc RTD1319D_CRT_CLK_EN_EMMC>,
+		<&cc RTD1319D_CRT_CLK_EN_EMMC_IP>,
+                <&cc RTD1319D_CRT_PLL_EMMC_VP0>,
+                <&cc RTD1319D_CRT_PLL_EMMC_VP1>;
+        clock-names = "biu", "ciu", "vp0", "vp1";
+        clock-freq-min-max = <300000 400000000>;
+        clock-frequency = <400000>;
+        vmmc-supply = <&reg_vcc1v8>;
+        resets = <&cc RTD1319D_CRT_RSTN_EMMC>;
+        reset-names = "reset";
+        speed-step = <3>;
+        cqe = <1>;
+        pinctrl-names = "default", "sdr50", "ddr50", "hs200", "hs400", "tune0", "tune1", "tune2", "tune3", "tune4";
+	pinctrl-0 = <&emmc_pins_sdr50>;
+        pinctrl-1 = <&emmc_pins_sdr50>;
+        pinctrl-2 = <&emmc_pins_ddr50>;
+        pinctrl-3 = <&emmc_pins_hs200>;
+        pinctrl-4 = <&emmc_pins_hs400>;
+        pinctrl-5 = <&emmc_pins_tune0>;
+	pinctrl-6 = <&emmc_pins_tune1>;
+	pinctrl-7 = <&emmc_pins_tune2>;
+	pinctrl-8 = <&emmc_pins_tune3>;
+	pinctrl-9 = <&emmc_pins_tune4>;
+        };
Signature · 1 line
2.42.0
#7 lore raw

Re: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver

Quoted 3 lines · Jyan Chou

Document the device-tree bindings for Realtek SoCs mmc driver.

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching.

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Also, coding style of your example is messy.

Best regards,
Krzysztof

#8 lore raw

RE: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver

Hi Krzysztof,

Quoted 2 lines

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching.
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Thanks for your remind. We had modified our code and resend new patches.

Quoted 2 lines

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the > patch to be tested. Also, coding style of your example is messy.

It was our mistake that didn't check dt-bindings accurately. We had corrected it and resend to all necessary To/Cc entries. Thanks.

Best regards,
Jyan

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Wednesday, October 18, 2023 10:25 PM
To: Jyan Chou [周芷安] <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver

External mail.

Quoted 3 lines · Jyan Chou

Document the device-tree bindings for Realtek SoCs mmc driver.

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching.

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Also, coding style of your example is messy.

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver

In reply to Jyan Chou
kernel test robot noticed the following build warnings:

Hi Jyan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on ulf-hansson-mmc-mirror/next linus/master v6.6-rc6 next-20231020] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jyan-Chou/mmc-Add-dt-bindings-for-realtek-mmc-driver/20231018-135538
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20231018055326.18256-5-jyanchou%40realtek.com
patch subject: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231021/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

dtcheck warnings: (new ones prefixed by >>)

>> Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml:46:7: [error] string value is redundantly quoted with any quotes (quoted-strings)
>> Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml:46:13: [error] syntax error: expected <block end>, but found '<scalar>' (syntax)
--
>> Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml:46:13: did not find expected key
--
>> Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: ignoring, error parsing file

vim +46 Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml

     8	
     9	description:
    10	  Realtek uses the Synopsys designware mobile storage host controller
    11	  to interface a SoC with storage medium. This file documents the Realtek
    12	  specific extensions.
    13	
    14	allOf:
    15	  - $ref: synopsys-dw-mshc-common.yaml#
    16	
    17	maintainers:
    18	  - Jyan Chou <[email protected]>
    19	
    20	# Everything else is described in the common file
    21	properties:
    22	  compatible:
    23	    enum:
    24	      - realtek,rtd-dw-cqe-emmc
    25	  reg:
    26	    maxItems: 1
    27	
    28	  interrupts:
    29	    maxItems: 1
    30	
    31	  clocks:
    32	    minItems: 2
    33	    maxItems: 4
    34	    description:
    35	      Handle to "biu" and "ciu" clocks for the bus interface unit clock and
    36	      the card interface unit clock.
    37	
    38	  clock-names:
    39	    minItems: 2
    40	    items:
    41	      - const: biu
    42	      - const: ciu
    43	      - const: vp0
    44	      - const: vp1
    45	    description:
  > 46	      "vp0" and "vp1" are used to control the clock phases.
    47	
    48	  power-domains:
    49	    maxItems: 1
    50	
    51	  resets:
    52	    maxItems: 1
    53	
    54	  reset-names:
    55	    const: reset
    56	
    57	  speed-step:
    58	    maxItems: 1
    59	    description:
    60		"speed-step" represents the bus speed mode of emmc. "3" means HS400,
    61		"2" means HS200, "0" means HS.
    62	
    63	  pinctrl-names:
    64	    maxItems: 10
    65	    items:
    66	      - const: default
    67	      - const: sdr50
    68	      - const: ddr50
    69	      - const: hs200
    70	      - const: hs400
    71	      - const: tune0
    72	      - const: tune1
    73	      - const: tune2
    74	      - const: tune3
    75	      - const: tune4
    76	
    77	required:
    78	  - compatible
    79	  - reg
    80	  - interrupts
    81	  - clocks
    82	  - clock-names
    83	  - pinctrl-names
    84	  - pinctrl
    85	
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki