staging: greybus: avoid macro argument precedence issues
PATCH 1/1 staging: greybus: avoid macro argument precedence issues
Adhere to linux coding style, added parentheses around macro argument 'gcam'.
CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid precedence issues
--- drivers/staging/greybus/camera.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/greybus/camera.c +3 -3
@@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)#define GB_CAMERA_MAX_SETTINGS_SIZE 8192 -#define gcam_dbg(gcam, format...) dev_dbg(&gcam->bundle->dev, format) -#define gcam_info(gcam, format...) dev_info(&gcam->bundle->dev, format) -#define gcam_err(gcam, format...) dev_err(&gcam->bundle->dev, format) +#define gcam_dbg(gcam, format...) dev_dbg(&(gcam)->bundle->dev, format) +#define gcam_info(gcam, format...) dev_info(&(gcam)->bundle->dev, format) +#define gcam_err(gcam, format...) dev_err(&(gcam)->bundle->dev, format) static int gb_camera_operation_sync_flags(struct gb_connection *connection, int type, unsigned int flags,
Signature · 1 line
2.25.1
Greg Kroah-Hartman
maintainerQuoted 15 lines · Nandha Kumar Singaram
Adhere to linux coding style, added parentheses around macro argument 'gcam'.
CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid precedence issuesSigned-off-by Nandha Kumar Singaram <[email protected]>--- drivers/staging/greybus/camera.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/greybus/camera.c +0
-0
drivers/staging/greybus/camera.c static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt) · line 185
Quoted 9 lines
drivers/staging/greybus/camera.c +3
-3@@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)#define GB_CAMERA_MAX_SETTINGS_SIZE 8192 -#define gcam_dbg(gcam, format...) dev_dbg(&gcam->bundle->dev, format) -#define gcam_info(gcam, format...) dev_info(&gcam->bundle->dev, format) -#define gcam_err(gcam, format...) dev_err(&gcam->bundle->dev, format) +#define gcam_dbg(gcam, format...) dev_dbg(&(gcam)->bundle->dev, format) +#define gcam_info(gcam, format...) dev_info(&(gcam)->bundle->dev, format) +#define gcam_err(gcam, format...) dev_err(&(gcam)->bundle->dev, format)
Sorry, but checkpatch is wrong here, this is not a problem at all. Look at what you changed and think about if the macro argument could actually be anything other than a pointer.
thanks,
greg k-h
Quoted 30 lines · Greg Kroah-Hartman
Quoted 15 lines · Nandha Kumar Singaram
Adhere to linux coding style, added parentheses around macro argument 'gcam'.
CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid precedence issuesSigned-off-by Nandha Kumar Singaram <[email protected]>--- drivers/staging/greybus/camera.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/greybus/camera.c +0
-0drivers/staging/greybus/camera.c static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt) · line 185
Quoted 9 lines
drivers/staging/greybus/camera.c +3
-3@@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)#define GB_CAMERA_MAX_SETTINGS_SIZE 8192 -#define gcam_dbg(gcam, format...) dev_dbg(&gcam->bundle->dev, format) -#define gcam_info(gcam, format...) dev_info(&gcam->bundle->dev, format) -#define gcam_err(gcam, format...) dev_err(&gcam->bundle->dev, format) +#define gcam_dbg(gcam, format...) dev_dbg(&(gcam)->bundle->dev, format) +#define gcam_info(gcam, format...) dev_info(&(gcam)->bundle->dev, format) +#define gcam_err(gcam, format...) dev_err(&(gcam)->bundle->dev, format)Sorry, but checkpatch is wrong here, this is not a problem at all. Look at what you changed and think about if the macro argument could actually be anything other than a pointer.
Quoted 3 lines
thanks,
greg k-h
Thanks, I will check it out.
Regards,
Nandha Kumar