Skip to contentSkip to conversation

media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"

PATCH Applied Rob Herring 3 participants 5 messages Oct 20, 2023 – Oct 30, 2023

Subsystems (3)
Device tree bindings Media (V4L/DVB) TI fpd-link drivers
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"

Every DT property needs a type defined, but "i2c-alias" is missing any type definition. It's a "uint32", so add a type reference.

Fixes 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -0
index 289737721c2c..0b71e6f911a8 100644
@@ -69,6 +69,7 @@ properties:
             maxItems: 1
 
           i2c-alias:
+            $ref: /schemas/types.yaml#/definitions/uint32
             description:
               The I2C address used for the serializer. Transactions to this
               address on the I2C bus where the deserializer resides are
Signature · 1 line
2.42.0
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Rob Herring

Every DT property needs a type defined, but "i2c-alias" is missing any type definition. It's a "uint32", so add a type reference.

Fixes 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
Signed-off-by Rob Herring <[email protected]>
Acked-by Conor Dooley <[email protected]>

Thanks,
Conor.

Quoted 19 lines
---
 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -0
index 289737721c2c..0b71e6f911a8 100644
@@ -69,6 +69,7 @@ properties:
             maxItems: 1
 
           i2c-alias:
+            $ref: /schemas/types.yaml#/definitions/uint32
             description:
               The I2C address used for the serializer. Transactions to this
               address on the I2C bus where the deserializer resides are
Signature · 1 line
2.42.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring

Hi Rob,

Thank you for the patch.

Quoted 5 lines · Rob Herring

Every DT property needs a type defined, but "i2c-alias" is missing any type definition. It's a "uint32", so add a type reference.

Fixes 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
Signed-off-by Rob Herring <[email protected]>

This is something I should have paid more attention when reviewing the bindings. I'll try to keep it in mind for the future.

Reviewed-by Laurent Pinchart <[email protected]>
Quoted 16 lines
---
 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -0
index 289737721c2c..0b71e6f911a8 100644
@@ -69,6 +69,7 @@ properties:
             maxItems: 1
 
           i2c-alias:
+            $ref: /schemas/types.yaml#/definitions/uint32
             description:
               The I2C address used for the serializer. Transactions to this
               address on the I2C bus where the deserializer resides are
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#3 lore raw
Quoted 6 lines · Laurent Pinchart

Hi Rob,

Thank you for the patch.

On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:

Quoted 8 lines
Quoted 5 lines

Every DT property needs a type defined, but "i2c-alias" is missing any type definition. It's a "uint32", so add a type reference.

Fixes 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
Signed-off-by Rob Herring <[email protected]>

This is something I should have paid more attention when reviewing the bindings. I'll try to keep it in mind for the future.

No need, the tools will check for you now. :)

But the same property defined multiple times is not yet checked

Quoted 1 line
Reviewed-by Laurent Pinchart <[email protected]>

Thanks.

Rob

author maintainer Applied
#4 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

Every DT property needs a type defined, but "i2c-alias" is missing any type definition. It's a "uint32", so add a type reference.

Fixes 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks!