Skip to contentSkip to conversation

i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR

PATCH Applied Jacob Keller 2 participants 2 messages Oct 23, 2023 – Oct 25, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR

From: Ivan Vecera <[email protected]>

The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one.

Fixes 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722")
---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_txrx.c +1 -1
index 50c70a8e470a..b047c587629b 100644
@@ -2854,7 +2854,7 @@ int i40e_napi_poll(struct napi_struct *napi, int budget)
 		return budget;
 	}
 
-	if (vsi->back->flags & I40E_TXR_FLAGS_WB_ON_ITR)
+	if (q_vector->tx.ring[0].flags & I40E_TXR_FLAGS_WB_ON_ITR)
 		q_vector->arm_wb_state = false;
 
 	/* Exit the polling mode, but don't re-enable interrupts if stack might

base-commit: 7798b59409c345d4a6034a4326bceb9f7e2e8b58

Signature · 1 line
2.41.0
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Mon, 23 Oct 2023 14:27:14 -0700 you wrote:

From: Ivan Vecera <[email protected]>

The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one.

Fixes 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722")

[...]

Here is the summary with links:
- [net] i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR

    https://git.kernel.org/netdev/net/c/77a8c982ff0d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html