RDMA/core: Remove NULL check before dev_{put, hold}
Subsystems (2)
PATCH 1/1 RDMA/core: Remove NULL check before dev_{put, hold}
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning:
./drivers/infiniband/core/nldev.c:375:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
--- drivers/infiniband/core/nldev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/core/nldev.c +1 -2
@@ -371,8 +371,7 @@ static int fill_port_info(struct sk_buff *msg, } out: -if (netdev) -dev_put (netdev); +dev_put (netdev);return ret; }
Signature · 1 line
2.20.1.7.g153144c
Quoted 4 lines · Yang Li
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning:
Quoted 8 lines
./drivers/infiniband/core/nldev.c:375:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/infiniband/core/nldev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
I added the following hunk and applied the patch.
drivers/infiniband/core/lag.c +1 -2
@@ -102,8 +102,7 @@ static struct net_device *rdma_get_xmit_slave_udp(struct ib_device *device,void rdma_lag_put_ah_roce_slave (struct net_device *xmit_slave) { -if (xmit_slave) -dev_put (xmit_slave); +dev_put (xmit_slave); } struct net_device *rdma_lag_get_ah_roce_slave(struct ib_device *device,
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c +4 -8
@@ -1021,10 +1021,8 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,pvrdma_free_irq (dev);pci_free_irq_vectors (pdev); err_free_cq_ring: -if (dev->netdev) { -dev_put (dev->netdev); - dev->netdev =NULL ; - } +dev_put (dev->netdev); + dev->netdev =NULL ;pvrdma_page_dir_cleanup (dev, &dev->cq_pdir); err_free_async_ring:pvrdma_page_dir_cleanup (dev, &dev->async_pdir);
@@ -1064,10 +1062,8 @@ static void pvrdma_pci_remove(struct pci_dev *pdev)flush_workqueue (event_wq); -if (dev->netdev) { -dev_put (dev->netdev); - dev->netdev =NULL ; - } +dev_put (dev->netdev); + dev->netdev =NULL ;/* Unregister ib device */ ib_unregister_device (&dev->ib_dev);
drivers/infiniband/ulp/ipoib/ipoib_main.c +1 -2
@@ -2005,8 +2005,7 @@ static void ipoib_ndo_uninit(struct net_device *dev) priv->wq =NULL ; } -if (priv->parent) -dev_put (priv->parent); +dev_put (priv->parent); }static int ipoib_set_vf_link_state (struct net_device *dev,int vf,int link_state)
Quoted 18 lines
drivers/infiniband/core/nldev.c +1
-2@@ -371,8 +371,7 @@ static int fill_port_info(struct sk_buff *msg, } out: -if (netdev) -dev_put (netdev); +dev_put (netdev);return ret; }Signature · 1 line
2.20.1.7.g153144c
Leon Romanovsky
AppliedQuoted 8 lines · Yang Li
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning:
./drivers/infiniband/core/nldev.c:375:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
[...]
Applied, thanks!
[1/1] RDMA/core: Remove NULL check before dev_{put, hold}
https://git.kernel.org/rdma/rdma/c/7a1c2abf9a2be7
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>