Skip to contentSkip to conversation

vgacon: fix mips/sibyte build regression

PATCH In review Arnd Bergmann 3 participants 3 messages Oct 24, 2023 – Oct 25, 2023 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vgacon: fix mips/sibyte build regression

From: Arnd Bergmann <[email protected]>

The conversion to vgacon_register_screen() was missing an #include statement for the swarm board:

arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]

Fixes 555624c0d10b vgacon: clean up global screen_info instances
---
 arch/mips/sibyte/swarm/setup.c | 1 +
 1 file changed, 1 insertion(+)
arch/mips/sibyte/swarm/setup.c +1 -0
index 74e7c242b690..38c90b5e8754 100644
@@ -13,6 +13,7 @@
 #include <linux/memblock.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/console.h>
 #include <linux/screen_info.h>
 #include <linux/initrd.h>
 
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw

Arnd Bergmann <[email protected]> writes:

Hello Arnd,

Quoted 5 lines

From: Arnd Bergmann <[email protected]>

The conversion to vgacon_register_screen() was missing an #include statement for the swarm board:

Quoted 7 lines

arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]

Fixes 555624c0d10b vgacon: clean up global screen_info instances

---

Loos good to me.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The conversion to vgacon_register_screen() was missing an #include statement for the swarm board:

arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]

Quoted 7 lines
Fixes 555624c0d10b vgacon: clean up global screen_info instances
---
  arch/mips/sibyte/swarm/setup.c | 1 +
  1 file changed, 1 insertion(+)