dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa)

PATCH Superseded Luka Panio 3 participants 4 messages Oct 24, 2023 – Nov 20, 2023

Subsystems (3)

Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support

lore

Share & tools

lore

Luka Panio

author

2023-10-24 06:38 UTC #0 lore raw

PATCH v9 1/2 dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa)

Add a compatible for Xiaomi Pad 6.

Acked-by Conor Dooley <[email protected]>

Signed-off-by Luka Panio <[email protected]>

---
v2:
Update commit message

v3:
Update commit message

v4:
Update commit message

v5:
Update commit message

v6:
Update commit message

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Documentation/devicetree/bindings/arm/qcom.yaml +1 -0

index adbfaea32343..1bfae1b237d2 100644
@@ -965,6 +965,7 @@ properties:
               - sony,pdx203-generic
               - sony,pdx206-generic
               - xiaomi,elish
+              - xiaomi,pipa
           - const: qcom,sm8250
 
       - items:

Signature · 1 line

2.42.0

Luka Panio

author

2023-10-24 06:38 UTC #1 lore raw

PATCH v9 2/2 arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.

Signed-off-by Luka Panio <[email protected]>

---
v2:
Update commit message. Drop reserved gpio's as this device in reality do not have gpio, and pins are not protected.

v3:
Update commit message.

v4:
Update commit message.

v5:
Update commit message.

v6:
Update commit message.

v7:
Fix typo in "chassis-type", remove useless newlines, update license

v8:
Set real name in arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts

v9:
Update license

---
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../boot/dts/qcom/sm8250-xiaomi-pipa.dts      | 623 ++++++++++++++++++
 2 files changed, 624 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts

arch/arm64/boot/dts/qcom/Makefile +1 -0

index 2cca20563a1d..41ab333d1f81 100644
@@ -208,6 +208,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx203.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx206.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-elish-boe.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-elish-csot.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-pipa.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-hdk.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-microsoft-surface-duo2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-mtp.dtb

arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts new file +623 -0

623 lines not on this page · raw message

Signature · 1 line

2.42.0

Krzysztof Kozlowski

Acked-by on v9 2/2

2023-10-24 07:35 UTC #2 lore raw

Re: [PATCH v9 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

Quoted 5 lines · Luka Panio

Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
Signed-off-by Luka Panio <[email protected]>
---
v2:

Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Konrad Dybcio

Acked-by on v9 2/2

2023-11-20 14:30 UTC #3 lore raw

Re: [PATCH v9 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

In reply to Luka Panio

Quoted 4 lines · Luka Panio

Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
Signed-off-by Luka Panio <[email protected]>
---

[...]

arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts line 93

Quoted 6 lines

arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts new file +6 -0
+
+	gpio_keys: gpio-keys {
+		compatible = "gpio-keys";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&vol_up_n>;

property-n
property-names

other than that lgtm

Acked-by Konrad Dybcio <[email protected]>

Konrad