staging: greybus: Coding style cleanup patches
Subsystems (3)
v2 cover staging: greybus: Coding style cleanup patches
This patchset performs code cleanup in greybus driver as per linux coding style and may be applied in any sequence.
v2: Ammended wording in subject line for all the patches
Suggested by Greg Kroah-Hartman <[email protected]>
Nandha Kumar Singaram (3):
staging: greybus: camera: Alignment should match open parenthesis
staging: greybus: camera: Modify lines end with a '('
staging: greybus: bootrom: fixed prefer using ftrace warning
drivers/staging/greybus/bootrom.c | 2 -- drivers/staging/greybus/camera.c | 13 ++++++------- 2 files changed, 6 insertions(+), 9 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/3 staging: greybus: camera: Alignment should match open parenthesis
Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis
--- drivers/staging/greybus/camera.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/greybus/camera.c +5 -5
@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection, }static int gb_camera_get_max_pkt_size (struct gb_camera *gcam, -struct gb_camera_configure_streams_response *resp) +struct gb_camera_configure_streams_response *resp) {unsigned int max_pkt_size =0 ;unsigned int i;
@@ -378,8 +378,8 @@ struct ap_csi_config_request {#define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000Ustatic int gb_camera_setup_data_connection (struct gb_camera *gcam, -struct gb_camera_configure_streams_response *resp, -struct gb_camera_csi_params *csi_params) +struct gb_camera_configure_streams_response *resp, +struct gb_camera_csi_params *csi_params) {struct ap_csi_config_request csi_cfg;struct gb_connection *conn;
@@ -783,8 +783,8 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len) }static int gb_camera_op_configure_streams (void *priv,unsigned int *nstreams, -unsigned int *flags,struct gb_camera_stream *streams, -struct gb_camera_csi_params *csi_params) +unsigned int *flags,struct gb_camera_stream *streams, +struct gb_camera_csi_params *csi_params) {struct gb_camera *gcam = priv;struct gb_camera_stream_config *gb_streams;
Signature · 1 line
2.25.1
Re: [PATCH v2 1/3] staging: greybus: camera: Alignment should match open parenthesis
Quoted 2 lines · Nandha Kumar Singaram
Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesis
Generally, the result of this patch in isolation looks OK. But when you compare it with your next patch, what you're doing here becomes inconsistent with the indentation used for the function arguments there.
There is value in consistency as advocated by checkpatch, but there's also value in consistency within a single source file.
I'd stay away from these white space changes.
-Alex
Quoted 40 lines
Signed-off-by Nandha Kumar Singaram <[email protected]>--- drivers/staging/greybus/camera.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/staging/greybus/camera.c +5
-5@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection, }static int gb_camera_get_max_pkt_size (struct gb_camera *gcam, -struct gb_camera_configure_streams_response *resp) +struct gb_camera_configure_streams_response *resp) {unsigned int max_pkt_size =0 ;unsigned int i;@@ -378,8 +378,8 @@ struct ap_csi_config_request {#define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000Ustatic int gb_camera_setup_data_connection (struct gb_camera *gcam, -struct gb_camera_configure_streams_response *resp, -struct gb_camera_csi_params *csi_params) +struct gb_camera_configure_streams_response *resp, +struct gb_camera_csi_params *csi_params) {struct ap_csi_config_request csi_cfg;struct gb_connection *conn;@@ -783,8 +783,8 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len) }static int gb_camera_op_configure_streams (void *priv,unsigned int *nstreams, -unsigned int *flags,struct gb_camera_stream *streams, -struct gb_camera_csi_params *csi_params) +unsigned int *flags,struct gb_camera_stream *streams, +struct gb_camera_csi_params *csi_params) {struct gb_camera *gcam = priv;struct gb_camera_stream_config *gb_streams;
Re: [PATCH v2 1/3] staging: greybus: camera: Alignment should match open parenthesis
Quoted 46 lines · Alex Elder
Quoted 2 lines · Nandha Kumar Singaram
Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Alignment should match open parenthesisGenerally, the result of this patch in isolation looks OK. But when you compare it with your next patch, what you're doing here becomes inconsistent with the indentation used for the function arguments there.
There is value in consistency as advocated by checkpatch, but there's also value in consistency within a single source file.
I'd stay away from these white space changes.
-Alex
Quoted 29 lines
Signed-off-by Nandha Kumar Singaram <[email protected]>--- drivers/staging/greybus/camera.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/staging/greybus/camera.c +3
-3@@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection, }static int gb_camera_get_max_pkt_size (struct gb_camera *gcam, -struct gb_camera_configure_streams_response *resp) +struct gb_camera_configure_streams_response *resp) {unsigned int max_pkt_size =0 ;unsigned int i;@@ -378,8 +378,8 @@ struct ap_csi_config_request {#define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000Ustatic int gb_camera_setup_data_connection (struct gb_camera *gcam, -struct gb_camera_configure_streams_response *resp, -struct gb_camera_csi_params *csi_params) +struct gb_camera_configure_streams_response *resp, +struct gb_camera_csi_params *csi_params) {struct ap_csi_config_request csi_cfg;struct gb_connection *conn;@@ -783,8 +783,8 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len) }
Quoted 9 lines
drivers/staging/greybus/camera.c static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len) · line 790
Quoted 8 lines
drivers/staging/greybus/camera.c +2
-2static int gb_camera_op_configure_streams (void *priv,unsigned int *nstreams, -unsigned int *flags,struct gb_camera_stream *streams, -struct gb_camera_csi_params *csi_params) +unsigned int *flags,struct gb_camera_stream *streams, +struct gb_camera_csi_params *csi_params) {struct gb_camera *gcam = priv;struct gb_camera_stream_config *gb_streams;
Thanks Alex for the review.
yeah, I understood about the indentation issue when comparing to other patch but fixing the indentation there results in another checkpatch check(CHECK: line length of 113 exceeds 100 columns) so didn't added any change over there.
Regards,
Nandha Kumar
PATCH v2 2/3 staging: greybus: camera: Modify lines end with a '('
In reply to Nandha Kumar SingaramAdhere to linux coding style. Reported by checkpatch.pl:
CHECK: Lines should not end with a '('
--- drivers/staging/greybus/camera.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/greybus/camera.c +1 -2
@@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,* Validate the stream configuration response verifying padding is correctly * set and the returned number of streams is supported */ -static const int gb_camera_configure_streams_validate_response ( -struct gb_camera *gcam, +static const int gb_camera_configure_streams_validate_response (struct gb_camera *gcam,struct gb_camera_configure_streams_response *resp,unsigned int nstreams) {
Signature · 1 line
2.25.1
PATCH v2 3/3 staging: greybus: bootrom: fixed prefer using ftrace warning
In reply to Nandha Kumar SingaramAdhere to linux coding style. Reported by checkpatch.pl:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
--- drivers/staging/greybus/bootrom.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/greybus/bootrom.c +0 -2
@@ -491,8 +491,6 @@ static void gb_bootrom_disconnect(struct gb_bundle *bundle) {struct gb_bootrom *bootrom =greybus_get_drvdata (bundle); -dev_dbg (&bundle->dev,"%s\n" , __func__); -gb_connection_disable (bootrom->connection);/* Disable timeouts */
Signature · 1 line
2.25.1
Re: [PATCH v2 3/3] staging: greybus: bootrom: fixed prefer using ftrace warning
Quoted 4 lines · Nandha Kumar Singaram
Adhere to linux coding style. Reported by checkpatch.pl:
WARNING: Unnecessary ftrace-like logging - prefer using ftraceSigned-off-by Nandha Kumar Singaram <[email protected]>
This change looks reasonable to me, though I don't think ftrace provides device information.
Quoted 17 lines
--- drivers/staging/greybus/bootrom.c | 2 -- 1 file changed, 2 deletions(-)drivers/staging/greybus/bootrom.c +0
-2@@ -491,8 +491,6 @@ static void gb_bootrom_disconnect(struct gb_bundle *bundle) {struct gb_bootrom *bootrom =greybus_get_drvdata (bundle); -dev_dbg (&bundle->dev,"%s\n" , __func__); -gb_connection_disable (bootrom->connection);/* Disable timeouts */
Re: [PATCH v2 3/3] staging: greybus: bootrom: fixed prefer using ftrace warning
Quoted 15 lines · Alex Elder
Quoted 4 lines · Nandha Kumar Singaram
Adhere to linux coding style. Reported by checkpatch.pl:
WARNING: Unnecessary ftrace-like logging - prefer using ftraceSigned-off-by Nandha Kumar Singaram <[email protected]>This change looks reasonable to me, though I don't think ftrace provides device information.
Acked-by Alex Elder <[email protected]>Quoted 4 lines
--- drivers/staging/greybus/bootrom.c | 2 -- 1 file changed, 2 deletions(-)
Quoted 12 lines
drivers/staging/greybus/bootrom.c static void gb_bootrom_disconnect(struct gb_bundle *bundle) · line 494
Quoted 11 lines
drivers/staging/greybus/bootrom.c +0
-2@@ -491,8 +491,6 @@ static void gb_bootrom_disconnect(struct gb_bundle *bundle) {struct gb_bootrom *bootrom =greybus_get_drvdata (bundle); -dev_dbg (&bundle->dev,"%s\n" , __func__); -gb_connection_disable (bootrom->connection);/* Disable timeouts */
Thanks Alex for the review and feedback.
Regards,
Nandha Kumar