dt-bindings: hwmon: lm87: convert to YAML
Subsystems (2)
PATCH v5 1/1 dt-bindings: hwmon: lm87: convert to YAML
Convert the lm87 hwmon sensor bindings to DT schema
---
Change for v5:
- Change the file name to "ti,lm87.yaml"
- Add maintainers get by get_maintainers.pl Changes for v4:
- remove excess spaces
Changes for v3:
- add type definition of has-temp3, has-in6, has-in7
- Change the description of has-temp3 Changes for v2:
- replace node name lm87 with sensor
- replace character '\t' with spaces
.../devicetree/bindings/hwmon/lm87.txt | 30 --------- .../devicetree/bindings/hwmon/ti,lm87.yaml | 63 +++++++++++++++++++ 2 files changed, 63 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/hwmon/lm87.txt create mode 100644 Documentation/devicetree/bindings/hwmon/ti,lm87.yaml
Documentation/devicetree/bindings/hwmon/lm87.txt deleted +0 -30
@@ -1,30 +0,0 @@ -*LM87 hwmon sensor. - -Required properties: -- compatible: Should be - "ti,lm87" - -- reg: I2C address - -optional properties: -- has-temp3: This configures pins 18 and 19 to be used as a second - remote temperature sensing channel. By default the pins - are configured as voltage input pins in0 and in5. - -- has-in6: When set, pin 5 is configured to be used as voltage input - in6. Otherwise the pin is set as FAN1 input. - -- has-in7: When set, pin 6 is configured to be used as voltage input - in7. Otherwise the pin is set as FAN2 input. - -- vcc-supply: a Phandle for the regulator supplying power, can be - configured to measure 5.0V power supply. Default is 3.3V. - -Example: - -lm87@2e { - compatible = "ti,lm87"; - reg = <0x2e>; - has-temp3; - vcc-supply = <®_5v0>; -};
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +63 -0
63 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 7 lines · Li peiyu
Convert the lm87 hwmon sensor bindings to DT schema
Signed-off-by Li peiyu <[email protected]>---
Change for v5:
- Change the file name to "ti,lm87.yaml"
- Add maintainers get by get_maintainers.pl
Thank you for your patch. There is something to discuss/improve.
...
Quoted 8 lines
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +2
-0@@ -0,0 +1,63 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml line 12
Quoted 10 lines
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +10
-0+--- +$id: http://devicetree.org/schemas/hwmon/ti,lm87.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LM87 hwmon sensor + +maintainers: + - Jean Delvare <[email protected]> + - Krzysztof Kozlowski <[email protected]> + - Rob Herring <[email protected]>
Please drop last two entries. We do not maintain this file. This should be someone interested in the device, like driver maintainer or recent contributor. As last resort, you can put there subsystem maintainer if he is okay with this.
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml line 23
Quoted 11 lines
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +11
-0+ +properties: + compatible: + const: ti,lm87 + + reg: + maxItems: 1 + + has-temp3: + $ref: /schemas/types.yaml#/definitions/flag + description: |
Do not need '|' unless you need to preserve formatting.
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml line 30
Quoted 7 lines
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +7
-0+ When set, pins 18 and 19 are configured to be used as a second + remote temperature sensing channel. Otherwise the pins are + configured as voltage input pins in0 and in5. + + has-in6: + $ref: /schemas/types.yaml#/definitions/flag + description: |
Do not need '|' unless you need to preserve formatting.
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml line 36
Quoted 6 lines
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +6
-0+ When set, pin 5 is configured to be used as voltage input in6. + Otherwise the pin is set as FAN1 input. + + has-in7: + $ref: /schemas/types.yaml#/definitions/flag + description: |
Do not need '|' unless you need to preserve formatting.
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml line 42
Quoted 6 lines
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +6
-0+ When set, pin 6 is configured to be used as voltage input in7. + Otherwise the pin is set as FAN2 input. + + vcc-supply: + description: | + A Phandle for the regulator supplying power, can be configured to
Drop "A Phandle for the"
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml line 50
Quoted 8 lines
Documentation/devicetree/bindings/hwmon/ti,lm87.yaml new file +8
-0+ measure 5.0V power supply. Default is 3.3V. + +required: + - compatible + - reg + +additionalProperties: false +
Rest looks good.
Best regards,
Krzysztof