pinctrl: intel: Move default strength assignment to a switch-case
Subsystems (3)
PATCH 1/1 pinctrl: intel: Move default strength assignment to a switch-case
iWhen ->pin_config_set() is called from the GPIO library (assumed GpioIo() ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.
--- drivers/pinctrl/intel/pinctrl-intel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/pinctrl/intel/pinctrl-intel.c +2 -4
@@ -677,10 +677,6 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,u32 term =0 , up =0 , value;void __iomem *padcfg1; -/* Set default strength value in case none is given */ -if (arg ==1 ) - arg =5000 ; -switch (param) {case PIN_CONFIG_BIAS_DISABLE :break ;
@@ -690,6 +686,7 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,case 20000 : term =PADCFG1_TERM_20K ;break ; +case 1 :/* Set default strength value in case none is given */ case 5000 : term =PADCFG1_TERM_5K ;break ;
@@ -716,6 +713,7 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,case 20000 : term =PADCFG1_TERM_20K ;break ; +case 1 :/* Set default strength value in case none is given */ case 5000 : term =PADCFG1_TERM_5K ;break ;
Signature · 1 line
2.40.0.1.gaa8946217a0b
Mika Westerberg
maintainerQuoted 27 lines · Andy Shevchenko
iWhen ->pin_config_set() is called from the GPIO library (assumed
GpioIo()ACPI resource), the argument can be 1, when, for example, PullDefault is provided. In such case we supply sane default in the driver. Move that default assingment to a switch-case, so it will be consolidated in one place.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/pinctrl/intel/pinctrl-intel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/pinctrl/intel/pinctrl-intel.c +0
-4@@ -677,10 +677,6 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,u32 term =0 , up =0 , value;void __iomem *padcfg1; -/* Set default strength value in case none is given */ -if (arg ==1 ) - arg =5000 ; -switch (param) {case PIN_CONFIG_BIAS_DISABLE :break ;
drivers/pinctrl/intel/pinctrl-intel.c static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin, · line 689
Quoted 4 lines
drivers/pinctrl/intel/pinctrl-intel.c +1
-0@@ -690,6 +686,7 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,case 20000 : term =PADCFG1_TERM_20K ;break ; +case 1 :/* Set default strength value in case none is given */
Same comment here about constant.
Quoted 13 lines
drivers/pinctrl/intel/pinctrl-intel.c +1
-0case 5000 : term =PADCFG1_TERM_5K ;break ;@@ -716,6 +713,7 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,case 20000 : term =PADCFG1_TERM_20K ;break ; +case 1 :/* Set default strength value in case none is given */ case 5000 : term =PADCFG1_TERM_5K ;break ;Signature · 1 line
2.40.0.1.gaa8946217a0b