Skip to contentSkip to conversation

qemuriscv: Add to common MACHINE_FEATURES instead of overriding them

PATCH In review Khem Raj 2 participants 2 messages Oct 30, 2023 – Oct 31, 2023 RISC-V

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 qemuriscv: Add to common MACHINE_FEATURES instead of overriding them

machine features like vfat are needed for ptests to pass ( e..g. parted) This brings it closer to what x86 qemu config looks like as well.

---
 meta/conf/machine/include/riscv/qemuriscv.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/machine/include/riscv/qemuriscv.inc +1 -1
index 46ae66b9e50..7024bd0a4e6 100644
@@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot"
 require conf/machine/include/qemu.inc
 require conf/machine/include/riscv/tune-riscv.inc
 
-MACHINE_FEATURES = "screen keyboard ext2 ext3 serial"
+MACHINE_FEATURES += "keyboard ext2 ext3 serial"
 
 KERNEL_IMAGETYPE = "Image"
 KERNEL_IMAGETYPES += "uImage"
Signature · 1 line
2.42.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Khem Raj

machine features like vfat are needed for ptests to pass ( e..g. parted) This brings it closer to what x86 qemu config looks like as well.

Alistair

Quoted 29 lines
---
 meta/conf/machine/include/riscv/qemuriscv.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/machine/include/riscv/qemuriscv.inc +1 -2
index 46ae66b9e50..7024bd0a4e6 100644
@@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot"
 require conf/machine/include/qemu.inc
 require conf/machine/include/riscv/tune-riscv.inc
 
-MACHINE_FEATURES = "screen keyboard ext2 ext3 serial"
+MACHINE_FEATURES += "keyboard ext2 ext3 serial"
 
 KERNEL_IMAGETYPE = "Image"
 KERNEL_IMAGETYPES += "uImage"
--

2.42.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189809): https://lists.openembedded.org/g/openembedded-core/message/189809
Mute This Topic: https://lists.openembedded.org/mt/102282740/3619028
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-