Skip to contentSkip to conversation

lpfc: Update lpfc to revision 14.2.0.16

PATCH Applied Justin Tee 3 participants 12 messages Oct 31, 2023 – Nov 25, 2023

Subsystems (2)
lore
Share & tools
lore

Justin Tee

author
#0 lore raw

cover lpfc: Update lpfc to revision 14.2.0.16

Update lpfc to revision 14.2.0.16

This patch set contains a user input range check correction, static code analyzer fixes, refactoring of clean up code, and logging enhancements.

The patches were cut against Martin's 6.7/scsi-queue tree.

Justin Tee (9):
lpfc: Correct maximum PCI function value for RAS fw logging
lpfc: Fix possible file string name overflow when updating firmware
lpfc: Fix list_entry null check warning in lpfc_cmpl_els_plogi
lpfc: Eliminate unnecessary relocking in lpfc_check_nlp_post_devloss
lpfc: Return early in lpfc_poll_eratt when the driver is unloading
lpfc: Refactor and clean up mailbox command memory free
lpfc: Enhance driver logging for selected discovery events
lpfc: Update lpfc version to 14.2.0.16
lpfc: Copyright updates for 14.2.0.16 patches

 drivers/scsi/lpfc/lpfc.h         |  1 +
 drivers/scsi/lpfc/lpfc_attr.c    |  4 +--
 drivers/scsi/lpfc/lpfc_els.c     | 53 ++++++++++++++++++++------------
 drivers/scsi/lpfc/lpfc_hbadisc.c |  2 +-
 drivers/scsi/lpfc/lpfc_init.c    |  4 +--
 drivers/scsi/lpfc/lpfc_mbox.c    |  6 ++--
 drivers/scsi/lpfc/lpfc_mem.c     | 47 ++++++++++++++++------------
 drivers/scsi/lpfc/lpfc_sli.c     | 20 +++++++++---
 drivers/scsi/lpfc/lpfc_sli.h     | 10 +++---
 drivers/scsi/lpfc/lpfc_version.h |  2 +-
 10 files changed, 93 insertions(+), 56 deletions(-)
Signature · 1 line
2.38.0
author
#1 lore raw

PATCH 1/9 lpfc: Correct maximum PCI function value for RAS fw logging

Currently, the ras_fwlog_func sysfs parameter allows users to input a value greater than three when selecting a PCI function to enable RAS fw logging feature.

The user's input is sanity checked in lpfc_sli4_ras_init, but allowing an input greater than three doesn't make sense because the max number of ports per HBA is four.

Change the allowable range from [0, 7] to [0, 3].

---
 drivers/scsi/lpfc/lpfc_attr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_attr.c +2 -2
index b1c9107d3408..48c727a51193 100644
@@ -5905,11 +5905,11 @@ LPFC_ATTR_RW(ras_fwlog_level, 0, 0, 4, "Firmware Logging Level");
 /*
  * lpfc_ras_fwlog_func: Firmware logging enabled on function number
  * Default function which has RAS support : 0
- * Value Range is [0..7].
+ * Value Range is [0..3].
  * FW logging is a global action and enablement is via a specific
  * port.
  */
-LPFC_ATTR_RW(ras_fwlog_func, 0, 0, 7, "Firmware Logging Enabled on Function");
+LPFC_ATTR_RW(ras_fwlog_func, 0, 0, 3, "Firmware Logging Enabled on Function");
 
 /*
  * lpfc_enable_bbcr: Enable BB Credit Recovery
Signature · 1 line
2.38.0
author
#2 lore raw

PATCH 2/9 lpfc: Fix possible file string name overflow when updating firmware

In reply to Justin Tee

Because file_name and phba->ModelName are both declared a size 80 bytes, the extra ".grp" file extension could cause an overflow into file_name.

Define a ELX_FW_NAME_SIZE macro with value 84. 84 incorporates the 4 extra characters from ".grp". file_name is changed to be declared as a char and initialized to zeros i.e. null chars.

---
 drivers/scsi/lpfc/lpfc.h      | 1 +
 drivers/scsi/lpfc/lpfc_init.c | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc.h +1 -0
index af15f7a22d25..04d608ea9106 100644
@@ -33,6 +33,7 @@
 struct lpfc_sli2_slim;
 
 #define ELX_MODEL_NAME_SIZE	80
+#define ELX_FW_NAME_SIZE	84
 
 #define LPFC_PCI_DEV_LP		0x1
 #define LPFC_PCI_DEV_OC		0x2
drivers/scsi/lpfc/lpfc_init.c +2 -2
index 9e59c050103d..2c336953e56c 100644
@@ -14725,7 +14725,7 @@ lpfc_write_firmware(const struct firmware *fw, void *context)
 int
 lpfc_sli4_request_firmware_update(struct lpfc_hba *phba, uint8_t fw_upgrade)
 {
-	uint8_t file_name[ELX_MODEL_NAME_SIZE];
+	char file_name[ELX_FW_NAME_SIZE] = {0};
 	int ret;
 	const struct firmware *fw;
 
@@ -14734,7 +14734,7 @@ lpfc_sli4_request_firmware_update(struct lpfc_hba *phba, uint8_t fw_upgrade)
 	    LPFC_SLI_INTF_IF_TYPE_2)
 		return -EPERM;
 
-	snprintf(file_name, ELX_MODEL_NAME_SIZE, "%s.grp", phba->ModelName);
+	scnprintf(file_name, sizeof(file_name), "%s.grp", phba->ModelName);
 
 	if (fw_upgrade == INT_FW_UPGRADE) {
 		ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT,
Signature · 1 line
2.38.0
author
#3 lore raw

PATCH 3/9 lpfc: Fix list_entry null check warning in lpfc_cmpl_els_plogi

In reply to Justin Tee

Smatch called out a warning for null checking a ptr that is assigned by list_entry. list_entry does not return null and, if the list is empty, can return an invalid ptr. Thus, the !psrp check does not execute properly.

drivers/scsi/lpfc/lpfc_els.c:2133 lpfc_cmpl_els_plogi()
warn: list_entry() does not return NULL 'prsp'

Replace list_entry with list_get_first, which does a list_empty check before returning the first entry.

Fixes a3c3c0a806f1 ("scsi: lpfc: Validate ELS LS_ACC completion payload")
---
 drivers/scsi/lpfc/lpfc_els.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +2 -2
index f9627eddab08..0829fe6ddff8 100644
@@ -2128,8 +2128,8 @@ lpfc_cmpl_els_plogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 						NLP_EVT_DEVICE_RM);
 	} else {
 		/* Good status, call state machine */
-		prsp = list_entry(cmdiocb->cmd_dmabuf->list.next,
-				  struct lpfc_dmabuf, list);
+		prsp = list_get_first(&cmdiocb->cmd_dmabuf->list,
+				      struct lpfc_dmabuf, list);
 		if (!prsp)
 			goto out;
 		if (!lpfc_is_els_acc_rsp(prsp))
Signature · 1 line
2.38.0
author
#4 lore raw

PATCH 4/9 lpfc: Eliminate unnecessary relocking in lpfc_check_nlp_post_devloss

In reply to Justin Tee

In lpfc_check_nlp_post_devloss, retaking of the ndlp lock in the if statement is useless because the very next line unlocks. Simply, return to avoid relocking.

---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_hbadisc.c +1 -1
index 7ef9841f0728..f80bbc315f4c 100644
@@ -411,7 +411,7 @@ lpfc_check_nlp_post_devloss(struct lpfc_vport *vport,
 				 "port_state = x%x\n",
 				 ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp,
 				 ndlp->nlp_flag, vport->port_state);
-		spin_lock_irqsave(&ndlp->lock, iflags);
+		return;
 	}
 	spin_unlock_irqrestore(&ndlp->lock, iflags);
 }
Signature · 1 line
2.38.0
author
#5 lore raw

PATCH 5/9 lpfc: Return early in lpfc_poll_eratt when the driver is unloading

In reply to Justin Tee

Add a check in lpfc_poll_eratt when the driver is unloading. There is no point to check for error attention events if the driver is rmmod'ed.

If the driver is reloaded, as part of insmod initialization, then a fresh reset is always asserted to start clean and free of error attention events.

---
 drivers/scsi/lpfc/lpfc_sli.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/scsi/lpfc/lpfc_sli.c +3 -0
index 9386e7b44750..2cb327efd57d 100644
@@ -3938,6 +3938,9 @@ void lpfc_poll_eratt(struct timer_list *t)
 	if (!(phba->hba_flag & HBA_SETUP))
 		return;
 
+	if (phba->pport->load_flag & FC_UNLOADING)
+		return;
+
 	/* Here we will also keep track of interrupts per sec of the hba */
 	sli_intr = phba->sli.slistat.sli_intr;
 
Signature · 1 line
2.38.0
author
#6 lore raw

PATCH 6/9 lpfc: Refactor and clean up mailbox command memory free

In reply to Justin Tee

A lot of repeated clean up code exists when freeing mailbox commands in lpfc_mem_free_all.

Introduce a lpfc_mem_free_sli_mbox helper routine to refactor the copy-paste code. Additionally, reinitialize the mailbox command structure context pointers to NULL in lpfc_sli4_mbox_cmd_free.

---
 drivers/scsi/lpfc/lpfc_mbox.c |  4 +++-
 drivers/scsi/lpfc/lpfc_mem.c  | 45 ++++++++++++++++++++---------------
 drivers/scsi/lpfc/lpfc_sli.c  |  6 +++++
 drivers/scsi/lpfc/lpfc_sli.h  |  8 ++++---
 4 files changed, 40 insertions(+), 23 deletions(-)
drivers/scsi/lpfc/lpfc_mbox.c +3 -1
index 0dfdc0c4c08c..b5ab44234f20 100644
@@ -1814,7 +1814,9 @@ lpfc_sli4_mbox_cmd_free(struct lpfc_hba *phba, struct lpfcMboxq *mbox)
 		dma_free_coherent(&phba->pcidev->dev, SLI4_PAGE_SIZE,
 				  mbox->sge_array->addr[sgentry], phyaddr);
 	}
-	/* Free the sge address array memory */
+	/* Reinitialize the context pointers to avoid stale usage. */
+	mbox->ctx_buf = NULL;
+	mbox->context3 = NULL;
 	kfree(mbox->sge_array);
 	/* Finally, free the mailbox command itself */
 	mempool_free(mbox, phba->mbox_mem_pool);
drivers/scsi/lpfc/lpfc_mem.c +26 -19

71 lines not on this page · raw message

drivers/scsi/lpfc/lpfc_sli.c +6 -0
index 2cb327efd57d..bfbc23248692 100644
@@ -22170,6 +22170,12 @@ struct lpfc_io_buf *lpfc_get_io_buf(struct lpfc_hba *phba,
  * The data will be truncated if datasz is not large enough.
  * Version 1 is not supported with Embedded mbox cmd, so we must use version 0.
  * Returns the actual bytes read from the object.
+ *
+ * This routine is hard coded to use a poll completion.  Unlike other
+ * sli4_config mailboxes, it uses lpfc_mbuf memory which is not
+ * cleaned up in lpfc_sli4_cmd_mbox_free.  If this routine is modified
+ * to use interrupt-based completions, code is needed to fully cleanup
+ * the memory.
  */
 int
 lpfc_read_object(struct lpfc_hba *phba, char *rdobject, uint32_t *datap,
drivers/scsi/lpfc/lpfc_sli.h +5 -3
index cd33dfec758c..14b8b5a3addf 100644
@@ -182,9 +182,11 @@ typedef struct lpfcMboxq {
 		struct lpfc_mqe mqe;
 	} u;
 	struct lpfc_vport *vport; /* virtual port pointer */
-	void *ctx_ndlp;		  /* caller ndlp information */
-	void *ctx_buf;		  /* caller buffer information */
-	void *context3;
+	void *ctx_ndlp;		  /* an lpfc_nodelist pointer */
+	void *ctx_buf;		  /* an lpfc_dmabuf pointer */
+	void *context3;           /* a generic pointer.  Code must
+				   * accommodate the actual datatype.
+				   */
 
 	void (*mbox_cmpl) (struct lpfc_hba *, struct lpfcMboxq *);
 	uint8_t mbox_flag;
Signature · 1 line
2.38.0
author
#7 lore raw

PATCH 7/9 lpfc: Enhance driver logging for selected discovery events

In reply to Justin Tee

Typically, debugging discovery issues requires the ndlp reference count, nlp flags, transport flags, and the io tag for root cause analysis.

Modify important discovery log messages to include one or more of these attributes to aid in debugging and support.

---
 drivers/scsi/lpfc/lpfc_els.c | 49 +++++++++++++++++++++++-------------
 drivers/scsi/lpfc/lpfc_sli.c | 11 +++++---
 2 files changed, 38 insertions(+), 22 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +31 -18
index 0829fe6ddff8..f04326db8c19 100644
@@ -2062,8 +2062,9 @@ lpfc_cmpl_els_plogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 	/* PLOGI completes to NPort <nlp_DID> */
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
 			 "0102 PLOGI completes to NPort x%06x "
-			 "Data: x%x x%x x%x x%x x%x\n",
-			 ndlp->nlp_DID, ndlp->nlp_fc4_type,
+			 "IoTag x%x Data: x%x x%x x%x x%x x%x\n",
+			 ndlp->nlp_DID, iotag,
+			 ndlp->nlp_fc4_type,
 			 ulp_status, ulp_word4,
 			 disc, vport->num_disc_nodes);
 
@@ -2362,9 +2363,10 @@ lpfc_cmpl_els_prli(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 	/* PRLI completes to NPort <nlp_DID> */
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
 			 "0103 PRLI completes to NPort x%06x "
-			 "Data: x%x x%x x%x x%x\n",
+			 "Data: x%x x%x x%x x%x x%x\n",
 			 ndlp->nlp_DID, ulp_status, ulp_word4,
-			 vport->num_disc_nodes, ndlp->fc4_prli_sent);
+			 vport->num_disc_nodes, ndlp->fc4_prli_sent,
+			 ndlp->fc4_xpt_flags);
 
 	/* Check to see if link went down during discovery */
 	if (lpfc_els_chk_latt(vport))
@@ -2805,7 +2807,7 @@ lpfc_cmpl_els_adisc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 	IOCB_t *irsp;
 	struct lpfc_nodelist *ndlp;
 	int  disc;
-	u32 ulp_status, ulp_word4, tmo;
+	u32 ulp_status, ulp_word4, tmo, iotag;
 	bool release_node = false;
 
 	/* we pass cmdiocb to state machine which needs rspiocb as well */
@@ -2818,9 +2820,11 @@ lpfc_cmpl_els_adisc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 
 	if (phba->sli_rev == LPFC_SLI_REV4) {
 		tmo = get_wqe_tmo(cmdiocb);
+		iotag = get_wqe_reqtag(cmdiocb);
 	} else {
 		irsp = &rspiocb->iocb;
 		tmo = irsp->ulpTimeout;
+		iotag = irsp->ulpIoTag;
 	}
 
 	lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_CMD,
@@ -2838,9 +2842,11 @@ lpfc_cmpl_els_adisc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 	/* ADISC completes to NPort <nlp_DID> */
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
 			 "0104 ADISC completes to NPort x%x "
-			 "Data: x%x x%x x%x x%x x%x\n",
-			 ndlp->nlp_DID, ulp_status, ulp_word4,
+			 "IoTag x%x Data: x%x x%x x%x x%x x%x\n",
+			 ndlp->nlp_DID, iotag,
+			 ulp_status, ulp_word4,
 			 tmo, disc, vport->num_disc_nodes);
+
 	/* Check to see if link went down during discovery */
 	if (lpfc_els_chk_latt(vport)) {
 		spin_lock_irq(&ndlp->lock);
@@ -3001,7 +3007,7 @@ lpfc_cmpl_els_logo(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 	int wake_up_waiter = 0;
 	u32 ulp_status;
 	u32 ulp_word4;
-	u32 tmo;
+	u32 tmo, iotag;
 
 	/* we pass cmdiocb to state machine which needs rspiocb as well */
 	cmdiocb->rsp_iocb = rspiocb;
@@ -3011,9 +3017,11 @@ lpfc_cmpl_els_logo(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 
 	if (phba->sli_rev == LPFC_SLI_REV4) {
 		tmo = get_wqe_tmo(cmdiocb);
+		iotag = get_wqe_reqtag(cmdiocb);
 	} else {
 		irsp = &rspiocb->iocb;
 		tmo = irsp->ulpTimeout;
+		iotag = irsp->ulpIoTag;
 	}
 
 	spin_lock_irq(&ndlp->lock);
@@ -3032,9 +3040,11 @@ lpfc_cmpl_els_logo(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 	/* LOGO completes to NPort <nlp_DID> */
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
 			 "0105 LOGO completes to NPort x%x "
-			 "refcnt %d nflags x%x Data: x%x x%x x%x x%x\n",
-			 ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp->nlp_flag,
-			 ulp_status, ulp_word4,
+			 "IoTag x%x refcnt %d nflags x%x xflags x%x "
+			 "Data: x%x x%x x%x x%x\n",
+			 ndlp->nlp_DID, iotag,
+			 kref_read(&ndlp->kref), ndlp->nlp_flag,
+			 ndlp->fc4_xpt_flags, ulp_status, ulp_word4,
 			 tmo, vport->num_disc_nodes);
 
 	if (lpfc_els_chk_latt(vport)) {
@@ -5075,16 +5085,19 @@ lpfc_els_retry(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 	if (logerr) {
 		lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT,
 			 "0137 No retry ELS command x%x to remote "
-			 "NPORT x%x: Out of Resources: Error:x%x/%x\n",
-			 cmd, did, ulp_status,
-			 ulp_word4);
+			 "NPORT x%x: Out of Resources: Error:x%x/%x "
+			 "IoTag x%x\n",
+			 cmd, did, ulp_status, ulp_word4,
+			 cmdiocb->iotag);
 	}
 	else {
 		lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
-			 "0108 No retry ELS command x%x to remote "
-			 "NPORT x%x Retried:%d Error:x%x/%x\n",
-			 cmd, did, cmdiocb->retry, ulp_status,
-			 ulp_word4);
+				 "0108 No retry ELS command x%x to remote "
+				 "NPORT x%x Retried:%d Error:x%x/%x "
+				 "IoTag x%x nflags x%x\n",
+				 cmd, did, cmdiocb->retry, ulp_status,
+				 ulp_word4, cmdiocb->iotag,
+				 (ndlp ? ndlp->nlp_flag : 0));
 	}
 	return 0;
 }
drivers/scsi/lpfc/lpfc_sli.c +7 -4
index bfbc23248692..46e6f807d1ca 100644
@@ -2995,8 +2995,9 @@ lpfc_sli4_unreg_rpi_cmpl_clr(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 		     LPFC_SLI_INTF_IF_TYPE_2)) {
 			if (ndlp) {
 				lpfc_printf_vlog(
-					 vport, KERN_INFO, LOG_MBOX | LOG_SLI,
-					 "0010 UNREG_LOGIN vpi:%x "
+					 vport, KERN_INFO,
+					 LOG_MBOX | LOG_SLI | LOG_NODE,
+					 "0010 UNREG_LOGIN vpi:x%x "
 					 "rpi:%x DID:%x defer x%x flg x%x "
 					 "x%px\n",
 					 vport->vpi, ndlp->nlp_rpi,
@@ -3012,7 +3013,8 @@ lpfc_sli4_unreg_rpi_cmpl_clr(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 				    (ndlp->nlp_defer_did !=
 				    NLP_EVT_NOTHING_PENDING)) {
 					lpfc_printf_vlog(
-						vport, KERN_INFO, LOG_DISCOVERY,
+						vport, KERN_INFO,
+						LOG_MBOX | LOG_SLI | LOG_NODE,
 						"4111 UNREG cmpl deferred "
 						"clr x%x on "
 						"NPort x%x Data: x%x x%px\n",
@@ -10144,11 +10146,12 @@ lpfc_sli_issue_mbox_s4(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq,
 	spin_unlock_irqrestore(&phba->hbalock, iflags);
 	lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI,
 			"(%d):0354 Mbox cmd issue - Enqueue Data: "
-			"x%x (x%x/x%x) x%x x%x x%x\n",
+			"x%x (x%x/x%x) x%x x%x x%x x%x\n",
 			mboxq->vport ? mboxq->vport->vpi : 0xffffff,
 			bf_get(lpfc_mqe_command, &mboxq->u.mqe),
 			lpfc_sli_config_mbox_subsys_get(phba, mboxq),
 			lpfc_sli_config_mbox_opcode_get(phba, mboxq),
+			mboxq->u.mb.un.varUnregLogin.rpi,
 			phba->pport->port_state,
 			psli->sli_flag, MBX_NOWAIT);
 	/* Wake up worker thread to transport mailbox command from head */
Signature · 1 line
2.38.0
author
#8 lore raw

PATCH 8/9 lpfc: Update lpfc version to 14.2.0.16

In reply to Justin Tee

Update lpfc version to 14.2.0.16

---
 drivers/scsi/lpfc/lpfc_version.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_version.h +1 -1
index 88068834cab9..b7d39e2f19fc 100644
@@ -20,7 +20,7 @@
  * included with this package.                                     *
  *******************************************************************/
 
-#define LPFC_DRIVER_VERSION "14.2.0.15"
+#define LPFC_DRIVER_VERSION "14.2.0.16"
 #define LPFC_DRIVER_NAME		"lpfc"
 
 /* Used for SLI 2/3 */
Signature · 1 line
2.38.0
author
#9 lore raw

PATCH 9/9 lpfc: Copyright updates for 14.2.0.16 patches

In reply to Justin Tee

Update copyrights to 2023 for files modified in the 14.2.0.16 patch set.

---
 drivers/scsi/lpfc/lpfc_mbox.c | 2 +-
 drivers/scsi/lpfc/lpfc_mem.c  | 2 +-
 drivers/scsi/lpfc/lpfc_sli.h  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/lpfc/lpfc_mbox.c +1 -1
index b5ab44234f20..cadcd16494e1 100644
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2022 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
drivers/scsi/lpfc/lpfc_mem.c +1 -1
index ef6e5256a35e..2697da3248b3 100644
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2022 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2014 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
drivers/scsi/lpfc/lpfc_sli.h +1 -1
index 14b8b5a3addf..c911a39cb46b 100644
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2022 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
Signature · 1 line
2.38.0
Reviewed-by on the v1 series
#10 lore raw
In reply to Justin Tee
Quoted 22 lines · Justin Tee

Update lpfc to revision 14.2.0.16

This patch set contains a user input range check correction, static code analyzer fixes, refactoring of clean up code, and logging enhancements.

The patches were cut against Martin's 6.7/scsi-queue tree.

Justin Tee (9):
lpfc: Correct maximum PCI function value for RAS fw logging
lpfc: Fix possible file string name overflow when updating firmware
lpfc: Fix list_entry null check warning in lpfc_cmpl_els_plogi
lpfc: Eliminate unnecessary relocking in lpfc_check_nlp_post_devloss
lpfc: Return early in lpfc_poll_eratt when the driver is unloading
lpfc: Refactor and clean up mailbox command memory free
lpfc: Enhance driver logging for selected discovery events
lpfc: Update lpfc version to 14.2.0.16
lpfc: Copyright updates for 14.2.0.16 patches

Quoted 15 lines
drivers/scsi/lpfc/lpfc.h         |  1 +
drivers/scsi/lpfc/lpfc_attr.c    |  4 +--
drivers/scsi/lpfc/lpfc_els.c     | 53 ++++++++++++++++++++------------
drivers/scsi/lpfc/lpfc_hbadisc.c |  2 +-
drivers/scsi/lpfc/lpfc_init.c    |  4 +--
drivers/scsi/lpfc/lpfc_mbox.c    |  6 ++--
drivers/scsi/lpfc/lpfc_mem.c     | 47 ++++++++++++++++------------
drivers/scsi/lpfc/lpfc_sli.c     | 20 +++++++++---
drivers/scsi/lpfc/lpfc_sli.h     | 10 +++---
drivers/scsi/lpfc/lpfc_version.h |  2 +-
10 files changed, 93 insertions(+), 56 deletions(-)
Signature · 1 line
2.38.0

For the series

Signature · 1 line
Himanshu Madhani Oracle Linux Engineering
#11 lore raw
In reply to Justin Tee
Quoted 8 lines · Justin Tee

Update lpfc to revision 14.2.0.16

This patch set contains a user input range check correction, static code analyzer fixes, refactoring of clean up code, and logging enhancements.

The patches were cut against Martin's 6.7/scsi-queue tree.

[...]

Applied to 6.8/scsi-queue, thanks!

[1/9] lpfc: Correct maximum PCI function value for RAS fw logging

      https://git.kernel.org/mkp/scsi/c/2fe4b6a67730
[2/9] lpfc: Fix possible file string name overflow when updating firmware
      https://git.kernel.org/mkp/scsi/c/f5779b529240
[3/9] lpfc: Fix list_entry null check warning in lpfc_cmpl_els_plogi
      https://git.kernel.org/mkp/scsi/c/1dec1311b9b6
[4/9] lpfc: Eliminate unnecessary relocking in lpfc_check_nlp_post_devloss
      https://git.kernel.org/mkp/scsi/c/e07ac2d2aa5f
[5/9] lpfc: Return early in lpfc_poll_eratt when the driver is unloading
      https://git.kernel.org/mkp/scsi/c/57ea41eb7fe6
[6/9] lpfc: Refactor and clean up mailbox command memory free
      https://git.kernel.org/mkp/scsi/c/349b1e2c1bda
[7/9] lpfc: Enhance driver logging for selected discovery events
      https://git.kernel.org/mkp/scsi/c/e6af45218755
[8/9] lpfc: Update lpfc version to 14.2.0.16
      https://git.kernel.org/mkp/scsi/c/c855e02b57ed
[9/9] lpfc: Copyright updates for 14.2.0.16 patches
      https://git.kernel.org/mkp/scsi/c/1f86b0d9c76c
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering