Skip to contentSkip to conversation

ci: add centos stream support

PATCH In review Li Wang 2 participants 8 messages Nov 2, 2023 – Nov 6, 2023

lore
Share & tools
lore

Li Wang

author
#0 lore raw

PATCH 1/1 ci: add centos stream support

This is base on Peter's patch:
CI: ReAplace CentOS 7 with openSUSE Leap 42.2, Ubuntu xenial

Ci: https://github.com/wangli5665/ltp/actions/runs/6729379565

Cc Chao Ye <[email protected]>
Cc Jan Stancek <[email protected]>
Cc Petr Vorel <[email protected]>
---
 .github/workflows/ci.yml     | 12 ++++++++++++
 ci/{centos.sh => quay.io.sh} |  0
 2 files changed, 12 insertions(+)
 rename ci/{centos.sh => quay.io.sh} (100%)
.github/workflows/ci.yml +12 -0
index 9a8a66b6d..27cc5fd72 100644
@@ -69,6 +69,18 @@ jobs:
               METADATA: asciidoc-pdf
               TREE: out
 
+          - container: "quay.io/centos/centos:stream8"
+            env:
+              CC: gcc
+              METADATA: asciidoc-pdf
+              TREE: out
+
+          - container: "quay.io/centos/centos:stream9"
+            env:
+              CC: gcc
+              METADATA: asciidoc-pdf
+              TREE: out
+
           - container: "debian:testing"
             env:
               CC: gcc
ci/quay.io.sh renamed from ci/centos.sh +0 -0
similarity index 100%
rename from ci/centos.sh
rename to ci/quay.io.sh
Signature · 5 lines
2.40.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#2 lore raw

Hi Petr,

Quoted 9 lines · Petr Vorel

Hi Li,

Quoted 4 lines

This is base on Peter's patch:
CI: ReAplace CentOS 7 with openSUSE Leap 42.2, Ubuntu xenial

Ci: https://github.com/wangli5665/ltp/actions/runs/6729379565

Thanks!

Quoted 4 lines

ATM we have 18 jobs, IMHO we should not add more without removing others just to
have reasonable CI runtime.

Your concern makes sense, but I have no idea which one could be removed.

Signature · 5 lines
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw
Quoted 17 lines

Hi Petr,

Quoted 8 lines · Petr Vorel

Hi Li,

Quoted 4 lines

This is base on Peter's patch:
CI: ReAplace CentOS 7 with openSUSE Leap 42.2, Ubuntu xenial

Ci: https://github.com/wangli5665/ltp/actions/runs/6729379565

Thanks!

Quoted 6 lines
Quoted 3 lines

ATM we have 18 jobs, IMHO we should not add more without removing others just to
have reasonable CI runtime.

Your concern makes sense, but I have no idea which one could be removed.

I wonder if just adding CentOS 9 would be enough. Because in CI we test just compilation. The point of the public CI is to test the oldest distros, newest distros and something in between, that should cover the most of compilation problems (no need to test *all* used distros to be safe).
But sure, both can stay if you want. The runtime is still reasonable.
NOTE: I did not care much in case of iputils, which have much faster build than LTP.

If we want to add both CentOS 8 and 9, we could remove some of debian:oldstable (bullseye) (similar kernel).

And, we could add just openSUSE Leap 42.2, which has older glibc and gcc than Ubuntu 16.04 LTS xenial. For sure there are more people which use xenial than old Leap 42.2, but as I said, the goal is to test the oldest distro we maintainers really care about (and do not have extra work for nothing, which is IMHO keeping CentOS 7 compilable).

WDYT?

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#4 lore raw

Hi Petr,

Quoted 49 lines · Petr Vorel
Quoted 9 lines

Hi Petr,

Quoted 4 lines · Petr Vorel

Hi Li,

Quoted 2 lines

This is base on Peter's patch:
CI: ReAplace CentOS 7 with openSUSE Leap 42.2, Ubuntu xenial

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

Ci: https://github.com/wangli5665/ltp/actions/runs/6729379565

Thanks!

Quoted 1 line

ATM we have 18 jobs, IMHO we should not add more without removing

others

Quoted 5 lines
Quoted 2 lines

just to
have reasonable CI runtime.

Your concern makes sense, but I have no idea which one could be removed.

I wonder if just adding CentOS 9 would be enough. Because in CI we test just
compilation. The point of the public CI is to test the oldest distros, newest
distros and something in between, that should cover the most of compilation problems (no need to test *all* used distros to be safe).
But sure, both can stay if you want. The runtime is still reasonable.
NOTE: I did not care much in case of iputils, which have much faster build than
LTP.

If we want to add both CentOS 8 and 9, we could remove some of debian:oldstable (bullseye)
(similar kernel).

And, we could add just openSUSE Leap 42.2, which has older glibc and gcc than
Ubuntu 16.04 LTS xenial. For sure there are more people which use xenial than
old Leap 42.2, but as I said, the goal is to test the oldest distro we maintainers really care about (and do not have extra work for nothing, which is
IMHO keeping CentOS 7 compilable).

Quoted 2 lines

WDYT?

Your explanation is quite useful, thanks!

I'm fine to remove the CentOS8 build in this patch, should I resent the new patch or push it directly?

Signature · 5 lines
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Acked-by
#5 lore raw
Quoted 53 lines

Hi Petr,

Quoted 48 lines · Petr Vorel
Quoted 9 lines

Hi Petr,

Quoted 4 lines · Petr Vorel

Hi Li,

Quoted 2 lines

This is base on Peter's patch:
CI: ReAplace CentOS 7 with openSUSE Leap 42.2, Ubuntu xenial

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

Ci: https://github.com/wangli5665/ltp/actions/runs/6729379565

Thanks!

Quoted 1 line

ATM we have 18 jobs, IMHO we should not add more without removing

others

Quoted 5 lines
Quoted 2 lines

just to
have reasonable CI runtime.

Your concern makes sense, but I have no idea which one could be removed.

I wonder if just adding CentOS 9 would be enough. Because in CI we test just
compilation. The point of the public CI is to test the oldest distros, newest
distros and something in between, that should cover the most of compilation problems (no need to test *all* used distros to be safe).
But sure, both can stay if you want. The runtime is still reasonable.
NOTE: I did not care much in case of iputils, which have much faster build than
LTP.

If we want to add both CentOS 8 and 9, we could remove some of debian:oldstable (bullseye)
(similar kernel).

And, we could add just openSUSE Leap 42.2, which has older glibc and gcc than
Ubuntu 16.04 LTS xenial. For sure there are more people which use xenial than
old Leap 42.2, but as I said, the goal is to test the oldest distro we maintainers really care about (and do not have extra work for nothing, which is
IMHO keeping CentOS 7 compilable).

Quoted 7 lines
Quoted 1 line

WDYT?

Your explanation is quite useful, thanks!

I'm fine to remove the CentOS8 build in this patch, should I resent the new patch or push it directly?

You can push it directly. If it does not apply, feel free to push my change first. I'll post a note about keeping only openSUSE Leap 42.2 in the patchset.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#6 lore raw
Quoted 19 lines · Petr Vorel
Quoted 6 lines
Quoted 6 lines

If we want to add both CentOS 8 and 9, we could remove some of debian:oldstable (bullseye)
(similar kernel).

And, we could add just openSUSE Leap 42.2, which has older glibc and

gcc

Quoted 2 lines
Quoted 2 lines

than
Ubuntu 16.04 LTS xenial. For sure there are more people which use

xenial

Quoted 7 lines
Quoted 7 lines

than
old Leap 42.2, but as I said, the goal is to test the oldest distro we maintainers really care about (and do not have extra work for nothing, which is
IMHO keeping CentOS 7 compilable).

WDYT?

Quoted 9 lines
Quoted 4 lines

Your explanation is quite useful, thanks!

I'm fine to remove the CentOS8 build in this patch, should I resent the new patch or push it directly?

You can push it directly. If it does not apply, feel free to push my change first. I'll post a note about keeping only openSUSE Leap 42.2 in the patchset.

Done, and sorry I just merged the V2 then see you post V3 patches.

Signature · 5 lines
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#7 lore raw
Quoted 27 lines
Quoted 22 lines · Petr Vorel
Quoted 5 lines
Quoted 5 lines

If we want to add both CentOS 8 and 9, we could remove some of debian:oldstable (bullseye)
(similar kernel).

And, we could add just openSUSE Leap 42.2, which has older glibc and

gcc

Quoted 2 lines
Quoted 2 lines

than
Ubuntu 16.04 LTS xenial. For sure there are more people which use

xenial

Quoted 13 lines
Quoted 7 lines

than
old Leap 42.2, but as I said, the goal is to test the oldest distro we maintainers really care about (and do not have extra work for nothing, which is
IMHO keeping CentOS 7 compilable).

WDYT?

Your explanation is quite useful, thanks!

I'm fine to remove the CentOS8 build in this patch, should I resent the new patch or push it directly?

Quoted 6 lines
Quoted 3 lines

You can push it directly. If it does not apply, feel free to push my change first. I'll post a note about keeping only openSUSE Leap 42.2 in the patchset.

Done, and sorry I just merged the V2 then see you post V3 patches.

No problem, thanks for merging. I'll send a patch which removes xenial.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp