Skip to contentSkip to conversation

drm/xe: clear the serviced bits on INTR_IDENTITY_REG

PATCH Superseded Jonathan Cavitt 3 participants 4 messages Nov 3, 2023

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/xe: clear the serviced bits on INTR_IDENTITY_REG

The spec for this register, like many other interrupt related ones, asks software to write back '1' to clear the serviced bits. Let's respect the spec.

v2:
- Update commit message
- Add missing CC

CC Daniele Spurio Ceraolo <[email protected]>
CC Lucas De Marchi <[email protected]>
CC Rodrigo Vivi <[email protected]>
CC Paulo Zanoni <[email protected]>
---
 drivers/gpu/drm/xe/xe_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_irq.c +1 -1
index 61350ed32c61a..af3765c3fc0e2 100644
@@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
 		return 0;
 	}
 
-	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
+	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
 
 	return ident;
 }
Signature · 1 line
2.25.1
#1 lore raw

[Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)

== Series Details ==

== Series Details ==

Series: drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)
URL : https://patchwork.freedesktop.org/series/125971/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: === Base commit: bfa43da8e drm/xe: implement driver initiated function-reset === git am output follows ===
Applying: drm/xe: clear the serviced bits on INTR_IDENTITY_REG

maintainer
#2 lore raw

Re: [Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)

Quoted 6 lines · Patchwork

== Series Details ==

Series: drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)
URL : https://patchwork.freedesktop.org/series/125971/
State : failure

Quoted 6 lines

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: === Base commit: bfa43da8e drm/xe: implement driver initiated function-reset === git am output follows ===
Applying: drm/xe: clear the serviced bits on INTR_IDENTITY_REG

Please rebase it, but feel free to keep the rv-b.

Quoted 2 lines
maintainer Reviewed-by on v2 1/1
#3 lore raw
In reply to Jonathan Cavitt
Quoted 8 lines · Jonathan Cavitt

The spec for this register, like many other interrupt related ones, asks software to write back '1' to clear the serviced bits. Let's respect the spec.

v2:
- Update commit message
- Add missing CC

Quoted 5 lines
CC Daniele Spurio Ceraolo <[email protected]>
CC Lucas De Marchi <[email protected]>
CC Rodrigo Vivi <[email protected]>
CC Paulo Zanoni <[email protected]>
Quoted 20 lines
---
 drivers/gpu/drm/xe/xe_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_irq.c +1 -1
index 61350ed32c61a..af3765c3fc0e2 100644
@@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
 		return 0;
 	}
 
-	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
+	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
 
 	return ident;
 }
Signature · 1 line
2.25.1