kconfig: do not clear SYMBOL_DEF_USER when the value is out of range
PATCH 1/1 kconfig: do not clear SYMBOL_DEF_USER when the value is out of range
When a user-supplied value is out of range, (NEW) and an incorrect default value are shown.
[Test Kconfig]
config FOO
int "foo"
range 10 20[Test .config]
CONFIG_FOO=30
[Result without this fix]
$ make config * * Main menu * foo (FOO) [10] (NEW)
[Result with this fix]
$ make config * * Main menu * foo (FOO) [20]
Currently, the SYMBOL_DEF_USER is cleared if the user input does not reside within the range. Kconfig forgets the initial value 30, and prints (NEW) and an incorrect default [10].
Kconfig should remember the user's input. The default should be [20] because the user's input, 30, is closer to the upper limit of the range.
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/kconfig/confdata.c +1 -1
@@ -594,7 +594,7 @@ int conf_read(const char *name)/* Reset a string value if it's out of range */ if (sym_string_within_range (sym, sym->def[S_DEF_USER ].val))break ; - sym->flags &= ~(SYMBOL_VALID |SYMBOL_DEF_USER ); + sym->flags &= ~SYMBOL_VALID ; conf_unsaved++;break ;default :
Signature · 1 line
2.40.1