bcachefs: Use DECLARE_FLEX_ARRAY() helper and fix multiple -Warray-bounds warnings
PATCH 1/1 bcachefs: Use DECLARE_FLEX_ARRAY() helper and fix multiple -Warray-bounds warnings
Transform zero-length array s into a proper flexible-array member in struct snapshot_table via the DECLARE_FLEX_ARRAY() helper; and fix tons of the following -Warray-bounds warnings:
fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=] fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=] fs/bcachefs/snapshot.c:135:70: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=] fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=] fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=] fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]
This helps with the ongoing efforts to globally enable -Warray-bounds.
--- fs/bcachefs/subvolume_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/subvolume_types.h +1 -1
@@ -20,7 +20,7 @@ struct snapshot_t { };struct snapshot_table { -struct snapshot_t s[0 ]; + DECLARE_FLEX_ARRAY(struct snapshot_t, s); }; typedef struct {
Signature · 1 line
2.34.1
Quoted 23 lines · Gustavo A. R. Silva
Transform zero-length array
sinto a proper flexible-array member instruct snapshot_tablevia theDECLARE_FLEX_ARRAY()helper; and fix tons of the following -Warray-bounds warnings:
fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.c:135:70: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]This helps with the ongoing efforts to globally enable -Warray-bounds.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- fs/bcachefs/subvolume_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/bcachefs/subvolume_types.h +0
-0
fs/bcachefs/subvolume_types.h struct snapshot_t { · line 24
Quoted 6 lines
fs/bcachefs/subvolume_types.h +1
-1@@ -20,7 +20,7 @@ struct snapshot_t { };struct snapshot_table { -struct snapshot_t s[0 ]; + DECLARE_FLEX_ARRAY(struct snapshot_t, s); };
Yup, this is the current way forward for 0-to-flex transformations in unions or alone in structs (until it's supported correctly by GCC and Clang, which is in progress).
-Kees
Signature · 1 line
Kees Cook
Kent Overstreet
AppliedQuoted 11 lines · Gustavo A. R. Silva
Transform zero-length array
sinto a proper flexible-array member instruct snapshot_tablevia theDECLARE_FLEX_ARRAY()helper; and fix tons of the following -Warray-bounds warnings:
fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.c:135:70: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]fs/bcachefs/snapshot.h:36:21: warning: array subscript <unknown> is outside array bounds of 'struct snapshot_t[0]' [-Warray-bounds=]
Quoted 3 lines
This helps with the ongoing efforts to globally enable -Warray-bounds.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks, applied