generic/726,727: add missing _require_scratch_reflink
PATCH 1/1 generic/726,727: add missing _require_scratch_reflink
These two tests require reflink functionality, add the correct statement to ensure that.
--- tests/generic/726 | 2 ++ tests/generic/727 | 2 ++ 2 files changed, 4 insertions(+)
tests/generic/726 +2 -0
@@ -19,6 +19,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter +. ./common/reflink # real QA test starts here
@@ -28,6 +29,7 @@ _require_user _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflink _scratch_mkfs >> $seqres.full _scratch_mount
tests/generic/727 +2 -0
@@ -20,6 +20,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter . ./common/attr +. ./common/reflink # real QA test starts here
@@ -31,6 +32,7 @@ _require_command "$SETCAP_PROG" setcap _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflink _require_attrs security _scratch_mkfs >> $seqres.full
Signature · 1 line
2.39.2
Quoted 22 lines · Christoph Hellwig
These two tests require reflink functionality, add the correct statement to ensure that.
Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/726 | 2 ++ tests/generic/727 | 2 ++ 2 files changed, 4 insertions(+)tests/generic/726 +1
-0@@ -19,6 +19,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter +. ./common/reflink # real QA test starts here
tests/generic/726 _require_user · line 32
Quoted 4 lines
tests/generic/726 +1
-0@@ -28,6 +29,7 @@ _require_user _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflink
Does the "startupdate" actually need reflink feature?
Quoted 27 lines
tests/generic/726 +0
-0_scratch_mkfs >> $seqres.full _scratch_mounttests/generic/727 +2
-0@@ -20,6 +20,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter . ./common/attr +. ./common/reflink # real QA test starts here@@ -31,6 +32,7 @@ _require_command "$SETCAP_PROG" setcap _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflink _require_attrs security _scratch_mkfs >> $seqres.fullSignature · 1 line
2.39.2
Quoted 22 lines · Zorro Lang
Quoted 21 lines · Christoph Hellwig
These two tests require reflink functionality, add the correct statement to ensure that.
Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/726 | 2 ++ tests/generic/727 | 2 ++ 2 files changed, 4 insertions(+)tests/generic/726 +1
-0@@ -19,6 +19,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter +. ./common/reflink # real QA test starts here
Quoted 7 lines
tests/generic/726 _require_user · line 32
Quoted 5 lines
tests/generic/726 +1
-0@@ -28,6 +29,7 @@ _require_user _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflinkDoes the "startupdate" actually need reflink feature?
It does, but the -a switch to the _require_xfs_io_command swapext line above will fail _notrun the test. Or at least it would had I not changed the CLI options when I gave up on getting FIEXCHANGE merged and reworked it as an xfs-only ioctl.
IOWs, the "privatize the FIEXCHANGE" series should fix all these problems for Christoph.
--D
Quoted 29 lines
Quoted 27 lines
tests/generic/726 +0
-0_scratch_mkfs >> $seqres.full _scratch_mounttests/generic/727 +2
-0@@ -20,6 +20,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter . ./common/attr +. ./common/reflink # real QA test starts here@@ -31,6 +32,7 @@ _require_command "$SETCAP_PROG" setcap _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflink _require_attrs security _scratch_mkfs >> $seqres.fullSignature · 1 line
2.39.2
Quoted 31 lines · Darrick J. Wong
Quoted 22 lines · Zorro Lang
Quoted 21 lines · Christoph Hellwig
These two tests require reflink functionality, add the correct statement to ensure that.
Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/726 | 2 ++ tests/generic/727 | 2 ++ 2 files changed, 4 insertions(+)tests/generic/726 +1
-0@@ -19,6 +19,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter +. ./common/reflink # real QA test starts hereQuoted 7 lines
tests/generic/726 _require_user · line 32
Quoted 5 lines
tests/generic/726 +1
-0@@ -28,6 +29,7 @@ _require_user _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflinkDoes the "startupdate" actually need reflink feature?
Quoted 7 lines
It does, but the -a switch to the
_require_xfs_io_commandswapext line above will fail_notrunthe test. Or at least it would had I not changed the CLI options when I gave up on getting FIEXCHANGE merged and reworked it as an xfs-only ioctl.IOWs, the "privatize the FIEXCHANGE" series should fix all these problems for Christoph.
Thanks Darrick, I'll drop this patch temporarily (as I've merged your "privatize the FIEXCHANGE" patch). Please reply to this patch again, if this problem is still there after next release.
Thanks,
Zorro
Quoted 33 lines
--D
Quoted 29 lines
Quoted 27 lines
tests/generic/726 +0
-0_scratch_mkfs >> $seqres.full _scratch_mounttests/generic/727 +2
-0@@ -20,6 +20,7 @@ _begin_fstest auto fiexchange swapext quick # Import common functions. . ./common/filter . ./common/attr +. ./common/reflink # real QA test starts here@@ -31,6 +32,7 @@ _require_command "$SETCAP_PROG" setcap _require_xfs_io_command swapext '-v vfs -a' _require_xfs_io_command startupdate _require_scratch +_require_scratch_reflink _require_attrs security _scratch_mkfs >> $seqres.fullSignature · 1 line
2.39.2