maple_tree: change return type of mas_split_final_node as void.
Subsystems (3)
PATCH 1/1 maple_tree: change return type of mas_split_final_node as void.
mas_split_final_node always returns true and there is no usage for checking return value.
change return type as void.
Signed-off-by Levi Yun <[email protected]>
--- lib/maple_tree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
lib/maple_tree.c +1 -2
@@ -3167,7 +3167,7 @@ static inline void mas_destroy_rebalance(struct ma_state *mas, unsigned char end* @mas: The maple state * @height: The height of the tree in case it's a new root. */ -static inline bool mas_split_final_node (struct maple_subtree_state *mast, +static inline void mas_split_final_node (struct maple_subtree_state *mast,struct ma_state *mas,int height) {struct maple_enode *ancestor;
@@ -3191,7 +3191,6 @@ static inline bool mas_split_final_node(struct maple_subtree_state *mast, mast->l->node = ancestor;mab_mas_cp (mast->bn,0 , mt_slots[mast->bn->type] -1 , mast->l, true); mas->offset = mast->bn->b_end -1 ; -return true; }/*
--
2.39.2
Quoted 4 lines · Levi Yun
mas_split_final_nodealways returns true and there is no usage for checking return value.change return type as void.
Thanks for the patch.
Quoted 2 lines
Signed-off-by Levi Yun <[email protected]>
Reviewed-by Liam R. Howlett <[email protected]>
Quoted 27 lines
--- lib/maple_tree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)lib/maple_tree.c +1
-3@@ -3167,7 +3167,7 @@ static inline void mas_destroy_rebalance(struct ma_state *mas, unsigned char end* @mas: The maple state * @height: The height of the tree in case it's a new root. */ -static inline bool mas_split_final_node (struct maple_subtree_state *mast, +static inline void mas_split_final_node (struct maple_subtree_state *mast,struct ma_state *mas,int height) {struct maple_enode *ancestor;@@ -3191,7 +3191,6 @@ static inline bool mas_split_final_node(struct maple_subtree_state *mast, mast->l->node = ancestor;mab_mas_cp (mast->bn,0 , mt_slots[mast->bn->type] -1 , mast->l, true); mas->offset = mast->bn->b_end -1 ; -return true; }/* -- 2.39.2